Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp317325rdb; Thu, 5 Oct 2023 06:59:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvmwI66YNfmZTxgPF/pt/vCwq0XXeresXKTpmjWTlmvWg6OEs65eaH5TdboP46XDQcZ15W X-Received: by 2002:a05:6358:9185:b0:13a:cb52:4832 with SMTP id j5-20020a056358918500b0013acb524832mr6494327rwa.23.1696514365184; Thu, 05 Oct 2023 06:59:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696514365; cv=none; d=google.com; s=arc-20160816; b=ganRdI5ysgp8q/38PQQt+3kF9WhFXy5/DN+hi6mxcdM+JVgv8AVKv6P8LnVKhsDGvr yyX2O1kF0fCDTT9ojue2Vh0a34fdyVtyMQfiK6F9Rf3OcPRsDDaB3NMK1ym73LXKz59g c01ihcC2WqeqmzYgwZVRlvbDSsoNyeQWq50j+hMge60bZK0SrcXZX00QDhC/wpmxNqm/ 09NEWff9Aow9HYihmXyZwm0Qn/U0IOPKwXYPOCsa4/eU3iAbLGvir/zGQ68pfKv3+kAP Vcl9Hvw/d21RtW195d5iRE9XH0cSeDGFIF1nwNL0SNPlLRnNN0NSFEbelfZEVZUuR5fl kMLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=V1Dt5xQvetzX5s+sYAeSVTV62ptu7rYqH1v9CcB7wS8=; fh=y++c68ie85L3J3QgAbGahScLdfxkMrZYrrd6IvPkK2U=; b=hBlq5VA7gSTh/nekPl9FuAeei8JKEIWjunaXZFbjer87xVPR5XxV4KKx9WU83//6Nt 6IMd34SUOrJwb7d4c8wrVim/QCGDuVle6v8Rpntz/u0438iQx9XNzdWeUVrG98/rPjov p4+FH8fWPsYLIt+B83prYlf3m4TZP+21vFA/kGM3N+4ItYo4/cy+czkd5Hxh9/hSrCtU xK7LPiOU3Jyq40iE3RAH8LQv5We6Hn+kvO4Yh5sbgVCwlt8JtARdv+gzMP/RxNCAyJbX gR9AwAkvCZcsPvFRRscARZhGOZtQo6MuGNSds8J8ksKfsJhLkeSeqHZBASouJwWjERe/ ofxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id o2-20020a17090ac08200b00271ae22eea7si3768785pjs.117.2023.10.05.06.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 06:59:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A9F6680E0B6B; Thu, 5 Oct 2023 06:59:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232591AbjJEN7M convert rfc822-to-8bit (ORCPT + 99 others); Thu, 5 Oct 2023 09:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232005AbjJEN5K (ORCPT ); Thu, 5 Oct 2023 09:57:10 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2934672BC; Thu, 5 Oct 2023 00:10:56 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5a21ea6baccso7249477b3.1; Thu, 05 Oct 2023 00:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696489853; x=1697094653; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kyrdbpuLHB24ipYr+nJjPhE8QlUpRf2FnFEE0De7zV4=; b=YRIXubiyCCYR+2uM9V/2Sia6j+a1A4F2bIEJeGmq5XHkbFFhHA5C5b2e9xQ7R20vPO zPxzp+++293nE5O2QVXLmt2t6ffFPlBEAliMau8tmgEE9rENuJ84nSIzeceUO3bYqlfl zK0T31Pem5qAkVNVVnj0BDcp0/MhndIfCZSqWVpkAx9793+5Uow1ftNBexLNZm0qmKKP sQ3R/5Np7PJYQjsdR/MdpFUxPQQ6HqOEngaInbcc2/HQ/mkVorj01fFMf+3zxhBNmLDZ Dh62QTwnsRRROs+XkU3X1lLmBCWYXXEygq8slnCG5W1YQQmYzZ3LxYKNHVc+TPlKqPOq 67LA== X-Gm-Message-State: AOJu0YwFQskM8Fbhy5dOqeGln67r0we60BBM1W7YXYOaNCGmJLiNgSe5 aEv7YlYbNyb99OM/S6KxnInJJe8jPuytmA== X-Received: by 2002:a0d:cbd3:0:b0:578:5e60:dcc9 with SMTP id n202-20020a0dcbd3000000b005785e60dcc9mr4462229ywd.10.1696489853207; Thu, 05 Oct 2023 00:10:53 -0700 (PDT) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com. [209.85.128.174]) by smtp.gmail.com with ESMTPSA id n184-20020a0de4c1000000b005a4d922cf77sm315914ywe.119.2023.10.05.00.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 00:10:52 -0700 (PDT) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5a21ea6baccso7249337b3.1; Thu, 05 Oct 2023 00:10:52 -0700 (PDT) X-Received: by 2002:a81:a187:0:b0:59b:f152:8998 with SMTP id y129-20020a81a187000000b0059bf1528998mr4833243ywg.19.1696489852617; Thu, 05 Oct 2023 00:10:52 -0700 (PDT) MIME-Version: 1.0 References: <20231004200008.1306798-1-ralph.siemsen@linaro.org> In-Reply-To: <20231004200008.1306798-1-ralph.siemsen@linaro.org> From: Geert Uytterhoeven Date: Thu, 5 Oct 2023 09:10:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX To: Ralph Siemsen Cc: Miquel Raynal , Linus Walleij , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 06:59:24 -0700 (PDT) Hi Ralph, On Wed, Oct 4, 2023 at 10:00 PM Ralph Siemsen wrote: > Enable pin muxing (eg. programmable function), so that the RZN1 GPIO > pins will be configured as specified by the pinmux in the DTS. > > This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS, > however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02 You missed the first character of the commit ID. > since the rzn1 driver does not call any of the generic pinmux functions. > > Signed-off-by: Ralph Siemsen Fixes: 1308fb4e4eae14e6 ("pinctrl: rzn1: Do not select GENERIC_PIN{CTRL_GROUPS,MUX_FUNCTIONS}") Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-pinctrl-fixes-for-v6.6... > --- a/drivers/pinctrl/renesas/Kconfig > +++ b/drivers/pinctrl/renesas/Kconfig > @@ -234,6 +234,7 @@ config PINCTRL_RZN1 > bool "pin control support for RZ/N1" > depends on OF > depends on ARCH_RZN1 || COMPILE_TEST > + select PINMUX > select GENERIC_PINCONF ... with alphabetical sort order restored. No need to resend. > help > This selects pinctrl driver for Renesas RZ/N1 devices. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds