Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 5 Oct 2023 08:20:32 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Florian Fainelli <florian.fainelli@broadcom.com>
Cc:     linux-pwm@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: brcmstb: Utilize appropriate clock APIs in
 suspend/resume
Message-ID: <20231005062032.kklxiavdkaix5sod@pengutronix.de>
References: <20231004175414.1738475-1-florian.fainelli@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ccrp3b53ojxudlcw"
Content-Disposition: inline
In-Reply-To: <20231004175414.1738475-1-florian.fainelli@broadcom.com>
Precedence: bulk


--ccrp3b53ojxudlcw
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Florian,

On Wed, Oct 04, 2023 at 10:54:14AM -0700, Florian Fainelli wrote:
> The suspend/resume functions currently utilize
> clk_disable()/clk_enable() respectively which may be no-ops with certain
> clock providers such as SCMI. Fix this to use clk_disable_unprepare()
> and clk_prepare_enable() respectively as we should.
>=20
> Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/pwm/pwm-brcmstb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
> index a3faa9a3de7c..a7d529bf76ad 100644
> --- a/drivers/pwm/pwm-brcmstb.c
> +++ b/drivers/pwm/pwm-brcmstb.c
> @@ -288,7 +288,7 @@ static int brcmstb_pwm_suspend(struct device *dev)
>  {
>  	struct brcmstb_pwm *p =3D dev_get_drvdata(dev);
> =20
> -	clk_disable(p->clk);
> +	clk_disable_unprepare(p->clk);
> =20
>  	return 0;
>  }
> @@ -297,7 +297,7 @@ static int brcmstb_pwm_resume(struct device *dev)
>  {
>  	struct brcmstb_pwm *p =3D dev_get_drvdata(dev);
> =20
> -	clk_enable(p->clk);
> +	clk_prepare_enable(p->clk);

While at it: Add another patch that checks the return value of
clk_prepare_enable()?

Orthogonally to that, the patch looks fine:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ccrp3b53ojxudlcw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUeVa8ACgkQj4D7WH0S
/k64xwgAgYEYSUsqGUELNGbGXzyYRPZJSUtsFciRuZjNR9ZEwUKz+v43kwZaCkuA
Y32IIriYy62UcIA+qWny7cE/dDnTN8Vo+9dnxINQJX1qIDL3NgT+lak2xE9pdHwh
1qS7vWvwqLWE7Xo6xJtt6jmNO6Xogxg6s/lrpVBgyQL8ubPw/dxOlP6o9oem5B6V
IntnjW7+s3xjZ7MdZ8R+YaH9j1pigeP1floudtD8TxRo4hnz6tiWpvyM/qf41AFL
dM4ck42NE/vNspKRz2lMThpYFIzIbbSIBZrdO6SzaN3xPpIjO7vYFYfi1mmrOGMa
sT6wG3FZt12kYXNfxVTeUS+dtToi2g==
=508Y
-----END PGP SIGNATURE-----

--ccrp3b53ojxudlcw--