Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <c0cf1873-f72d-3cd3-0b70-db70d76546f5@amd.com>
Date:   Thu, 5 Oct 2023 18:08:09 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] soundwire: fix initializing sysfs for same devices on
 different buses
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Mark Brown <broonie@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Mastan Katragadda <Mastan.Katragadda@amd.com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
        "kondaveeti, Arungopal" <arungopal.kondaveeti@amd.com>
References: <20231004130243.493617-1-krzysztof.kozlowski@linaro.org>
 <6628a5f6-ed22-4039-b5c2-2301c05c7e3e@linux.intel.com>
 <2023100453-perfected-palm-3503@gregkh>
 <624b044a-1f0f-4961-8b57-cb5346e7b0d3@linux.intel.com>
 <2023100452-craziness-unpopular-7d97@gregkh>
 <04c5911a-a894-44b3-9f0e-fe9e6de203f2@linux.intel.com>
 <d648c3d1-53ac-4021-ac7f-6a81f1a72dd3@sirena.org.uk>
 <bf4ee895-293f-4bc3-ac4b-30df6361e973@linux.intel.com>
 <c7fb4ead-13af-438b-a199-c52105545047@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <c7fb4ead-13af-438b-a199-c52105545047@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjY4MUFFNnVSZm1DeXVpeldRSkJ6WW1ONmVrMDZaZkpWRUFxcHlKb00zN3Q4?=
 =?utf-8?B?UHhyNjBVNzFMRnA2T0pvOGd5b1NwcFVlZlFPOEVZek5ld0ZpRnk3Z3J5WUgz?=
 =?utf-8?B?ZTdNUnhLdUxkUEF0SzFGYktTZHJlbnVScGFwVXU2TithQ2paQWxQNFR5QjVk?=
 =?utf-8?B?cGVKeWhSQXlHR2MxamFsTjRveGJTaFFtdGY5Mll4WTdpNkQxMmxBV0ZMbFNk?=
 =?utf-8?B?RzJ5SWo3NVNMRnFvcjNzZEd1Y1NMUi9jTHhVVUpWTVlJZUFBcm9JTFZJY3Y2?=
 =?utf-8?B?aHRSenR4VUM0WHA3cHVjNVFjVi91RGp1OE5aekFGUDhmTUhmYzRPZ2V2K2pW?=
 =?utf-8?B?TnlVY0VmMDFHZGtBU1dUS28rekJSWk1OaUJ1SGthelNxM1VkTHhRbnRqOFRx?=
 =?utf-8?B?OG5HTmFWeEFhOTg0RDZid3poVm5ITDlIK3o0SzhHNUZZcDVycU5GSjVRclNx?=
 =?utf-8?B?NHN5elVCRUZraEZoUUVMYUI1MkJtTTcwSVpKQmd3N0tiQVhMRnhESnNFaVhG?=
 =?utf-8?B?aE5rZUo1THZiK25xdVp4NVlOaHBpb282QlJHU0tkT3cydmwxRFlNLzZuRis3?=
 =?utf-8?B?K0VOcWh6aERRU3I2cytmdEYxckE0YWxxMCt4c1FRS21nbzdINC9wZ0NWYkNK?=
 =?utf-8?B?eDBiMDZJZTNsZ0ZwNlFXSVNreCtmSkpwOU9LMFFJT0NVVUg4STZoZ0hSQzRm?=
 =?utf-8?B?MnJFcVY1OFA1bitmMGZrTFlxa0VUZEFFdWZnaFpGSStjdzVEUWxtemxveVoz?=
 =?utf-8?B?eFZ6T0dBemc3SW5jek8vb2VrQ0w5Z1daOHF0dWJkUlJQanJ5NWZ5U3l6QUpL?=
 =?utf-8?B?enB4S29VQWlmei9naWo2WFlDZ0piTmFVOTU1YTkvcE9CTWwrdEdnVGRwbThI?=
 =?utf-8?B?U04vNlhqVlZPME04YmM3RUNWRzVjZVVieWZXRS9VQXg2S0lhRlF3R1lFSVRF?=
 =?utf-8?B?SGtjc1d1S3pmeGhPS0hoT0Nadm12c0wxVWJzdTk5MWswQTVpc2hwZlpMcDl5?=
 =?utf-8?B?N1BHNitsOU41Z0orazlWVVUzVWtPK1RKcWZXSlp6bXZQR0xUeWE0ZDQxVER6?=
 =?utf-8?B?NE9TUmVnN0RWZkhHMFZkVE1NNEhGbHRvM2VWNll2QUE1QTFYallScDc2c3FQ?=
 =?utf-8?B?N21OMlVSeGZLTlNyNngwZW9PdllXWnRSOFUyRU82T0ZZTG05VXpEYk1CVDA4?=
 =?utf-8?B?b3pPUlMzVG01MDFLM1pBazBMclJZRWYyK2RCZGxUUDFiOGllbmhqUU44SXlp?=
 =?utf-8?B?ZTVHeXpOblA5T0xqQnI0SXZLaSsvUXBML3V2Ly9HYkc4S1phWGF3aDQ3RENn?=
 =?utf-8?B?eHBOVTdJajh1MVo3d255c1BqVTFjQitHL3pMaUhZQjBKVTZnd0krU0JDNFo2?=
 =?utf-8?B?bFBTNUFZcDdTKzY1RUhhNERnamxsemgvdUhrT3Yyd290TVBDdVVhcW9FOVpQ?=
 =?utf-8?B?NisxTGlNYVdSdUJ5WlVQcFlXQVJ4SERRYngvNTkzZzAzN05NQU9xRmkxenNJ?=
 =?utf-8?B?cWREQUlnR0RKd1pONUQ0M2tHeVBFY3ladmt1dGJmU3lQb0JpZlg4aVhYSGsv?=
 =?utf-8?B?QzVVVHNGaDQrb0g2Uk54aXh1T1lxWkFiNERZbWw4MFFUbGMrUDlvYUhyMzl3?=
 =?utf-8?B?ZkRralhWVTJjNGlQVUFiUGc5R01CZVMwVXNUUlJ6aXFtQ2c4eTRTQlI0WS9Q?=
 =?utf-8?B?eHVBSDg3WGI2bUhDWDhmQ29VK0JJbTFzd2pTZjVQdjJIQ3FBQ25FYVhUdTRH?=
 =?utf-8?B?aWx3QUN3Mk81cUxQMGp1ZHlQU1FFMWYxMkx5TTg3SUQ4SVVTRlJyL2ljTGd5?=
 =?utf-8?B?ZG95bTRrNWRvampVaExSa1VoMk5rTU95Z3p1N2dhQkxvbDVzaWFwNW1lNmdL?=
 =?utf-8?B?Rld0S3VQTnlLb0VFcnI2YmhMN1c3MXFTdGhvcnd3MG5reUJ0QVh3NVB0QnNq?=
 =?utf-8?B?T24vOUZ4MHZZeFpVemV4N2x5RWlwYUVuUXBMOWw3NHZ2eXJyaHlJWkxVOG5k?=
 =?utf-8?B?MmRkL0xHd1V3c0FqeHUvUFFlZE8xQ2JMSDI5MEpkMkdKS0NKRzVGc1BkR20z?=
 =?utf-8?B?ZWRuQjd5NmZhYnhtQjFqWXE2Q0JINnNTS04reWNLOFUvcmUvZXJFdGdlYmRw?=
 =?utf-8?Q?x6LVXBMAPGtn+9gY/od/0AlYJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b00d0f9c-74f5-4182-c3f8-08dbc59ff5eb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 12:38:22.0908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yq85hjNhLEXZG3nJublPE1/RsdvRk8X2sVVhzUwSvqpCLylVbPbyA9NLIxswKndIhW2H35OUAoFgJgG4PR3+YA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4934
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:15:16 -0700 (PDT)

On 05/10/23 17:54, Pierre-Louis Bossart wrote:
>
>
>> I think we keep circling on the differences between "Controller" and
>> "link" (aka bus). A Controller can have one or more links. A system can
>> have one or more controllers.
>>
>> Intel platforms have one controller and 4 or more links.
>> QCOM platforms have one or more controllers with one link each.
>>
>> I am not sure how this IDA-generated bus_id helps deal with these two
>> cases, since we can't really make any assumptions on how
>> controllers/links will be started and probed.
>>
>> What we are missing is a hierarchical controller/link definition, IOW a
>> controller_id should be given to the master by a higher level instead of
>> using an IDA.
> Tentative patches to introduce a 'controller_id' that's not an IDA are
> here: https://github.com/thesofproject/linux/pull/4616
>
> Initial results are positive for Intel devices. it *should* work for
> other devices but I can't test. If folks at Linaro/Qualcomm and AMD can
> give it a try, that would be much appreciated.
Will test on AMD platforms and let you know the result.

>
> Thanks.