Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231004120529.1155700-1-naresh.solanki@9elements.com> <20231004151433.GA3145438-robh@kernel.org>
In-Reply-To: <20231004151433.GA3145438-robh@kernel.org>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Thu, 5 Oct 2023 13:16:31 +0530
Message-ID: <CABqG17in=LKwsDoPRmN5NMNiZ3wU=bbWiyPdunpwph7hgPSxEw@mail.gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies
To:     Rob Herring <robh@kernel.org>
Cc:     broonie@kernel.org, zev@bewilderbeest.net,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,


On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
> > Add support for multiple supplies.
>
> Why?
1. Driver is already capable of that using platform data. Hence added
support to read DT property & initialize the same for multiple
supplies instead of being limited to one.
2. This is particularly useful in cases wherein 2 or more regulators
are coupled together, for example in a PCIe connector having 3.3V &
12V.

Regards,
Naresh
>
> >
> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > ---
> >  .../devicetree/bindings/regulator/regulator-output.yaml  | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > index 078b37a1a71a..6d077f123729 100644
> > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > @@ -21,13 +21,13 @@ properties:
> >    compatible:
> >      const: regulator-output
> >
> > -  vout-supply:
> > +patternProperties:
> > +  ".*-supply":
> >      description:
> >        Phandle of the regulator supplying the output.
> >
> >  required:
> >    - compatible
> > -  - vout-supply
> >
> >  additionalProperties: false
> >
> > @@ -37,3 +37,8 @@ examples:
> >            compatible = "regulator-output";
> >            vout-supply = <&output_reg>;
> >        };
> > +      output1 {
> > +          compatible = "regulator-output";
> > +          sw0-supply = <&output_reg0>;
> > +          sw1-supply = <&output_reg2>;
> > +      };
> >
> > base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026
> > --
> > 2.41.0
> >