Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 5 Oct 2023 06:38:40 -0700
From:   Breno Leitao <leitao@debian.org>
To:     Rik van Riel <riel@surriel.com>
Cc:     mike.kravetz@oracle.com, muchun.song@linux.dev,
        akpm@linux-foundation.org, Shuah Khan <shuah@kernel.org>,
        linux-mm@kvack.org, open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/mm: Add a new test for madv and hugetlb
Message-ID: <ZR68YM1ImrAGy+ZJ@gmail.com>
References: <20231004171127.106056-1-leitao@debian.org>
 <20231004171127.106056-2-leitao@debian.org>
 <026a75f627bc7ffa45ead3fd6ecb9da7b5bc2692.camel@surriel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <026a75f627bc7ffa45ead3fd6ecb9da7b5bc2692.camel@surriel.com>
Precedence: bulk

On Wed, Oct 04, 2023 at 08:22:08PM -0400, Rik van Riel wrote:
> On Wed, 2023-10-04 at 10:11 -0700, Breno Leitao wrote:
> > 
> > +char *huge_ptr;
> > +
> > +/* Touch the memory while it is being madvised() */
> > +void *touch(void *unused)
> > +{
> > +???????char *ptr = (char *)huge_ptr;
> > +
> > +???????if (!ptr) {
> > +???????????????fprintf(stderr, "Failed to allocate memory\n");
> > +???????????????perror("");
> > +???????}
> 
> I'm not sure this error message makes a lot of sense
> away from where the huge page gets allocated.

Right. I think I don't need this whole "if" clause at all. Let me remove
it.

> > 
> > +???????while (max--) {
> > +???????????????huge_ptr = mmap(NULL, MMAP_SIZE, PROT_READ |
> > PROT_WRITE,
> > +???????????????????????????????MAP_PRIVATE | MAP_ANONYMOUS |
> > MAP_HUGETLB, -1, 0);
> > +
> > +???????????????if ((unsigned long)huge_ptr == -1) {
> > +???????????????????????perror("Failed to allocate\n");
> > +???????????????????????continue;
> > +???????????????}
> 
> Should the test case just exit with an error here, when
> the allocation fails?

Yes, probably skip the test if we are not able to allocate the memory.
I just found I can use something as `ksft_exit_skip()` for this purpose.

Thanks for the great feedbacks!