Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 5 Oct 2023 12:03:30 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, Dhruva Gole <d-gole@ti.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 1/1] serial: 8250_omap: Drop pm_runtime_irq_safe()
Message-ID: <ZR574o7etTozvhzt@smile.fi.intel.com>
References: <20231004062650.64487-1-tony@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231004062650.64487-1-tony@atomide.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Oct 04, 2023 at 09:26:48AM +0300, Tony Lindgren wrote:
> Let's drop the use of pm_runtime_irq_safe() for 8250_omap. The use of
> pm_runtime_irq_safe() is not nice as it takes a permanent usage count on
> the parent device.
> 
> We can finally drop pm_runtime_irq_safe() safely as the kernel now knows
> when the uart port tx is active. This changed with commit 84a9582fd203
> ("serial: core: Start managing serial controllers to enable runtime PM").
> 
> For serial port rx, we already use Linux generic wakeirqs for 8250_omap.
> 
> To drop pm_runtime_irq_safe(), we need to add handling for shallow idle
> state where the port hardware may already be awake and an IO interrupt
> happens. We also need to replace the serial8250_rpm sync calls in the
> interrupt handlers with async runtime PM calls.
> 
> Note that omap8250_irq() calls omap_8250_dma_handle_irq(), so we don't
> need separate runtime PM calls in omap_8250_dma_handle_irq().
> 
> While at it, let's also add the missing line break to the end of
> omap8250_runtime_resume() to group the calls.

Yoo-hoo! A few years only to get to the point :-)
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko