Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp344246rdb; Thu, 5 Oct 2023 07:36:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWsTekKKLzaEXMczJzveeMc50dLtjoVhVb9obsow3U+h4aqhlvGJSUFzaED/jDdc8fb6fk X-Received: by 2002:a9d:62d6:0:b0:6c4:c151:8ebe with SMTP id z22-20020a9d62d6000000b006c4c1518ebemr5530834otk.22.1696516603844; Thu, 05 Oct 2023 07:36:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696516603; cv=none; d=google.com; s=arc-20160816; b=occr+ESFV64gW0cxnZJR2XuAnKyOH2JIJeKxLwZuCKT1vC4TaiDCjKJUSILg+BqLp8 zjmj+2TjzmIoH4P0j/JS35Vj+gBqrr3HU0k4dvDpLYXwEMiXKsN7nRnzp451L2EGWQ9v /y6pPGsHRXCHWdUvvKJaEvzEC8+JozFfkWUVtt6pHurZTtV5UY3yIwtDZtIv3L8ggLUj DqoE1mL13UJQl9YMw+NhZrocIirtksVhDVTFscHxtii2q53fiTmU1oKESOjLICEuZDTV gYYt3FoAEOmvNjhHcEL8jPLisvfplFdHZ10SvzukaAsST7onubh4SGBIywc0q3xUyvru oLNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id; bh=iROKobOe5H8eaB9vKOvpCRcIdeJ1tazmbScyZvV1G54=; fh=CS45FJNEtlWwdGoJkMcRhqleomPp2CXyPpdmqUjz2vY=; b=jgYlvVl9fU7zsXqZebFNgWZ1Dl8cpf28sVqBQn/hTKhFGjqjCwjUy90tXefSyN086q ja3/w3NlPMKJ4lC7p1T+DPFzoCSDgoyxRMzwwl8mHmukwL5qb1dfqg9OB/+jJ7VBp5Md w+x66IIfp3Rh0Wmn7B5l611Qnr9yWJi8ZmYZQWBD4KVooM6cyYBJhKbbe8Hm0jFnlWev MGy5vA+/85vEE9y4eM3x9Cszi5tU7/YT8hKgWB3Q/2c4KC1FLAEK4LVzZkFJ4VWG73C0 SeGKAmv192/K5ZjIiG0Zbuso/meK1FRVS8IQxDjghPVyXEnJq+qiAy0pe1RNqJXq4N52 m8OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id k124-20020a636f82000000b005775a0cd009si1597366pgc.331.2023.10.05.07.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:36:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E8CCA80A857B; Thu, 5 Oct 2023 07:35:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231760AbjJEOfW (ORCPT + 99 others); Thu, 5 Oct 2023 10:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234838AbjJEOd6 (ORCPT ); Thu, 5 Oct 2023 10:33:58 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B67C46A3; Wed, 4 Oct 2023 21:59:57 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4065f29e933so5296725e9.1; Wed, 04 Oct 2023 21:59:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696481992; x=1697086792; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iROKobOe5H8eaB9vKOvpCRcIdeJ1tazmbScyZvV1G54=; b=Lw6dBY/j39DasD92YyeWPc1Kag3du+O2jQ0T9xENK0LBJUNvdRLNd0j1vXPQ+9Kw7q bFaKK4O6oeis77XDGeWTKeIWjFCCM4aKXwzi1SxP7rXDUIR77X4xvofx5tTzrwwv3Q7i /3dSv/9QGwpp48svDS2pVA4ZZSYh/tSOYh+2oVSxi2JBBOMUyRGQHzX6P6rNKJDMgUg3 S86sFEfAfxGTeiBIYuSU0/d6Aek3xlb+6oatmB0ap4A5iuagVAPP5ON9pFU1MlV+TkCA aGH3rH5mAvWNDb3jIgdZjW9TvhYrDc6DSCztw14sNIDILgevxxg2vN4lAnb8jJmZVCn/ FKTg== X-Gm-Message-State: AOJu0Yzfq2ehYdaURRXXlXR1oVX5lXFUVLZJi7BIihwaq7Gb7osL/O3f NHH2Av1I+FaIumTQN9rE0eTfJK/vrwI= X-Received: by 2002:adf:f20c:0:b0:320:77f:a982 with SMTP id p12-20020adff20c000000b00320077fa982mr3720348wro.45.1696481992260; Wed, 04 Oct 2023 21:59:52 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id p1-20020adfce01000000b003258934a4bfsm764421wrn.36.2023.10.04.21.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 21:59:51 -0700 (PDT) Message-ID: <1c2afee3-6c1b-4703-8b9a-487f96a2526b@kernel.org> Date: Thu, 5 Oct 2023 06:59:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] tty: n_gsm: Avoid sleeping during .write() whilst atomic Content-Language: en-US To: Lee Jones , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Daniel Starke , Fedor Pchelkin , linux-serial@vger.kernel.org, syzbot+5f47a8cea6a12b77a876@syzkaller.appspotmail.com References: <20231003170020.830242-1-lee@kernel.org> <2023100320-immorally-outboard-573a@gregkh> <20231003185500.GD8453@google.com> <2023100457-entail-freefall-06fd@gregkh> <20231004090918.GB9374@google.com> <2023100425-unwieldy-reaffirm-2a1b@gregkh> <20231004125758.GB83257@google.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20231004125758.GB83257@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:35:36 -0700 (PDT) On 04. 10. 23, 14:57, Lee Jones wrote: >>> n_gsm is available on all the systems I have available. The mention of >>> 'EXPERIMENTAL' in the module description appears to have zero effect on >>> whether distros choose to make it available or not. If you're saying >>> that we know this module is BROKEN however, then perhaps we should mark >>> it as such. >> >> Also, I think this requires root to set this line discipline to the >> console, right? A normal user can't do that, or am I missing a code >> path here? > > I haven't been testing long, but yes, early indications show that root > is required. FWIW I concluded to the same yesterday, so I disputed the connected CVE-2023-31082. Waiting for mitre's ack/nack. thanks, -- js suse labs