Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp344609rdb; Thu, 5 Oct 2023 07:37:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET8pMZsZ4d/VsVAfgOvls04B+mZ0ZOPHIcYx/iX3e4dA2+1ZbL8x1V2eWBT6LN/2rejLio X-Received: by 2002:a05:6808:f8c:b0:3af:795d:b74b with SMTP id o12-20020a0568080f8c00b003af795db74bmr6374689oiw.50.1696516637662; Thu, 05 Oct 2023 07:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696516637; cv=none; d=google.com; s=arc-20160816; b=EFYscfq+v1j143waY1AInECoG8HpSpow/EzaJ1J7nejGHkipzovSQ1v3o+1dpa95mZ pBi/pITcCB/+g+sdN9jDR1AsjfXYVpAHfAC4iClSK4excm34QB4YE1VXFjzPbI9Brzvf mVtrpH8MvDoJuGz483ewJZi7A7fDbZoW4/Bc2z2rR6b0nVJ843tCbLHhpGbzA/iYFcGK g/rb4J4p7Us07iL1fzA/OgbThXPxqn4UOGeIS0IhxVuwoofzkOxVToVsfJ7eqdkaxhjH S3DiaYYX+7D5NFDnS5qA6C9tn1xE0jH7Xyo+YbokkM56Hq1V0BmRjazAvL9ygrR8YINE 8fyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=khUqT3rbPUUqp4U+3zhDN/Dd3ZxxCh6b4Qb4fdOwNgI=; fh=6dbZcdHfC6F578p1ABflloYOX0sGFKNeP7ugsPhDJG4=; b=oQQ+nFG1zKJuwzA/qwpN0g7nXXAJO9S6NnEEpKOi9/8CdZoeogEEM6qmOJiVoedBXu zrN7i6sykb4aWMydn5OzilK+tbi4cGCRw6gbnetXaDf0XFUN4xOwuMnlbHA5visoyp/O Hdn0d9QNRus81s5Ngh5veqrzAJShFz11VQcCbrVZMRSn6Z6PrrfCLLboylvIqsPCNhf4 Pm6Zntz/EIMGu1keaxOxP4HHdNNtOIj6CfA2Z0FSnhKrbLjQFsKnPRDuW+2ssDJ7CduR LFeRI34TPB2IP1zr5Luem7ge5cJy6twffOVfCeswE4mwfnHXKrDU6EtHVW1p9MbkEBNY XwWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LPgHqoFy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id c23-20020a631c17000000b0057776b67494si1507729pgc.887.2023.10.05.07.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:37:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LPgHqoFy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 0AF4980D2415; Thu, 5 Oct 2023 07:36:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236506AbjJEOgf (ORCPT + 99 others); Thu, 5 Oct 2023 10:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236116AbjJEOej (ORCPT ); Thu, 5 Oct 2023 10:34:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E109526C for ; Thu, 5 Oct 2023 06:52:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFE5CC43140; Thu, 5 Oct 2023 07:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696492538; bh=7xOGM03y69uffWbZv9bkXu3YfXv+0u6k/RTRiM3+i6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LPgHqoFyx5SNfutFWp96HsUtfj/gqhRJQwubvYxCDpMuMUMQHtEetE7iksY84tgOC GRZ4mOhG44IZpRcTmAsL3MYkCQuFx+opZ42F9Wel4h2/lg528cTx1vsIMSIjV9vnxz rXiXtFFTQ91qDLNJIC2AaTOw2YkM6XFw0cFgOZcc= Date: Thu, 5 Oct 2023 09:55:35 +0200 From: Greg KH To: Gary Rookard Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: rtl8192e: renamed (3) variables Message-ID: <2023100529-mounting-sandpaper-5fe2@gregkh> References: <20230928000225.27912-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928000225.27912-1-garyrookard@fastmail.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:36:56 -0700 (PDT) On Wed, Sep 27, 2023 at 08:02:25PM -0400, Gary Rookard wrote: > This patch renames the vaiable in staging/rtl8192e You did not rename a variable. > HTUpdateDefaultSetting -> ht_update_default_setting That is only one rename, not 3. > in (3) files of rtl8192e: > 1) rtl819x_HTProc.c > 2) rtllib.h > 3) rtllib_module.c > > Linux Kernel Coding Style "cleanup", no change in runtime, > staging/rtl8192e builds before and after. I can not parse these lines :( Please read the documentation for how to write a good changelog subject and text, that's one of the most important parts of getting a kernel change accepted. thanks, greg k-h