Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <1f740bdd-666b-4686-8d04-1c28da9917bd@amd.com>
Date:   Thu, 5 Oct 2023 19:27:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v4 00/14] Add Secure TSC support for SNP guests
To:     Borislav Petkov <bp@alien8.de>
Cc:     thomas.lendacky@amd.com, x86@kernel.org, dionnaglaze@google.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com,
        linux-kernel@vger.kernel.org
References: <20230814055222.1056404-1-nikunj@amd.com>
 <f200403b-c460-5ebb-fec5-c5caf0cdb006@amd.com>
 <9a6af215-e696-5091-69fa-1cbebe772471@amd.com>
 <20231004070100.GAZR0NrFSIDKPSQIjA@fat_crate.local>
Content-Language: en-US
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20231004070100.GAZR0NrFSIDKPSQIjA@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmFWN3M3TktQZGlyVmJEMkUrOEpnZWdKTkxDdEpraHd6cktlY0NLdVV6M2o0?=
 =?utf-8?B?Smh5N3dBb0M4d3laV0Q1MkNpNWFHMC9yZVR1OHBHYnZKWXpQWEdxT1FGUzFR?=
 =?utf-8?B?Z25QcWFuWHZjMVNFbW9YUjdjempwbUUxaTR6VHJrV2UzU3JoYWFxL1UzSGox?=
 =?utf-8?B?NTR2QUJ5em96RW5EejNaWndYdDgxOU1DQ2dDQlNjR29JWmtGbU95VEZJVm5M?=
 =?utf-8?B?dzJWdTFuWnpIRmRvZ3FqdmRqazd6ajNhSTlMUEtiRkd5bGRKZ0JFeFU2WWsv?=
 =?utf-8?B?WURFYXA1Q2pMMkpzbm9sWGVxNXdmMnJWcEl2N1UzNG10aksvT3EvUm0reU15?=
 =?utf-8?B?Z1ltMkRaYk13aFB1RkEyOUg3MWFNQkE0QnVxMlF2YWpwTU9jaDNhWVRXbzJo?=
 =?utf-8?B?Tk1hU01QQTRuSlR1NURsU005UkFYTWQxU2k5WTdMLy94N1B1ZDVpZjJycVdl?=
 =?utf-8?B?Q0s0ZkF5eDE0VGpoQnpveVdoVkU1YXdRM0pmUGh3R3FHcXgySXBFTWdETFl4?=
 =?utf-8?B?dUt6Z2hKOVVjaXQyZHRPVzZzNWNjd3RybG5SZ2svbXdnZ0FQRjBaRlJaY3gz?=
 =?utf-8?B?Q2ZLVGozb1ppMkU0aFU5MGovc2pnaUZrTHI0VUR5MEpQV2NLbU03Zkx3aEg3?=
 =?utf-8?B?cS9oRU5DYVdxaDlPNVB3YU1ZeGh3bVNHZGJxZkFoL2prNW41SHJSRSt5VWxk?=
 =?utf-8?B?YVB0OUNCYS9LNUIwdEtySnU0Y2xIS242cE9wekwwV3B2OURJSDRtTnJMNE1T?=
 =?utf-8?B?RVBTeTFsOXd6Y0Fud0dWSENwWmZkTDZLNXA1emJhcVRsSndXQmU2SzdFeWt6?=
 =?utf-8?B?Q2M0SlZhdGRRWjVkQkJURjZ0ekdFS2pwalYvMHVvS0QxOEdPbDBXWFNCcXJ3?=
 =?utf-8?B?RzRUTWVkdm5tTHJ2N1R0MmNzbHR3QUlNVHlkNTdqQ3ZDOTRHTVJTSXE4YTNR?=
 =?utf-8?B?NHRzT0JLeUduOXVNOFlDYVlxSzlMVUdqSGJpT2tNWnlVUlNMWWllcXprb0xt?=
 =?utf-8?B?UTd2ekNFOEplMnIyRWZoaElSOUQ1RzJiVGVpU1A0R3JHU1VqTUlqMTl3MlpP?=
 =?utf-8?B?bDBCZUlpSXRvZTQxV1pWeXJLMjNnRlltTFNSNmFuNWdrQ3hpNitJVFVrSHlV?=
 =?utf-8?B?akRBcERhL1Z0R2tuMDZmQUVMM0I1RDhJRFM4bmJ6U0xTY3YxT1RkeGdWajZZ?=
 =?utf-8?B?UWpjK0lYV3g4b2FISmQ2eFJnNHRMSjRqWTRHWTQ0cVZtdEpjaERmRHdvSzRh?=
 =?utf-8?B?WjZPWHpOK0QzREhkcWNUNnJxYnA1OXRxYWlwc3dNWVJYaXROT3JmeTJ4c0sy?=
 =?utf-8?B?ZGF2VUNBZ2tXUnVpL3JsZUpNMWtubkVMa29ZQ1ZtOVIycWRBRXpkR0V2OGNu?=
 =?utf-8?B?TGZaaG81NHVyZk53SFJ2TlJRdVVydFFBYlllQ1VzN3dPOUswdlkwUUJiK0Nj?=
 =?utf-8?B?OU4xaUZrMVgrL081TVBIUktoc085S2FmaFIyanZQVnlwbEZ2bERZRHVySVFh?=
 =?utf-8?B?T3pNbyt3ZXRCQ1cvRVhEcDgwWmhyVWtGZmxWRE81aWFBQ2NZeFkvVTNsUnNn?=
 =?utf-8?B?aENtVnppQ2h5TjJhK1ZjYnAvTy8vemdDVitPNGtOc1Y1dTNwRU9KR00vaWpy?=
 =?utf-8?B?TWErWlZnNjBsblVLRlljZGs4V21MSTJFM201MWNmR2gxWkhCR1NyY3VISElZ?=
 =?utf-8?B?cXE0SEpFY1lhMWZwcXNUQStJaUFIMXk3ZzhTUStWNVJWZUV3bnNMQjdWMkVC?=
 =?utf-8?B?WWFTRGNpYmg4b1JXMDVrYlM0THlOWHJNa3FFa1pKL3c4bEVDSEJnK3ZiTXVq?=
 =?utf-8?B?NHR4QXZIRE5ldG9XcmJNUzU0bU81TGNuRVpkN2ptZXk0djR1WWpENFo2T3Vk?=
 =?utf-8?B?VTExZExVRjNVMUZKeWRVeUFwejluVElzdVRtK1Z5N3R1M09MaThQbkRCNjNn?=
 =?utf-8?B?TjQxcExUcWp3OFIva253eXRaVS9URTNwUnVwdXAyNlc5SlM4VGlZRG5HVmlS?=
 =?utf-8?B?MDZubXVwQUZ4UUN3ek9HTEV5KzBXWVhwYXRTb3dXazZkU0FoclZlSWxHSW9Y?=
 =?utf-8?B?YS82RFpxM09WcE96WWxPRE03djRVYlVNbXpGc0VXeTNJejVzT0FjNS9GYzdI?=
 =?utf-8?Q?hczBqEA40UUm7vCUV6f+InDuU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24da4624-0277-4df4-d07d-08dbc5ab14e9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 13:57:58.7455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z4W611bDwVXP7qfoLs8PeooN3wiHGO5cW4BoBJEiFLKaX/Cti5ubJ6PlHGhf2RDbB0Hx6rRdU3EW/UVufjDkPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7712
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:38:35 -0700 (PDT)

On 10/4/2023 12:31 PM, Borislav Petkov wrote:
> On Wed, Oct 04, 2023 at 11:05:14AM +0530, Nikunj A. Dadhania wrote:
>> On 8/28/2023 9:17 AM, Nikunj A. Dadhania wrote:
>>> On 8/14/2023 11:22 AM, Nikunj A Dadhania wrote:
>>>> Secure TSC allows guests to securely use RDTSC/RDTSCP instructions as the
>>>> parameters being used cannot be changed by hypervisor once the guest is
>>>> launched. More details in the AMD64 APM Vol 2, Section "Secure TSC".
>>>>
>> ...
>>>>
>>>> Changelog:
>>>> ----------
>>>> v4:
>>>> * Drop handle_guest_request() and handle_guest_request_ext()
>>>> * Drop NULL check for key
>>>> * Corrected commit subject
>>>> * Added Reviewed-by from Tom
>>>
>>> A gentle reminder.
>>
>>
>> Ping ?
> 
> Pong.
> 
> How about you find other SEV patches on LKML which are waiting for
> review and review them, while waiting for yours?

That is a good idea and I wasn't aware that this may work as a good bribe [1] :-)

Regards,
Nikunj

[1] https://lore.kernel.org/all/20230816081942.GBZNyGnk%2FK+nDuBzsC@fat_crate.local/