Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp345465rdb; Thu, 5 Oct 2023 07:38:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEe+A4ienWMrgd5KKhZYUF0bjRQN4MJE8oEDXtyxZ66m8p2IBZKlm0iSaOqiQLz4FUvLV6H X-Received: by 2002:a05:6a20:549e:b0:161:28e0:9abd with SMTP id i30-20020a056a20549e00b0016128e09abdmr6584343pzk.16.1696516731487; Thu, 05 Oct 2023 07:38:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696516731; cv=none; d=google.com; s=arc-20160816; b=idOxD7oXTVm2uphgqamoBVs9PLgp6WU4U1oOnr8CspakIyFMM8p0kMkxq5Arv7Q3BU 0sOc/N6iVU3/ARPvJ1St50KVLajPCKuA6SWKaDlBmmcg9SPcW3m0klgv17hIw5ZN+YXh 0RsJ84fD02+Hjn2+mHWuEkB48bGp54HLSck91hWa7OmLUSc0ilFN9y8pvaR/7lrtXFBx YZjMyAZ28u2iorsiyH4whAcHm8O7Uis+sYX3zbkGPS9F0Gwz0rPHIfaQfHg6hvHRtsWT OKQ44Uo2l5HHP6sXGKhHgVu4zBQti/BQph7/yWaTIIm+2Y4WVvVsB0v0MXiNvzZoebhG oGRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=3ex7mhh2wNwC1ElK8hxF+83j+vTpDKL0Hxu33BudBd8=; fh=9XvXJnMKYCCfkafogIuF87ZC9aGYqFicnX7GBn/z0Qg=; b=BOzkRPmgzK+URUR5iiME3+xtJgmtk9n/CkSGEufLKbQ3Jd3Opb4X49e/hFvo5/We40 AD37mO6193gq/GQB4px+0yJZuPcJrxlOOWBFR8Q5SFYYUwqgZGli9YeFHu2D6gFq3Mfb uhPi9GgnVQj9pBtE8I4TGDZ73cbQMha1AHf5ZVInTcHyxqZxgSeQxZZna4t8OpYrmLpM /vcbXS7ieaMj+eaeihc3h7vaRmLyC1uLbt/QwT0t9+wfbUa03G8WtZtbWj5Ru1iY6yBw 9LCu6fXEjkBzEPpLQ33I5Da4OAckBaOwdzqMPOr+/U1ugqB1GUclZkOGAMMAdu0MgRjU cFcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=MWciXcw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id t29-20020a63b25d000000b005859c221c6dsi1632368pgo.221.2023.10.05.07.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:38:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=MWciXcw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8B14C85C6CE6; Thu, 5 Oct 2023 07:38:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237080AbjJEOi1 (ORCPT + 99 others); Thu, 5 Oct 2023 10:38:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235373AbjJEOfu (ORCPT ); Thu, 5 Oct 2023 10:35:50 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 562633790D; Thu, 5 Oct 2023 06:58:54 -0700 (PDT) Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395D7At8014585; Thu, 5 Oct 2023 13:14:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=3ex7mhh2wNwC1ElK8hxF+83j+vTpDKL0Hxu33BudBd8=; b=MWciXcw9Mk5LbHWdbl1mR3kLIsj5/hHig5wyk5zJzaPcyw7X+i2ZrMCzDiHl0OFoxORW N/HA45jFni71aaWEKoDfa+ky44f4UPOq4vNLWOI3h2oeiU25jQXx7Eh+YlbTWqUoJB6x U3zKDhjTeuTcJDHReE/xu+H6u3RvZwvWygyUlAyyMDMNVj2Q4PZgDSi26zihSsPXtBGq PzJu1rK3PXs6OnNI03sHPROY8c0fFbYSV8ThON3eYtdBGbwWxwpwVG7ricpuJTre3UaT F5aGZsK2AvIS91P5kBlHERUSb9+G0sYAlHuKNYujuC+RII8rw2/UfLgiIRuDpOe4ji5S NQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3thwrdrbbe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:14:06 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 395D785C014528; Thu, 5 Oct 2023 13:10:57 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3thwrdr93w-62 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:10:57 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 395ACNA9010931; Thu, 5 Oct 2023 11:47:08 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tf0q2angr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 11:47:08 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 395Bl7mJ262752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Oct 2023 11:47:07 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BE9B5805A; Thu, 5 Oct 2023 11:47:07 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6BC8358052; Thu, 5 Oct 2023 11:47:06 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.61.90.188]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 5 Oct 2023 11:47:06 +0000 (GMT) Message-ID: <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com> Subject: Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2) From: Mimi Zohar To: Amir Goldstein , syzbot Cc: hdanton@sina.com, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, mszeredi@redhat.com, syzbot@syzkalhler.appspotmail.com, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Date: Thu, 05 Oct 2023 07:47:06 -0400 In-Reply-To: References: <0000000000001081fc0606f52ed9@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mBwZEAiNtaVL6b8uRu3IAIxO_elfKi-K X-Proofpoint-ORIG-GUID: Moy2T3K-Oh6VNFoTbGhz-ZhtPfbNOcl5 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_08,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=711 adultscore=0 clxscore=1011 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050103 X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SORTED_RECIPS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:38:50 -0700 (PDT) On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote: > On Thu, Oct 5, 2023 at 12:59 PM syzbot > wrote: > > > > Hello, > > > > syzbot tried to test the proposed patch but the build/boot failed: > > My mistake. Please try again: > > #syz test: https://github.com/amir73il/linux ima-ovl-fix Thanks, Amir. "mutext_init(&iint->mutex); moved, but the status initialization lines 161-166 were dropped. They're needed by IMA- appraisal for signature verification. iint->ima_file_status = INTEGRITY_UNKNOWN; iint->ima_mmap_status = INTEGRITY_UNKNOWN; iint->ima_bprm_status = INTEGRITY_UNKNOWN; iint->ima_read_status = INTEGRITY_UNKNOWN; iint->ima_creds_status = INTEGRITY_UNKNOWN; iint->evm_status = INTEGRITY_UNKNOWN;