Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp347239rdb; Thu, 5 Oct 2023 07:41:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIqHbOMVQXj1KC8+WBpxFh94FNoTbnPQmdJ774hZHpWULFRxb03Wr4RyjNDyRDM1D+B+kH X-Received: by 2002:a17:903:2804:b0:1b8:954c:1f6 with SMTP id kp4-20020a170903280400b001b8954c01f6mr5041446plb.36.1696516914347; Thu, 05 Oct 2023 07:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696516914; cv=none; d=google.com; s=arc-20160816; b=eKpw6mOv+zVSX48488uCgXLFpLFF9dHpgpSMplJ++f11JQyHka9LXOnvBrg2gx8mv4 fOgd0QBjYlEv1pZbZjfIf11y4acSESaT/EHtTPsG2dXHK+TiTELJmtUhDcUvGqo0YLTN zt7qmMNy+GALE/23LhiMJIEqqfRExJz2R2LQyaVfA0DXqwq1JZCJjh/JlGHtpTtO40Di Hy2KMDscJOyK9yZDt0O9veZphS6L3Nvw7Joftc5dz5ogcdTyLl08yizWl+RT5o5IlKgs jZlVuXeTcX3Pl6JlIe4CFGhqfM3y1+mvonUo3kPZnAQlbVx5yF8KBIsPNFTZylF69Mo8 rQhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YMZmUrNYw6o3TZ9aUjLAav1/RTZjvgb7yvD20l3JpOU=; fh=8CIbPoeSUOt7KistPF1OkA0uHmYcC4ZoNCt0Prc1DP0=; b=HH6pXhDbf1I2uoKNFhaKSFJzODSJrbSJm7iJVsmNh2tnKSeSwOKTzYPpaTXXjKa6J5 0AXzNaW4kfOUMkAktXYI5qpjtDpyDxXQE4gSYj504WxSe6gRhi7TrYbYtVYtab/pva04 JoSuxiBpRDBjC/05Pqh5FIpi1zkwWofT4DTXdBAw/tPGslDLc4yDHvXAuog73ulW9yY5 A/IokzF7eO2krO63bUku4GC10zaJuZg4VB7mvHFDZANug/siJitfBEDqxorrWn4PlmGN E5/+mIjBJnJJCRCE6hyTnpS0qvMpy6tspn+yb2qIt97H5PEIqVvtfM+PAaPh/xUJELB9 hE3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Pv/AR6Jk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id lo5-20020a170903434500b001c6036c5b74si1542189plb.245.2023.10.05.07.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Pv/AR6Jk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A2FD180A90C9; Thu, 5 Oct 2023 07:41:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237557AbjJEOjZ (ORCPT + 99 others); Thu, 5 Oct 2023 10:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236627AbjJEOgo (ORCPT ); Thu, 5 Oct 2023 10:36:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9527C3F025 for ; Thu, 5 Oct 2023 07:01:17 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36419C116B6; Thu, 5 Oct 2023 13:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696514369; bh=yjYdr6NMBB3N4qwB1LomEzfwhBRh5oJTamUwrfSI7OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pv/AR6JkSGeFIqnlvX/drtjCXMOJLu7iGRRabEsczdjGjHPumeaL14UkUNumGcccb IZfT7lvUQiSii+Qj50KUaQeE1RHc0J/khpg/N1wnp1QN6m70mZxWtWP6ye+vG4aXM9 kd3IHzcf78Vb+ZTlUNm0tg3hWRCbruWm8prlVHPU= Date: Thu, 5 Oct 2023 15:59:26 +0200 From: Greg KH To: Zhang Shurong Cc: Thinh.Nguyen@synopsys.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: fix possible object reference leak Message-ID: <2023100512-crayon-prowess-0f27@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:41:25 -0700 (PDT) On Thu, Oct 05, 2023 at 09:49:46PM +0800, Zhang Shurong wrote: > The of_find_device_by_node takes a reference to the struct device > when find the match device,we should release it when fail. > > Fix it by calling by calling platform_device_put when error returns. > > Signed-off-by: Zhang Shurong > --- What commit id does this fix? And how did you find this? How was it tested? thanks, greg k-h