Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230928164550.980832-2-dtatulea@nvidia.com> <20230928164550.980832-17-dtatulea@nvidia.com>
In-Reply-To: <20230928164550.980832-17-dtatulea@nvidia.com>
From:   Eugenio Perez Martin <eperezma@redhat.com>
Date:   Thu, 5 Oct 2023 12:14:30 +0200
Message-ID: <CAJaqyWe2btM+8Hbnq9ROyh-bhQA5vVwNk9xgSHb_gFme9dJViw@mail.gmail.com>
Subject: Re: [PATCH vhost 15/16] vdpa/mlx5: Make iotlb helper functions more generic
To:     Dragos Tatulea <dtatulea@nvidia.com>
Cc:     gal@nvidia.com, "Michael S . Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 28, 2023 at 6:50=E2=80=AFPM Dragos Tatulea <dtatulea@nvidia.com=
> wrote:
>
> They will be used in a followup patch.
>
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> ---
>  drivers/vdpa/mlx5/core/mr.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/core/mr.c b/drivers/vdpa/mlx5/core/mr.c
> index 3dee6d9bed6b..a4135c16b5bf 100644
> --- a/drivers/vdpa/mlx5/core/mr.c
> +++ b/drivers/vdpa/mlx5/core/mr.c
> @@ -454,20 +454,20 @@ static void destroy_dma_mr(struct mlx5_vdpa_dev *mv=
dev, struct mlx5_vdpa_mr *mr)
>         mlx5_vdpa_destroy_mkey(mvdev, mr->mkey);
>  }
>
> -static int dup_iotlb(struct mlx5_vdpa_dev *mvdev, struct vhost_iotlb *sr=
c)
> +static int dup_iotlb(struct vhost_iotlb *iotlb, struct vhost_iotlb *src)

It would be great to move this patch to vhost/iotlb, especially
because it can be reused by vdpa_sim. But it can be done on top for
sure,

Acked-by: Eugenio P=C3=A9rez <eperezma@redhat.com>

>  {
>         struct vhost_iotlb_map *map;
>         u64 start =3D 0, last =3D ULLONG_MAX;
>         int err;
>
>         if (!src) {
> -               err =3D vhost_iotlb_add_range(mvdev->cvq.iotlb, start, la=
st, start, VHOST_ACCESS_RW);
> +               err =3D vhost_iotlb_add_range(iotlb, start, last, start, =
VHOST_ACCESS_RW);
>                 return err;
>         }
>
>         for (map =3D vhost_iotlb_itree_first(src, start, last); map;
>                 map =3D vhost_iotlb_itree_next(map, start, last)) {
> -               err =3D vhost_iotlb_add_range(mvdev->cvq.iotlb, map->star=
t, map->last,
> +               err =3D vhost_iotlb_add_range(iotlb, map->start, map->las=
t,
>                                             map->addr, map->perm);
>                 if (err)
>                         return err;
> @@ -475,9 +475,9 @@ static int dup_iotlb(struct mlx5_vdpa_dev *mvdev, str=
uct vhost_iotlb *src)
>         return 0;
>  }
>
> -static void prune_iotlb(struct mlx5_vdpa_dev *mvdev)
> +static void prune_iotlb(struct vhost_iotlb *iotlb)
>  {
> -       vhost_iotlb_del_range(mvdev->cvq.iotlb, 0, ULLONG_MAX);
> +       vhost_iotlb_del_range(iotlb, 0, ULLONG_MAX);
>  }
>
>  static void destroy_user_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdp=
a_mr *mr)
> @@ -544,7 +544,7 @@ void mlx5_vdpa_destroy_mr_resources(struct mlx5_vdpa_=
dev *mvdev)
>         for (int i =3D 0; i < MLX5_VDPA_NUM_AS; i++)
>                 mlx5_vdpa_destroy_mr(mvdev, mvdev->mr[i]);
>
> -       prune_iotlb(mvdev);
> +       prune_iotlb(mvdev->cvq.iotlb);
>  }
>
>  static int _mlx5_vdpa_create_mr(struct mlx5_vdpa_dev *mvdev,
> @@ -596,8 +596,8 @@ int mlx5_vdpa_update_cvq_iotlb(struct mlx5_vdpa_dev *=
mvdev,
>
>         spin_lock(&mvdev->cvq.iommu_lock);
>
> -       prune_iotlb(mvdev);
> -       err =3D dup_iotlb(mvdev, iotlb);
> +       prune_iotlb(mvdev->cvq.iotlb);
> +       err =3D dup_iotlb(mvdev->cvq.iotlb, iotlb);
>
>         spin_unlock(&mvdev->cvq.iommu_lock);
>
> --
> 2.41.0
>