Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <75435ec6-f205-1ae1-94ba-9c41fd82a045@intel.com>
Date:   Thu, 5 Oct 2023 15:33:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH net v2] devlink: Hold devlink lock on health reporter dump
 get
To:     Moshe Shemesh <moshe@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>
CC:     Jiri Pirko <jiri@nvidia.com>, <linux-kernel@vger.kernel.org>
References: <1696510216-189379-1-git-send-email-moshe@nvidia.com>
Content-Language: en-US
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <1696510216-189379-1-git-send-email-moshe@nvidia.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzRmL1lwS2NqQTZUbzdHUVFQQUI2WE8ydVNrVG9BaTFiM0I1UHA2MGxKTytp?=
 =?utf-8?B?Um5QNnNIZWZoRDFPdXlwNnpRMXhlb3NDUnNOemhndU9BVFF4VmdzOEloZWpK?=
 =?utf-8?B?U0N5NkJMMW5lMFMvcFc2Rlp3YVRra1BPQTU0QnhxaEpVazJyMkNBS3R0UkQ4?=
 =?utf-8?B?SVl0N1A2SXpjQ29jYUJKUkN1S3JsUndCdTJDcy9pQXJMblNqV0pWVlJIS1hl?=
 =?utf-8?B?am1xd095ekRZZ2Y3NUtWSHh2eElsYnFLN2gzTEpQdTNWaU5QN0ZPZkFrQkNG?=
 =?utf-8?B?cTRPOFd4K2RqM1BOb2tBbnBCN1hReFE1SnFucCsxL3U4R2dBZWMwYmRtRGxn?=
 =?utf-8?B?NFgvYW9JZkFEeUNOUDg0WDdOM1BqemxkVzdxZWFTT1BhUlJ6azFoVmZZRGZj?=
 =?utf-8?B?KzA0QWZBWmw3SHk3d3R2MDJNSFg3RXRLUXpWYmZyMVgyclp6eWYzRnl5UWRT?=
 =?utf-8?B?WS8xRUpIU0x1SVc0R09LamxxVWViYlhUdWE5QzdoRXo4R0lmV3F5OW5nZWhn?=
 =?utf-8?B?WmJ4a2k4QkpkbkswOC9qNlFPdm9JcUF2a0QxZUk4c2VqdlZMVWloSGhMRW8y?=
 =?utf-8?B?cUlCWHdqYnNTQjhJOW0zYzdlY3dlbzFlV2puQXNLY2EzSkNqNjNmbWhLRGQx?=
 =?utf-8?B?Qjh1ck9xaG9EdHU4Qm9BcHMxOWYrYVFSQjBFUEM5T2dqbXlrbjc3SEV1ZXJ5?=
 =?utf-8?B?T3BsTGZWVFpGcXl2U0QyOHNOUEdtRURTQzEzSFhMK3lLVTE5eE5qRjBZQ09i?=
 =?utf-8?B?M2YxdEs0SzZMZkJldytib1VXYU1CN3poVUc5SCtLcmVVOGhhSW9GdWt1a2k3?=
 =?utf-8?B?ZXBZaWNqQ21wWjA1TlA4SVR6U1JEb3krQzNNNCtLUXVadGNIc29lSkFjeWZ3?=
 =?utf-8?B?ZEdlVkVjQTc5YnlSbm81R0NSaFA3cEpkU241OUtDNWc3U01GelJzYzVZN2I1?=
 =?utf-8?B?SXhrVWJkZEYydG1FeENhSFJGVjA5MlZHRG9MZ0pjbDRKMHp3dm9RaHJNZU90?=
 =?utf-8?B?a1ozSy9MNEhxWE9jc1BqeXE1d2ZPOEg3N0kwMWdRcE9tbVFPNEFoUEdWY1Uy?=
 =?utf-8?B?VDFrYTZadnl4ZXdCRWlqaWxLSXlTSnkwL0RlQm54NmFlWFNCNlN2c0RJckF6?=
 =?utf-8?B?Qm5uYXp0ZzNUSnEvcW1JRmhwWlBibmE0OFBHK1d4NEcvbjdEWE9sK2ZOczBy?=
 =?utf-8?B?dk9TRDd5RCtWVnhPdklTRFdOTlZIRlBkVjVkNFpqZWE0YnFaSjlzWEFUZUtN?=
 =?utf-8?B?ZW5hbXZpc1QwaUF4K1JqMmVxSlA4MldocndVZTY0YTRYL29wOEMxcFBwTWk0?=
 =?utf-8?B?T2VmWVJYNzNHamZyK09uMGpMUGhtVjM1d2ZCdkxmRGtXTjRQUGNuMXJNSVpX?=
 =?utf-8?B?RkpXS1dUdjJRMklMSXlremJtdytoR3Z6OHhLZ05PVy8wSjdnS0xsQzNWQTlr?=
 =?utf-8?B?c1BUd1ZFRmYxOFlnQUhGa0NXYjZIWUNXWE92emxPK3RqYlJsbkR6N3RETTNj?=
 =?utf-8?B?ekxRaExadzdKd3hFTFNYMTM5a0NKZ3d4c2hmMElGbnNQcTVYVkRUeS8wckwy?=
 =?utf-8?B?eXJveGQ5NzVyRktwaUhDY01Iem55N0RYUC9zVTBCVmtDdm1pbWt1K3lnVzRw?=
 =?utf-8?B?U21zbnAxbzJNS3ZSU0xsT3JRNFVGVUY1TW9XMTB1eklGeHE5bHVFNHZWbDkw?=
 =?utf-8?B?dWpNekR0NXRqK2g5TGs3YWM0WElpVXRxRjV2N1YyY2Vyb1VyVzU1c3NjQUFs?=
 =?utf-8?B?SnBRWDkxZnpOMkkxUWdQeitCOERNYy8rQ1cvSGtsN25HRThsdkdDbzQ1NlZv?=
 =?utf-8?B?TnczUXd5YjlieG9wKytaOEkvaUpOV1l4Yld5WTlkWUN6dUVuSklRQzRmQmp6?=
 =?utf-8?B?NTNkQmt4Um5peXRrQVhXNjlBWUVtQ2MrZG5FV0duQ2YrMzVMa3FNdExKaEwv?=
 =?utf-8?B?OGlqc1VweWpHSStTenNLcnl4cWU1VVdQQ1FVcEw1UHRJQTE2TDFobTh1NXBw?=
 =?utf-8?B?SkRxQkl5d2w2RThuaHlBTEdMUkJuOTh4SFZXRnIrOFZTSTVNY3k2bHpvUzdj?=
 =?utf-8?B?Z2MzYUYxUHhjMC96ZXBscS9CVkV6UEl3Y2NBOE5DZXJwWVdQUEkrNE9ZSFFh?=
 =?utf-8?B?WkJRWHZrV0dPVXJSU1BNRWZTWnUySzNGaEgvbkpQcUw3QWpsdHMzYW5yZFA3?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9214c2ca-0291-455f-4c5d-08dbc5a7a16f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 13:33:16.4537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gjM/7o1lHxh696Qel4BCAiTSauAZDiwKsbtXFN+a5SBd1tZz4bZY4489QrSPAUy3CmnXjZHkjPjUym3ccB/bPRpDaPytOAMAeEsBPH9e71w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5036
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:48:42 -0700 (PDT)

On 10/5/23 14:50, Moshe Shemesh wrote:
> Devlink health dump get callback should take devlink lock as any other
> devlink callback. Otherwise, since devlink_mutex was removed, this
> callback is not protected from a race of the reporter being destroyed
> while handling the callback.
> 
> Add devlink lock to the callback and to any call for
> devlink_health_do_dump(). This should be safe as non of the drivers dump
> callback implementation takes devlink lock.
> 
> As devlink lock is added to any callback of dump, the reporter dump_lock
> is now redundant and can be removed.
> 
> Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex")
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> ---
> v1->v2:
> - Commit message, added why this fix is necessary and why its safe to do.
> ---
>   net/devlink/health.c | 30 ++++++++++++++++--------------
>   1 file changed, 16 insertions(+), 14 deletions(-)
> 

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>