Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp351328rdb; Thu, 5 Oct 2023 07:48:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFid8SGE3QokNULohZynBmETGBOsJM/S8JGSW/Xoqmn2D7dGl0ipyBtxjbU1OQy5MkvjGGF X-Received: by 2002:a05:6a20:1453:b0:14e:b4d5:782d with SMTP id a19-20020a056a20145300b0014eb4d5782dmr6370825pzi.2.1696517327949; Thu, 05 Oct 2023 07:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696517327; cv=none; d=google.com; s=arc-20160816; b=OI0rDfZXHNJAFhkKO9QEHZRQ03Hxn2ZtPE/EHe8tqq0CMQFGoK6TdQ6BFTo6LCfDpZ YuDrhmvoI8UCWK76SfZaBydl79AlWLrzJesacfZErPFu46lg3zyYCBzA7N7JIHaSHlUq Lo6nlwZyhO2WDzc/YX7FOe8fkdz3SChOTki6sDFGzPe290wmCvl21aeG0pXr1flpCxPI SAVfEwgU1YsYD2z7e6LxdifbDIv5YLT4rTL8OzAP6uI9RynXKHn4cRxK/cgw/vsSn+jc 7mmU7/YoekyM5I6Gqfuk8+x9ZWEQGibXbBWliMQ7qnBZ1mHvgBAFDn0/MoXNeao/PXOD NTiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A5jpNg3cSk8TMyVzO2d20o3o+iGqMpnPDy+RtcTORAc=; fh=91hPz9EG6Kphu6ymeIpcVYr78mexbipC6Pf939/EnrY=; b=Nf0Ey7g/M/OlY/AfXdMXp7+3kdANozlk6mIuIsIrqs6uiXErAzAlcjH+pGwKxaARVQ 2fye29OqiepcT8tUW3lzQ/xdy7kTkfQ8A3BBP+ibrBopWqZvvA7yM7u9YwOj1WveSP5o Ft4m3bL1X7baSSiYefjBztmeb5hTrlkCXPwYcjvirfoVJST9VYDf2Pq5mbJrnM43+K75 0SMF+hg1GFOyMW0pVlB3q7p45yRK4H1hsLYR/6z0Dl3lBgXhpz07GQE3NHEITf05tU04 lOZ5ptXa0iUHjmjwI4/uCaf/raSNmCKAxWmeXtWjVuA3mFC+M++TGk3mOa9CgLDP/bmJ yjfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sokU60XW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id 30-20020a63105e000000b00578d78f2a70si1576281pgq.388.2023.10.05.07.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 07:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sokU60XW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C68A687182AE; Thu, 5 Oct 2023 07:48:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240059AbjJEOsC (ORCPT + 99 others); Thu, 5 Oct 2023 10:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239903AbjJEOop (ORCPT ); Thu, 5 Oct 2023 10:44:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651959F6DF; Thu, 5 Oct 2023 07:22:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C68C4339A; Thu, 5 Oct 2023 06:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696485946; bh=rk5p7W6fSQ6pw6CpBqK3HLdmoCK6lM1ieyuWARySvic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sokU60XWR+EfzHCLK43tEYXy9berTkNUZW7mZfQDwM+Gy8WwKE/QBiiHNzSNYyYZu +TZoEIZQJX7vZnZcroCoGDmOlAJGfBIUAPcCjHZAco68IpYXvgsOmE7Eba5u/3V6bt Ew4u7dLEay8PA73HpCunzek9VBixgSGGjtb8QJXY= Date: Thu, 5 Oct 2023 08:05:43 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: Lee Jones , linux-kernel@vger.kernel.org, Daniel Starke , Fedor Pchelkin , linux-serial@vger.kernel.org, syzbot+5f47a8cea6a12b77a876@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] tty: n_gsm: Avoid sleeping during .write() whilst atomic Message-ID: <2023100511-unpeeled-dinginess-fefd@gregkh> References: <20231003170020.830242-1-lee@kernel.org> <2023100320-immorally-outboard-573a@gregkh> <20231003185500.GD8453@google.com> <2023100457-entail-freefall-06fd@gregkh> <20231004090918.GB9374@google.com> <2023100425-unwieldy-reaffirm-2a1b@gregkh> <20231004125758.GB83257@google.com> <1c2afee3-6c1b-4703-8b9a-487f96a2526b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c2afee3-6c1b-4703-8b9a-487f96a2526b@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 07:48:46 -0700 (PDT) On Thu, Oct 05, 2023 at 06:59:50AM +0200, Jiri Slaby wrote: > On 04. 10. 23, 14:57, Lee Jones wrote: > > > > n_gsm is available on all the systems I have available. The mention of > > > > 'EXPERIMENTAL' in the module description appears to have zero effect on > > > > whether distros choose to make it available or not. If you're saying > > > > that we know this module is BROKEN however, then perhaps we should mark > > > > it as such. > > > > > > Also, I think this requires root to set this line discipline to the > > > console, right? A normal user can't do that, or am I missing a code > > > path here? > > > > I haven't been testing long, but yes, early indications show that root > > is required. > > FWIW I concluded to the same yesterday, so I disputed the connected > CVE-2023-31082. Waiting for mitre's ack/nack. Trying to dispute obviously-wrong CVEs is a never-ending task. Personally, it's fun to see who keeps popping up to attempt to resolve this issue showing what companies have their security policies dictated by a random government authority that can be modified by anyone :) thanks, greg k-h