Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 5 Oct 2023 16:54:12 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     "Gupta, Nipun" <nipun.gupta@amd.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>, maz@kernel.org, jgg@ziepe.ca,
        linux-kernel@vger.kernel.org, git@amd.com, harpreet.anand@amd.com,
        pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, abhijit.gangurde@amd.com,
        srivatsa@csail.mit.edu
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus
Message-ID: <2023100531-stick-cupped-78f6@gregkh>
References: <20230911135259.14046-1-nipun.gupta@amd.com>
 <2023100531-matron-oversold-4a73@gregkh>
 <87wmw1p4g5.ffs@tglx>
 <2023100547-retool-chamomile-d581@gregkh>
 <51b6606a-fdc1-de11-2260-863ac08071fd@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51b6606a-fdc1-de11-2260-863ac08071fd@amd.com>
Precedence: bulk

On Thu, Oct 05, 2023 at 08:07:35PM +0530, Gupta, Nipun wrote:
> Hi Greg,
> 
> On 10/5/2023 7:30 PM, Greg KH wrote:
> > On Thu, Oct 05, 2023 at 03:46:34PM +0200, Thomas Gleixner wrote:
> > > On Thu, Oct 05 2023 at 12:24, Greg KH wrote:
> > > > > diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
> > > > > index a08958485e31..86df7ccb76bb 100644
> > > > > --- a/drivers/cdx/Kconfig
> > > > > +++ b/drivers/cdx/Kconfig
> > > > > @@ -8,6 +8,7 @@
> > > > >   config CDX_BUS
> > > > >   	bool "CDX Bus driver"
> > > > >   	depends on OF && ARM64
> > > > > +	select GENERIC_MSI_IRQ_DOMAIN
> > > > 
> > > > This config option isn't in my tree anywhere, where did it come from?
> > > > What is it supposed to do?
> > > 
> > > 13e7accb81d6 ("genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN") :)
> > 
> > Ok, so this hasn't been tested since the 6.2 release?  Wow, I think
> > someone from AMD needs to take a deep look at this and verify that it
> > actually is doing what it is supposed to be doing...
> 
> The patch Thomas mentioned renames "GENERIC_MSI_IRQ_DOMAIN" to
> "GENERIC_MSI_IRQ"; and in our testing "GENERIC_MSI_IRQ" is also selected as
> 'ARM64' is enabled which enables 'ARM_GIC_V3_ITS' which in-turn selects
> 'GENERIC_MSI_IRQ'.

Ok, but that's not what this patch "selects" at all :(

> The patch is tested for MSI functionality on 6.6-rc1. We will re-look into
> the config dependencies to avoid such issues, but please be assured that the
> patch has been validated.

How has the dependancy been validated as correct if there is no such
thing in this kernel?

confused,

greg k-h