Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp389684rdb; Thu, 5 Oct 2023 08:47:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhhDk9Mnb6QuqrQNiWpA3YUVmIos8jZZWWA2isZfMZdc+/PG2dP7K4onpeoMLR4Vn5UBES X-Received: by 2002:a05:6808:f07:b0:3ab:8431:8037 with SMTP id m7-20020a0568080f0700b003ab84318037mr7157651oiw.32.1696520825493; Thu, 05 Oct 2023 08:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696520825; cv=none; d=google.com; s=arc-20160816; b=QRGT4ig0PJgH+/lz3cCgp7VZnr/OjHzSyyFr6Qk5W4ug6KcxnIuJyE5LtO+/sEWe3p Z4YdbS5XEqhdWm0JdPgem2ujEdVQPHomAw3SBncjN7jeB7p5/UuFA/1u6SQqyba5z9WF om62Iuls/SQ4fHN26IQiIvzvRWAwCRvZE72jbS0fzOPb8lLYI4P5EAm47HY8mAakVnuG fneXy4PIQmQx7l73mTl1W/Cc02UHLs/Bdnls/OIB+Q4Xe4dnrkjiusSxY54/5G7DApC4 qoZ6f+qESy9theeD8HRUQMFilu7OZYJk9D+aodVTG/GGf5RycH8K7iHtybDKcBrCWsr4 0GpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=S/pgBAubRFhprxSLu5wZwOmv4MlVCLPwfPONmD04YFE=; fh=c/r8pQi4lwacmPSvtM38GywBbpqlueBhwtwgO74HxLY=; b=drBeHsrqSATKWTGN2pG1fMDErp6z4cO3bl5z1Cyrhy/Wnpj2p8EoqF84TZaMdM/H47 3VPpl/AEnpNigVKW/xw1mDW9v0K13JKLpzy5d/maaj4mCXlgoy2E1zAtVxHOp9tLPDrj E/w6VtpQkiKfuMJAfNHDeRGkKj82aCkxJtJbIoUDLE0YniI9/fvmoFXtiSCeCnyXZK/J 870rsB5Nyi1WSN+y/djhUqLx1yXXRWtnPcfnYN3jvAh5PYZZwZansNzQS/wLlXKplmTQ HEsNc6hIIahtXTfsc5xJ7RGfKNKMrHdDCPPDm+9JIeOxRgbHunfeXWS9llcInG30iq4s Hsdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cZ6jTkFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id k8-20020a633d08000000b00565e87d8707si1775866pga.496.2023.10.05.08.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 08:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cZ6jTkFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 79E8A8070EFA; Thu, 5 Oct 2023 08:46:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjJEPpt (ORCPT + 99 others); Thu, 5 Oct 2023 11:45:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233951AbjJEPpB (ORCPT ); Thu, 5 Oct 2023 11:45:01 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B9207694; Thu, 5 Oct 2023 07:32:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68020C433BC; Thu, 5 Oct 2023 07:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696490769; bh=OX4KD6sfNOWtabDqGM1DP4NFuApW1Y4ZymyK5RMSEPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cZ6jTkFREYPJRFOwRFjbSPJ7/FDC/aGBRU0UrLvX7xZstG1VZmUsL6+x41d8A02ZI B1CRAWlPaX2eIFD4fr/SJJUP0l1sY957YCEBfpwHesJjjfIbCPlxxhfYhDtckIPXdh hRC5DUDj8QFpvjPzyLsuC+CQdlzXujp6enO4QlzNhEEY7zfWp5ceqDfwz1qf4/AXub 71OC4T1LFCeeUf5BB/SxQk9+G7TsMlk9Pw/PUz7xK2sQ5Ds/OMHsAf8GrhvDXppNj9 Ot2y4YfFLZ3VRZxUeubUk5FBbOZJPPvVk258+Jhs0dOOw63K9smDgiHwyFFOkcz2VQ H+ZIDfq3b9wwQ== Date: Thu, 5 Oct 2023 08:26:04 +0100 From: Lee Jones To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, Daniel Starke , Fedor Pchelkin , linux-serial@vger.kernel.org, syzbot+5f47a8cea6a12b77a876@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] tty: n_gsm: Avoid sleeping during .write() whilst atomic Message-ID: <20231005072604.GC83257@google.com> References: <20231003170020.830242-1-lee@kernel.org> <2023100320-immorally-outboard-573a@gregkh> <20231003185500.GD8453@google.com> <2023100457-entail-freefall-06fd@gregkh> <20231004090918.GB9374@google.com> <2023100425-unwieldy-reaffirm-2a1b@gregkh> <20231004125758.GB83257@google.com> <1c2afee3-6c1b-4703-8b9a-487f96a2526b@kernel.org> <2023100511-unpeeled-dinginess-fefd@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023100511-unpeeled-dinginess-fefd@gregkh> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 05 Oct 2023 08:46:51 -0700 (PDT) On Thu, 05 Oct 2023, Greg Kroah-Hartman wrote: > On Thu, Oct 05, 2023 at 06:59:50AM +0200, Jiri Slaby wrote: > > On 04. 10. 23, 14:57, Lee Jones wrote: > > > > > n_gsm is available on all the systems I have available. The mention of > > > > > 'EXPERIMENTAL' in the module description appears to have zero effect on > > > > > whether distros choose to make it available or not. If you're saying > > > > > that we know this module is BROKEN however, then perhaps we should mark > > > > > it as such. > > > > > > > > Also, I think this requires root to set this line discipline to the > > > > console, right? A normal user can't do that, or am I missing a code > > > > path here? > > > > > > I haven't been testing long, but yes, early indications show that root > > > is required. > > > > FWIW I concluded to the same yesterday, so I disputed the connected > > CVE-2023-31082. Waiting for mitre's ack/nack. > > Trying to dispute obviously-wrong CVEs is a never-ending task. > > Personally, it's fun to see who keeps popping up to attempt to resolve > this issue showing what companies have their security policies dictated > by a random government authority that can be modified by anyone :) It's a struggle! :) -- Lee Jones [李琼斯]