Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp389866rdb; Thu, 5 Oct 2023 08:47:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRzqz4lANnrEDkib6Iaig271RRqjiX8ZLLpRXo5Hqb4yB7DRKr9WQSL6OmmEEa9eSWs4BP X-Received: by 2002:a17:902:ee86:b0:1c5:ad14:907a with SMTP id a6-20020a170902ee8600b001c5ad14907amr5313314pld.38.1696520841220; Thu, 05 Oct 2023 08:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696520841; cv=none; d=google.com; s=arc-20160816; b=LJK7xxG7LBPH2D+CsuBDmEebfHmFNKFTlilisQkCzhcWI6GByqpWwqQLnd1/usb3Mw lTa1MN477zrwjKa2i6EZErO4HpcUxqUrhOkNN8zbw6EPxkarS7pAjBe6NkK6ybcw85PX AoFP08NIpVMcNpHzL0/OcRJpIU1I8jvIiGpTDQhxKB2yyHmS/6ZKaK5iB00jaSx5vopp pZVNRAfX1n8EbmYMLqHb63DFvos8/rukOWtqvmVDOMuk9EfE8MkdplAYApAj36ekUMef kd0CpUwKb09I+IGkKEXF8q8Ncbk1u7XuqzwuK2EkcCNkgDUMupV6bUPUyF/7rgoRtBPv /6pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=j7v78EfYr5kWBGVx9Q0yeHqQ9MIDixPPetJ6nvLJ2nc=; fh=CFQtq7elmocrCSqpofIWhP0vsw6+jaKSd+Q1Yw8Ec2I=; b=VzWpDcRZlVWZUZ7U4W5vdDL6Uk0RL/ZFeFCUoZWnijavsOpiZZQnPqWyFK+/Td/mfW AeadnkCN0Hd0UgH3VMP7ABT52EhdTgSBke4/XpQGA0KMHYZ8SA3T3Ce/OhUbhHZEdVhh 5JvcJPpoXXepp6UALUlyc5IlTN2n+Lnd6R14wH1c86GK6b0qntDq6qrSWCPK9II5LPUv jDkq7eyBVPZFEEu6fNlC9+Ct1IPrPJvbVXH2VFo70MaIXO3O12UpUBnTwXuvPTVj9US+ +S+HPBRQAGfu7jSwodjsBFC4wqGV9USCRJBaD8Hpu8v1TDhCVtgQ9UPDa7rMktY5cpmf cbZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foxmail.com header.s=s201512 header.b=Q1EOr3sP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id kw13-20020a170902f90d00b001b674055d72si1604959plb.621.2023.10.05.08.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 08:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@foxmail.com header.s=s201512 header.b=Q1EOr3sP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D7C1D82222BB; Thu, 5 Oct 2023 08:47:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234003AbjJEPqA (ORCPT + 99 others); Thu, 5 Oct 2023 11:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233960AbjJEPpG (ORCPT ); Thu, 5 Oct 2023 11:45:06 -0400 Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FAC658E; Thu, 5 Oct 2023 08:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1696518098; bh=j7v78EfYr5kWBGVx9Q0yeHqQ9MIDixPPetJ6nvLJ2nc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Q1EOr3sPF+C02Z9y8KIbwTZOG7fwnZjX9n5Dq2v2HiP7FvMH2e6y01F4d46nYbBRq RmU0WuCxgaFsugA6hmrUewisTEQf2E5scs+XGcRQNzDwS3CEXc1Wu6EUIthmO6Vgro QkhRSqA5VFY/hwCYxKtZG5om5LSSrC89JfBLhGpc= Received: from [10.255.87.57] ([122.14.229.252]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id 6299CF5; Thu, 05 Oct 2023 23:01:34 +0800 X-QQ-mid: xmsmtpt1696518094tyxh55cxd Message-ID: X-QQ-XMAILINFO: N8kVz9D657mRghfTFuheWxMrr0xSlkTJvrM9oKOp5NOWHliJN+ctqLKGt97tFL m3fz4DS2pnsYA+PNV3STpG+lWIHV6mz2eVcyPT+9ZVSohw4YhsVGOVorP60vX9itD6HRWouswlkP uqd+5yAcNqjUdBVs78KFqerqFLjQ2FSNBa10zhueGXzVJL8/OQlfUUg7au0y2QybffnXu0hPhM2D AseFv1dzmfBf/XLrmLBTHB93y02qKt2rBCKfDLJMiPJ8VrO456vwkvyjscNVB3rhk/6UC/44sf/K aVmpVa+Kgi1UUDCTKHTbLoodV5599fXSes7B4vCu30JrrOzugSlXUBcOu89RnvTTAUNzO3TNtslQ tN/JFsRxV7QvmWGXbtWo0lzkNx0xHgq2ydXIeyM/O/Y0v00gG+PtT+VxAIL3xXCeFzOr+KCKsl1r uit6OEIuteYr1LjFseTW2i6q8ih+Enz5kQlZGf6iflGNi4Jwtd6p2doE+5C8FKpfcnLkCdqVLg/8 6vjGeuHWSab2VU4uREAq66UhZRHPt8TJqUsPyLkOKDOYXwTdlUji0x+gmfhj/0c0IV/5jkblu5Hl XpcZnjxZw0MUKCgP0DG/DvinadUuCF3AV50GW7so5uCiIAh6BWu61b5NzjfCDwO/CgxPN/xm2haq LBTHzesSnCb6/CwKy4CouVSmftE6Ht59ZGHzXvOHcp3dM+UiQzFutnVNnR2ChydntH2GrtyW5IZQ ZHmU6XkE6zLIJZDCytV0P8OpeA951BDqxY2ZycevqV9bjPRhcWFfrVPjB3x9nWLklFwNmBvjstYS 20xYf0e76yFi/knHIwg2fC/7r6W6M+/Bm3MnlSLnzleMX2m25ukWoxqkVcfGLf7fm5MIprDEDiwn DKRAPamy2c6D7bHAKgIAl3XNqPoJFyxzOzc9z5iRB4TBVCLJxe/lPTT7JAbJU2mtql+YnNlA9AZw jNRFrcHZiIeIrrGHVCquNHflmyBM6um1vycxdgyW7+c/3i9WMzKZgDIvlE514MlzI0S/XH/lWq0e NVJX5tdjj9BltgNfA18GRmQAjW2fYhdc98wvQRSH0vEI+i1gMDiRFXqkncaMy104LkRpk45Q== X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= X-OQ-MSGID: <3e289937-f216-4ead-abac-28d35d644f9c@foxmail.com> Date: Thu, 5 Oct 2023 23:01:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: dwc3: fix possible object reference leak Content-Language: en-US To: Greg KH Cc: Thinh.Nguyen@synopsys.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <2023100512-crayon-prowess-0f27@gregkh> From: Zhang Shurong In-Reply-To: <2023100512-crayon-prowess-0f27@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_MUA_MOZILLA,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 05 Oct 2023 08:47:13 -0700 (PDT) I apologize for the poorly formatted patch. I will make the necessary revisions and send it to you again. Additionally, I thought that it may not be straightforward to test but I will try. Kind regards, Shurong 在 2023/10/5 21:59, Greg KH 写道: > On Thu, Oct 05, 2023 at 09:49:46PM +0800, Zhang Shurong wrote: >> The of_find_device_by_node takes a reference to the struct device >> when find the match device,we should release it when fail. >> >> Fix it by calling by calling platform_device_put when error returns. >> >> Signed-off-by: Zhang Shurong >> --- > What commit id does this fix? > > And how did you find this? How was it tested? > > thanks, > > greg k-h