Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <99d707a3-5274-1603-d0ed-f67ce83b7e29@amd.com>
Date:   Thu, 5 Oct 2023 20:35:28 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>, maz@kernel.org, jgg@ziepe.ca,
        linux-kernel@vger.kernel.org, git@amd.com, harpreet.anand@amd.com,
        pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, abhijit.gangurde@amd.com,
        srivatsa@csail.mit.edu
References: <20230911135259.14046-1-nipun.gupta@amd.com>
 <2023100531-matron-oversold-4a73@gregkh> <87wmw1p4g5.ffs@tglx>
 <2023100547-retool-chamomile-d581@gregkh>
 <51b6606a-fdc1-de11-2260-863ac08071fd@amd.com>
 <2023100531-stick-cupped-78f6@gregkh>
From:   "Gupta, Nipun" <nipun.gupta@amd.com>
In-Reply-To: <2023100531-stick-cupped-78f6@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzQvTTJUUXRhcU5vMm5MM0RkVlM0V2grQ3Rnc1JyeWdWcnloYzBsSVpWdEdG?=
 =?utf-8?B?T1JXSjlhenYrd0ZVRkdHUnMyaWFKaE4ySUw1TUlUeDMvTWEvOHphUUpOeGJ5?=
 =?utf-8?B?R2Jyekw0bXNSMm00d0VQMEFGdW5oaUl2Yk9TbGFxSGtYVlRjRm1HNXJ5NHBv?=
 =?utf-8?B?ZHNnejc4YkVqRHBqRUsyNEV6ZVoxMWZrditDb1o3WnJFL0haM1pnUFJIZHUx?=
 =?utf-8?B?Wm1adXJVdjlrejNDZmVyQ3hWRkd4Tmx0bEVOV1FNdlZCNFVZZU8yeHI3a2p6?=
 =?utf-8?B?QTNiMmhyN2IrQzhsaVRyN2hhYUNxc2ZhQ251STd4dFRIQk9qUHdhd3pqdCt3?=
 =?utf-8?B?S3cwWjIvUFJoOTBaYmtNZVVqL21wSjBwTVVwSGFRaTA4c0hJZ3ZTOXY2YXc0?=
 =?utf-8?B?ajNhRU9kcE5mRnhHOXJwb1ZBb2JaUzJab0tiU2NkSmFxRzZreHRnL1RIT2FI?=
 =?utf-8?B?VzB4cHZ5dTN0TjBndWF0akwxMUF1Rjl2d0JsellyZFdoWHRMdG92Z0ZRdVhD?=
 =?utf-8?B?SVZNUm9LekcxcDdmZXdQSFJKeWpGNmpJTUh2TUVlNmVDdTdWaVBWaUwyZkVH?=
 =?utf-8?B?V1JGN0U2bWR3MEtVNjhBU0lmRWluc1RCRGNPTVhLQ3hhVUMybG93NG1xU2Ru?=
 =?utf-8?B?UWNmdG5aeXE5Y1ZNc2RZN1A5OVJ6RnV1dSthMDRWNEk4YmJscDBaL0ZKbS9S?=
 =?utf-8?B?MEcyajUzNU9qcGNkblNhd0VncTlMVEJNWGpjUzlvU25jaGJNQW1LSDhkVi9u?=
 =?utf-8?B?anBxOExYd095Y04wM1pSSmwranM2dHVCZjlyR3N3NGtobHN6T2RhdXdDQXZT?=
 =?utf-8?B?elFBMjJuYTc1ck1Tb0psYnRrcXNlS3NVNHMzRDhYNDZiTnJxeURpM0plTDlx?=
 =?utf-8?B?Z3RlYTkxem4zRUtVanVkVUpYM0p2UmpJUVAvTTJZcDlMTGsxQ3RteVVuYTlC?=
 =?utf-8?B?TThCNVp4U2wrZ2Y1cE9MODhJOG85U3R5aXcyT2dLSkF5dnZmTWI0Nk5hNDBz?=
 =?utf-8?B?WWd0VXNvOXpyTnFyTWRSQXFLRHBJeGxHdFp4T0hHWkVWSEhTWStnNThlQ2dn?=
 =?utf-8?B?MlAvamcrTUxhb0s3VExnWjYxQ3ZRakNJekxwdldpaHRXV3crcFFkU09GR2Iv?=
 =?utf-8?B?aGkrTHNyRzd2eXkzVFJwZkovamRDUkh1RDRCSHlRcU5XRGF1aittMVZ4a3Fm?=
 =?utf-8?B?R1lLTmpkejZ4eHkzMW9PaFRERVNOeEpiNWdhSnQ4ZjVmYVdHS2p4dXcwbVBI?=
 =?utf-8?B?a1FGblJ4OG1OSmtIVUhsZ1VUTGR3MUlMU1ZZVVFsblVhNlBROUVHd21uTFAw?=
 =?utf-8?B?L3g3ZnJRZnRyYjlLSHEzSTdPL2xoWlM4RXNjS2FKdmVrdkN4akVUOEZ5KzBj?=
 =?utf-8?B?c1BYL1hrc2JQZW9BZDdxeUNWODhUa043Y3Vod1pPLzdhbEIxNjUrSER6a1cv?=
 =?utf-8?B?WmMySFovMTlSZGNCeW04Ky81QlNmWkM2VDNtYlV1R0Q0MXlKM3U0WC9NVzNH?=
 =?utf-8?B?Z1lORElNREZCeXJwRjVuam1vSVNRd2oza2RidlVjQWpvSkVwNXI0aTNnTjJn?=
 =?utf-8?B?RUdOVGRDVUxrZzVqUFdQam1kZUtqZ3JCU3VidXBtQlZRU2FtTUVGa0dnYXZq?=
 =?utf-8?B?V0ZyRVlFSU9VWDJ0NFpBTjZXTXJDeWMzalViVS9Hd20vK3ZCSXFJaGtzRmRq?=
 =?utf-8?B?cVNMNXRFZk8xcWRKc1FsbmRwUmFSSDliMCtrMC9xVUN1aTZLZXZzN1YwdHRp?=
 =?utf-8?B?NVN0eG9JOEkxWEVMU0hlOHo4VGxKNy9xcjFsQ2ZaWURYNFFZSWJPOFJzVk0z?=
 =?utf-8?B?YTVCUTNtR0Y2cnVXaFJzOWNpVXpMQkMxQnM4ZVFtRDdTMFpWMFpJcUh5ZTM5?=
 =?utf-8?B?R1dwUWFVdjJaVFVEOExxc3Bhd1ZqV0p4ZkVHOGJ4TXVnRnkyTllRa1Z4VE5N?=
 =?utf-8?B?K3JQVTEwcFBNMVprZVlKbkh5WXk5bm5tbzh3cXZvYVVWb2pDejk2RXZmUnM3?=
 =?utf-8?B?TUNqOG5UZHdnZmw0VDczcktWdTFNUytWaVJydFNqNk1Ld3gzZXhuaWN2aDRY?=
 =?utf-8?B?R1NHanVrYkFSRmU0bXp6T0xGemJPU3NnVnJWM085bHloRG9OZWVLY2IwRm13?=
 =?utf-8?Q?EMjmhVyn17HtRIcHhI0fu14vJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21fa99ce-c2f4-4aee-de9b-08dbc5b48be8
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 15:05:43.8686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 69quzlWIze5EjIKWkjrF6YXedeQRC4rG8heNN1ubU63tS6HxqKTMvWgnE57OrX/+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9094
X-Spam-Status: No, score=-5.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 05 Oct 2023 08:49:07 -0700 (PDT)


On 10/5/2023 8:24 PM, Greg KH wrote:
> On Thu, Oct 05, 2023 at 08:07:35PM +0530, Gupta, Nipun wrote:
>> Hi Greg,
>>
>> On 10/5/2023 7:30 PM, Greg KH wrote:
>>> On Thu, Oct 05, 2023 at 03:46:34PM +0200, Thomas Gleixner wrote:
>>>> On Thu, Oct 05 2023 at 12:24, Greg KH wrote:
>>>>>> diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
>>>>>> index a08958485e31..86df7ccb76bb 100644
>>>>>> --- a/drivers/cdx/Kconfig
>>>>>> +++ b/drivers/cdx/Kconfig
>>>>>> @@ -8,6 +8,7 @@
>>>>>>    config CDX_BUS
>>>>>>    	bool "CDX Bus driver"
>>>>>>    	depends on OF && ARM64
>>>>>> +	select GENERIC_MSI_IRQ_DOMAIN
>>>>>
>>>>> This config option isn't in my tree anywhere, where did it come from?
>>>>> What is it supposed to do?
>>>>
>>>> 13e7accb81d6 ("genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN") :)
>>>
>>> Ok, so this hasn't been tested since the 6.2 release?  Wow, I think
>>> someone from AMD needs to take a deep look at this and verify that it
>>> actually is doing what it is supposed to be doing...
>>
>> The patch Thomas mentioned renames "GENERIC_MSI_IRQ_DOMAIN" to
>> "GENERIC_MSI_IRQ"; and in our testing "GENERIC_MSI_IRQ" is also selected as
>> 'ARM64' is enabled which enables 'ARM_GIC_V3_ITS' which in-turn selects
>> 'GENERIC_MSI_IRQ'.
> 
> Ok, but that's not what this patch "selects" at all :(

"GENERIC_MSI_IRQ" gets enabled because of enabling "ARM64", and you are 
right that what we are selecting here does not have any meaning now 
(after 6.2).

> 
>> The patch is tested for MSI functionality on 6.6-rc1. We will re-look into
>> the config dependencies to avoid such issues, but please be assured that the
>> patch has been validated.
> 
> How has the dependancy been validated as correct if there is no such
> thing in this kernel?

Apology for the confusion. By validated I meant tested for MSI 
functionality in CDX. Agree that "select GENERIC_MSI_IRQ_DOMAIN" needs 
to be fixed here. Will update in next spin. :)

Thanks,
Nipun

> 
> confused,
> 
> greg k-h