Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <CAOQ4uxhbNyDzf0_fFh1Yy5Kz2Coz=gTrfOtsmteE0=ncibBnpw@mail.gmail.com>
 <0000000000001081fc0606f52ed9@google.com> <CAOQ4uxjw_XztGxrhR9LWtz_SszdURkM+Add2q8A9BAt0z901kA@mail.gmail.com>
 <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com>
In-Reply-To: <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Thu, 5 Oct 2023 16:22:20 +0300
Message-ID: <CAOQ4uxgfJ4owqzh99t65MyT5A99BbwkLQ-sHumCUWyqSw-Rd5g@mail.gmail.com>
Subject: Re: [syzbot] [integrity] [overlayfs] possible deadlock in
 mnt_want_write (2)
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     syzbot <syzbot+b42fe626038981fb7bfa@syzkaller.appspotmail.com>,
        hdanton@sina.com, linux-fsdevel@vger.kernel.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-unionfs@vger.kernel.org,
        miklos@szeredi.hu, mszeredi@redhat.com,
        syzbot@syzkalhler.appspotmail.com, syzkaller-bugs@googlegroups.com,
        viro@zeniv.linux.org.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 4:14=E2=80=AFPM Mimi Zohar <zohar@linux.ibm.com> wro=
te:
>
> On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote:
> > On Thu, Oct 5, 2023 at 12:59=E2=80=AFPM syzbot
> > <syzbot+b42fe626038981fb7bfa@syzkaller.appspotmail.com> wrote:
> > >
> > > Hello,
> > >
> > > syzbot tried to test the proposed patch but the build/boot failed:
> >
> > My mistake. Please try again:
> >
> > #syz test: https://github.com/amir73il/linux ima-ovl-fix
>
> Thanks, Amir.   "mutext_init(&iint->mutex); moved, but the status
> initialization lines 161-166 were dropped.   They're needed by IMA-
> appraisal for signature verification.
>
>         iint->ima_file_status =3D INTEGRITY_UNKNOWN;
>         iint->ima_mmap_status =3D INTEGRITY_UNKNOWN;
>         iint->ima_bprm_status =3D INTEGRITY_UNKNOWN;
>         iint->ima_read_status =3D INTEGRITY_UNKNOWN;
>         iint->ima_creds_status =3D INTEGRITY_UNKNOWN;
>         iint->evm_status =3D INTEGRITY_UNKNOWN;
>

They are dropped from iint_init_once()
They are not needed there because there are now set
in every iint allocation in iint_init_always()
instead of being set in iint_free()

This is the standard practice for slab objects.
See inode_init_once()/inode_init_always().

Thanks,
Amir.