Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <d5589d2f-013d-4946-9e5c-051c587c2e8b@ti.com>
Date:   Thu, 5 Oct 2023 18:01:50 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 2/7] arm64: dts: ti: k3-j784s4: Add ESM instances
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>, <robh+dt@kernel.org>,
        <conor+dt@kernel.org>, <kristo@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <u-kumar1@ti.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230927023357.9883-1-j-keerthy@ti.com>
 <20230927023357.9883-3-j-keerthy@ti.com>
 <4eb50f24-b6c8-790e-91b0-5646ebbb2d10@ti.com>
 <c7c32ec5-d0c1-443d-9851-3bb8e772c8fc@ti.com>
 <20231005111554.ol4vu4oxlensmx6m@booth>
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <20231005111554.ol4vu4oxlensmx6m@booth>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/5/2023 4:45 PM, Nishanth Menon wrote:
> On 06:45-20231005, J, KEERTHY wrote:
>>
>>
>> On 10/3/2023 12:20 PM, Vignesh Raghavendra wrote:
>>>
>>>
>>> On 27/09/23 08:03, Keerthy wrote:
>>>> Patch adds the ESM instances for j784s4. It has 3 instances.
>>>> One in the main domain and two in the mcu-wakeup domian.
>>>>
>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>> ---
>>>>    arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi       |  8 ++++++++
>>>>    arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 14 ++++++++++++++
>>>>    2 files changed, 22 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>>>> index efed2d683f63..26dc3776f911 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>>>> @@ -1568,4 +1568,12 @@
>>>>    		firmware-name = "j784s4-c71_3-fw";
>>>>    		status = "disabled";
>>>>    	};
>>>> +
>>>> +	main_esm: esm@700000 {
>>>> +		compatible = "ti,j721e-esm";
>>>> +		reg = <0x00 0x700000 0x00 0x1000>;
>>>> +		ti,esm-pins = <688>, <689>, <690>, <691>, <692>, <693>, <694>,
>>>> +			      <695>;
>>>> +		bootph-pre-ram;
>>>
>>> Similar to other nodes in this file, here and elsewhere use
>>> 		bootph-all
>>
>> Okay. I will switch to bootph-all
> 
> Is'nt esm configuration just needed during pre-ram?

This is needed only the R5 SPL phase. So bootph-pre-ram looks better suited.

https://u-boot.readthedocs.io/en/latest/develop/driver-model/of-plat.html

Vignesh,

This ESM nodes should be bootph-pre-ram. I will keep that flag as is.

Best Regards,
Keerthy
> 
>>
>>>
>>>
>>>> +	};
>>>>    };
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>>>> index 4ab4018d3695..a7b5c4cb7d3e 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>>>> @@ -700,4 +700,18 @@
>>>>    			status = "disabled";
>>>>    		};
>>>>    	};
>>>> +
>>>> +	mcu_esm: esm@40800000 {
>>>> +		compatible = "ti,j721e-esm";
>>>> +		reg = <0x00 0x40800000 0x00 0x1000>;
>>>> +		ti,esm-pins = <95>;
>>>> +		bootph-pre-ram;
>>>> +	};
>>>> +
>>>> +	wkup_esm: esm@42080000 {
>>>> +		compatible = "ti,j721e-esm";
>>>> +		reg = <0x00 0x42080000 0x00 0x1000>;
>>>> +		ti,esm-pins = <63>;
>>>> +		bootph-pre-ram;
>>>> +	};
>>>>    };
>>>
>