Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp399818rdb; Thu, 5 Oct 2023 09:03:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3aVc5Xi8fkcv6RqxZyP54ak5rtOzA1ZWRbcQBcyzjejykupQH6RRw1yDa4Iy8kQLBkTRk X-Received: by 2002:a05:6a21:62a:b0:164:e94b:d3ae with SMTP id ll42-20020a056a21062a00b00164e94bd3aemr5197014pzb.54.1696521783003; Thu, 05 Oct 2023 09:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696521782; cv=none; d=google.com; s=arc-20160816; b=ZHWNXYG2GxTonXk6iTT59aeDXMXA02QEYwtTDhT9+SETmDW9DqVjLfxfe72nb/dFUu zLlLiUmqVybGbu8q4tsN1EcybkAcVRobdseF3lahr0W+q31jY4nu/rckFJA1XqRFaM5j QTQE3ir1JxM6MYVtCVJkH+4mtxp99vgCilshJaf2u/vqKEpBHjtUE2ACaJfEJ1/Sxfbh bWz8MJXwEtcJqUYdC8ma628gMuSVZ6fFlShcSk5LNRy2YAWt2276wmwH6HJheTnOfkfm 9ujUUInoX0mfTM2f3P6YFKWLkDMQwVazyFCBxFTqzEZ/xWunzNg1kXGd7evwFW9zdC0U a7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=R7cbZEGmJy2Gw2vxwUa3TW2M1e1bape91R+3bvKvVu0=; fh=q9phKnmDuoiNTcKqaueL/LMmNLyDtaXNqRh9pScjHPw=; b=w9j0VGMThpsm3BCQ38AkLb/UgiD+RI7XJ2KSjpJoPwBXrARWLe8ILIO6aSKtVvo8IN kUIAsivvlVpvW5sQd5uyn9vmCvPEf4wsjm/BDOfeX2uwdoHXvKfst3vQYhm+2jFILOWT KSkZqLZsiKtJ/Kw/CZvBVmTR/+uL7SswwqlizGsD2ZyrO4/RDPDZ+54G9eNq6hlLiN0M BLQqUzO8DYSKyFQm1WBNKEXkmDjp5M+tzA2kMmlUwtEcZFvsRdD2bnp6BjOkUsiboPyI oKAuaO9QJw8cqOHeSiuvii1SqbGW7PeJTqu3HYBpIW5bXKWRHZSLK0SkA84JtrFhK3AZ Kt5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b="O34P3A/o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id k70-20020a633d49000000b00578cc82870asi1599571pga.344.2023.10.05.09.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:03:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b="O34P3A/o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 6D12A85C6456; Thu, 5 Oct 2023 09:02:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234423AbjJEQCq (ORCPT + 99 others); Thu, 5 Oct 2023 12:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237493AbjJEQA6 (ORCPT ); Thu, 5 Oct 2023 12:00:58 -0400 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17982469E; Thu, 5 Oct 2023 06:52:04 -0700 (PDT) Received: from [192.168.68.112] (ppp118-210-84-62.adl-adc-lon-bras32.tpg.internode.on.net [118.210.84.62]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 5D962200DB; Thu, 5 Oct 2023 11:14:56 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1696475698; bh=R7cbZEGmJy2Gw2vxwUa3TW2M1e1bape91R+3bvKvVu0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=O34P3A/oGQNwIozMFMzAjDAioU17wp3c9h1nOMZ7RV8TgQXElvFBqhe4Bsbl8fE3x gQJHr4JcMw0cY+ZWvzT4kdJUNrBlJY268m03OdYVbLkUGQxAsG2UsnZSHZkVBfy/ud Ijx6ZjbiaRGBK5PJQOHlqpK/zAbkif3zrnpSQ4DHsBw/vEdgEDH2Dkffu3UU5j4eKu MRDmWH4T+LbN/9/q9UkU98aF7+68IUsY6WlrKbKEy7JE2euX6wE7QhXOhK9C7SBe/D dFxN+kL91aUD6hgp+qRN2ZtZi7wnw91jBnLcYB5RQCJFiBsHw/M9m/+6dufL4msv8U Iljyq3ilKd4/g== Message-ID: <3bf55144b8169a8f44c67e9a6b63cc67a2edfa50.camel@codeconstruct.com.au> Subject: Re: [PATCH v2] pinctrl: aspeed: Allow changing SPI mode from hardware strap defaults From: Andrew Jeffery To: Zev Weiss , Linus Walleij , Joel Stanley , linux-aspeed@lists.ozlabs.org Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 05 Oct 2023 13:44:54 +1030 In-Reply-To: <20231005030849.11352-2-zev@bewilderbeest.net> References: <20231005030849.11352-2-zev@bewilderbeest.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:02:58 -0700 (PDT) On Wed, 2023-10-04 at 20:08 -0700, Zev Weiss wrote: > Some platforms unfortunately have their SPI mode selection bits > strapped incorrectly (such as being configured for passthrough mode > when master mode is in fact the only useful configuration for it) and > thus require correction in software. Add the SPI mode bits to the > GPIO passthrough bits as the exceptions to the read-only rule for the > hardware strap register so that the pinctrl subsystem can be used for > such corrections. >=20 > Signed-off-by: Zev Weiss Reviewed-by: Andrew Jeffery Thanks!