Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 5 Oct 2023 18:37:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Andi Shyti <andi.shyti@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Al Cooper <alcooperx@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 1/1] serial: 8250_bcm7271: Use
 devm_clk_get_optional_enabled()
Message-ID: <ZR7YLI3t2YDBbNbK@smile.fi.intel.com>
References: <20231005124550.3607234-1-andriy.shevchenko@linux.intel.com>
 <ZR7UCtRKrycMD5d5@ashyti-mobl2.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZR7UCtRKrycMD5d5@ashyti-mobl2.lan>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Oct 05, 2023 at 05:19:38PM +0200, Andi Shyti wrote:

[...]

> > -	baud_mux_clk = devm_clk_get(dev, "sw_baud");
> > -	if (IS_ERR(baud_mux_clk)) {
> > -		if (PTR_ERR(baud_mux_clk) == -EPROBE_DEFER) {
> > -			ret = -EPROBE_DEFER;
> > -			goto release_dma;
> > -		}
> > -		dev_dbg(dev, "BAUD MUX clock not specified\n");
> > -	} else {
> > +	baud_mux_clk = devm_clk_get_optional_enabled(dev, "sw_baud");
> > +	ret = PTR_ERR_OR_ZERO(baud_mux_clk);
> > +	if (ret)
> > +		goto release_dma;
> > +	if (baud_mux_clk) {
> >  		dev_dbg(dev, "BAUD MUX clock found\n");
> > -		ret = clk_prepare_enable(baud_mux_clk);
> > -		if (ret)
> > -			goto release_dma;
> > +
> >  		priv->baud_mux_clk = baud_mux_clk;
> >  		init_real_clk_rates(dev, priv);
> >  		clk_rate = priv->default_mux_rate;
> > +	} else {
> > +		dev_dbg(dev, "BAUD MUX clock not specified\n");
> 
> little behavioral change here, but I don't think this is a
> problem.

You meant that "if (!x) else" had been changed to "if (x) else" semantics?
Otherwise I don't see any difference.

> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thank you!

-- 
With Best Regards,
Andy Shevchenko