Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp410455rdb; Thu, 5 Oct 2023 09:17:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG63dl+xB9XC8Dr54KmtCP8KJ+K0/njoi3folDNekRMJObJeDwCnXSnCh9vNbP24dlfNoaY X-Received: by 2002:a05:6a20:549e:b0:161:28e0:9abd with SMTP id i30-20020a056a20549e00b0016128e09abdmr6935453pzk.16.1696522677423; Thu, 05 Oct 2023 09:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696522677; cv=none; d=google.com; s=arc-20160816; b=LokeeGARXH9r4d6eJ98EkI+KKSUdSmOk2jjfMyc2BafyUq0ioBA+0JemkeU/pXrd0Q NUuVUMvZD3ZZ9s46gSCxgLLhBRFyNyxcwPT/kis1puJtnxIU4wpmPjzh+/GPOsy4OhnM 25+SgciDEYcVIbGIkG8hPVDGsZtrHLPpfYfIRM18H2ej3PAU2NOn+gaJbFyPSOz0DOy4 dOApnf5vpuID+QhgMGoYrHWK2QugEZVLAUFfeEI7NAaPz00OKf8tWXsOzCYUoZxzVx3R pSFiZMFKKcEE6iW2lyjBuq6fh+TSNWflECSd/CbO+G1aDG323yqxhvlsHkmuC/rC+q24 pY6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Qu3ikpZcZcQIrn49+VsurRlhYTXJ5g7r1cpeFUW0h/o=; fh=JIVmSDfMuoMXVLwapn+mIohm74bpPhn+87pdcNQAmes=; b=g5dwOQq5vAlWi3JMKSv6B8vSEWajQcYhkpo7uNT6S5cAXlZW91slJc2bZt1kNH7LyB 0AVKibqf24zNPk+a7HVB24yQruIVBoC/Gnj9v1XtJ9B0tY+db3lIa5yUVfX3nzup130W K/PLocZy0v2nU+b5n9KqrDaOmhoTn1JAUNsyWLNMvAiCpc2WXMzMWualmN3ReUzd5KRa sdF6s5st+7O0vEvM6sATSeyoBqN/oTzaDB2XGpLxo8RpuG6RSpI+DTnUkBrZmXnxh4Ic FJ02NKmVWN8XkF4XcMfWFjNYJLuwMSPHUWWx5GOdAGjkR82xGUc+mE1Qb5WwBgLcc8MZ 8HNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id g8-20020a056a001a0800b00690fb3c5cecsi1779607pfv.16.2023.10.05.09.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id B4FAC83CDFD6; Thu, 5 Oct 2023 09:17:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241089AbjJEQNj (ORCPT + 99 others); Thu, 5 Oct 2023 12:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240864AbjJEQMR (ORCPT ); Thu, 5 Oct 2023 12:12:17 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A1DB2A2; Thu, 5 Oct 2023 08:30:37 -0700 (PDT) Received: from i53875a3c.versanet.de ([83.135.90.60] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qoQJ3-0006a1-Rc; Thu, 05 Oct 2023 17:30:29 +0200 From: Heiko Stuebner To: Benjamin Gaignard , Sebastian Reichel Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node Date: Thu, 05 Oct 2023 17:30:29 +0200 Message-ID: <2298521.ElGaqSPkdT@phil> In-Reply-To: <20231005151210.nqdx2uoixqjhrtrx@mercury.elektranox.org> References: <20231005145420.169594-1-benjamin.gaignard@collabora.com> <20231005151210.nqdx2uoixqjhrtrx@mercury.elektranox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:17:18 -0700 (PDT) Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel: > Hi, > > On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote: > > Add node for AV1 video decoder. > > > > Signed-off-by: Benjamin Gaignard > > Signed-off-by: Sebastian Reichel > > No need for my SoB. Instead have this one: > > Reviewed-by: Sebastian Reichel > > Also worth mentioning, that this Patch needs one small fix in the DT > binding (adding "resets") and one small fix in the driver for out of > the box AV1 support: > > https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/ > https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/ additionally the node name should be generic. The phandle can of course be av1d but the node name itself needs a change. Heiko > > --- > > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > index 5544f66c6ff4..835e66d85d5f 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > @@ -2304,6 +2304,20 @@ gpio4: gpio@fec50000 { > > #interrupt-cells = <2>; > > }; > > }; > > + > > + av1d: av1d@fdc70000 { > > + compatible = "rockchip,rk3588-av1-vpu"; > > + reg = <0x0 0xfdc70000 0x0 0x800>; > > + interrupts = ; > > + interrupt-names = "vdpu"; > > + clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>; > > + clock-names = "aclk", "hclk"; > > + assigned-clocks = <&cru ACLK_AV1>, <&cru PCLK_AV1>; > > + assigned-clock-rates = <400000000>, <400000000>; > > + resets = <&cru SRST_A_AV1>, <&cru SRST_P_AV1>, <&cru SRST_A_AV1_BIU>, <&cru SRST_P_AV1_BIU>; > > + power-domains = <&power RK3588_PD_AV1>; > > + status = "okay"; > > + }; > > }; > > > > #include "rk3588s-pinctrl.dtsi" >