Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231004185732.98621-1-brgl@bgdev.pl> <25ba48de-2ab6-4a4e-a290-891398710931@gmail.com>
In-Reply-To: <25ba48de-2ab6-4a4e-a290-891398710931@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Thu, 5 Oct 2023 08:44:31 +0200
Message-ID: <CAMRc=McHD7F1vdy7Pe0ORBU23fKFs4iKgN8zzD9ezxTSebFihw@mail.gmail.com>
Subject: Re: [PATCH] firmware: qcom: qseecom: add missing include guards
To:     Maximilian Luz <luzmaximilian@gmail.com>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 4, 2023 at 9:10=E2=80=AFPM Maximilian Luz <luzmaximilian@gmail.=
com> wrote:
>
> On 10/4/23 20:57, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > The qseecom header does not contain ifdef guards against multiple
> > inclusion. Add them.
> >
> > Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secu=
re Execution Environment SCM interface")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Oh, thanks for spotting and fixing that.
>
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
>
> PS: I haven't forgotten about your SHM Bridge patches. Testing those is
> now next up on my kernel TODO list. Unfortunately, it might take a
> couple more days until I can get around to do it properly.

Thanks, you may as well wait for v3 as it'll be reworked significantly
again due to some new information I got.

Bart

>
> > ---
> >   include/linux/firmware/qcom/qcom_qseecom.h | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/firmware/qcom/qcom_qseecom.h b/include/linux=
/firmware/qcom/qcom_qseecom.h
> > index b531547e1dc9..5c28298a98be 100644
> > --- a/include/linux/firmware/qcom/qcom_qseecom.h
> > +++ b/include/linux/firmware/qcom/qcom_qseecom.h
> > @@ -5,6 +5,10 @@
> >    *
> >    * Copyright (C) 2023 Maximilian Luz <luzmaximilian@gmail.com>
> >    */
> > +
> > +#ifndef __QCOM_QSEECOM_H
> > +#define __QCOM_QSEECOM_H
> > +
> >   #include <linux/auxiliary_bus.h>
> >   #include <linux/types.h>
> >
> > @@ -44,3 +48,5 @@ static inline int qcom_qseecom_app_send(struct qseeco=
m_client *client, void *req
> >   {
> >       return qcom_scm_qseecom_app_send(client->app_id, req, req_size, r=
sp, rsp_size);
> >   }
> > +
> > +#endif /* __QCOM_QSEECOM_H */