Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp411201rdb; Thu, 5 Oct 2023 09:19:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFM5Pwlc7obNiaJhEiiQieNkvPd6bHvP9POGa6WzA0Olutu4hnBkOkuNpNG5sfnUNMf/8GB X-Received: by 2002:a05:6a21:a101:b0:162:6588:7174 with SMTP id aq1-20020a056a21a10100b0016265887174mr4975672pzc.28.1696522748509; Thu, 05 Oct 2023 09:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696522748; cv=none; d=google.com; s=arc-20160816; b=CnQVMOLq6mkPyUS7mMtLq6mgyFTwYp6wObx3CFTGVF+QO4oOUe8JJ4DglDIbSTt8yt tyUsAOHrhV9ibLGuc8yrwqEQx3nYbixso3E2td3wQslb30K8eS4ToY0SDqsgqG6TZTdH Q9cKRganvdSQhgS2x/gVLrs8uEr2Zky0PwcdqbGD1KczV/PeyUZ8oEKBp6yCnv659DDj Ke+nRGHgTb1P1R1LylTeBuWe5eQc3OlZauGGJvUefVlWaLVNFND9/DP49/91cqO0gG6m iEgqa8qomFNbJtSvdvGgYl4uU1DXoUlKkNJ/AYLPrnisN3HpDaCyHCSlzgHOoAKRRRYe IVFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HCYFX8DqNzwL6GYU1rfcPUGS3N4C41iYiCIn75uvSfk=; fh=dkBLa/ibfmYHtTwkALUkhwIq4mgYo+1rRiae/ydcixY=; b=Nzipxoo2QW7TA5pjsNK8DhdMhmFL18i2wUMPzuTMn3NqBd23yE8d/5pG1g1tjg+kQ5 tZk8oiIgn5n0tfO3+woNKMGNMLJ4zyQc+BdjN9ecFk3X6dAu0A2o6niNa7gInc+3b9gZ OvasipBJIaBoP74K7X75UqmDJ/NARdo5xdbvN61pVAtTvLhf0V59RZ+Qs1kekSdVGZ+3 Ash3efoHvhCqAgtq9xWswDwnYTgVhx74PGk4ZLoq0nrYzMuBPq3WcC6OtSedisMe8bpK Kmzw3T7JWCHxgV/g5sUZG8vDCzcY/lRTDUlnXbD6LYaPgy2GNK06ntFMH5V75zMfV5sL r5iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=kGfxNzOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id e2-20020a636902000000b00585a45417absi1668830pgc.267.2023.10.05.09.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:19:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=kGfxNzOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 56B19823CC53; Thu, 5 Oct 2023 09:19:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242661AbjJEQSg (ORCPT + 99 others); Thu, 5 Oct 2023 12:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241473AbjJEQO2 (ORCPT ); Thu, 5 Oct 2023 12:14:28 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCD965BD for ; Wed, 4 Oct 2023 23:22:16 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40572aeb73cso5083235e9.3 for ; Wed, 04 Oct 2023 23:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696486934; x=1697091734; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HCYFX8DqNzwL6GYU1rfcPUGS3N4C41iYiCIn75uvSfk=; b=kGfxNzObiXR1w/Cwpgnle0zcPHoGCpDi4NX+CI7b44fx4wLbaSk9zxWhWBXVHAkPdv /OLw+DA/dGUp/pmcUf4HOyN8u9XkR2W+f4w0OeKaSVwAo9eOh91nuaGk8TGr0cnU9T3A rX028sPlHtvtYsr2pxS0jwhREQHvR8zKPw8UZdcwb13wbNOVrYc3JeSUo57a+cimnrk1 u+pu4vLgO9Z+e50S3EBBp/NLi/rGQkvk/vUEyivsUIZ6+mQnGkV+kLpwrlWm5Y2bxfpN e2tGXrA79Ct3rokDryeq1SpQ7nee8PA2qPsoIsAanLpSwZPM8k4VmhhIusxutNEa4E02 oWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696486934; x=1697091734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HCYFX8DqNzwL6GYU1rfcPUGS3N4C41iYiCIn75uvSfk=; b=s9UwFKdZOZDnIf/crdLf+PR6WSiph70KJMmfOd/Abb59VNfOKZAtIQN0/tSsb8sPA2 D8I7BbDaueG/pJ4mLpEhEgBxVH3cavrHZQ/XhQosSfN0eATeA3rFEhWjHSNWCzkIOANT In+7X10mc7eRJJ266MBZwg5QpcrqkWlHA5MP8hTsJDkE1faYUXtjhi/ov6pwFABl/PCy 29e7B9TSdcVmwNidKIIrYns52qESS2yCTjqsVg4JH9WRjw2jJEW422Q3V3wvCE+LBeA/ Qta26V6w+terB5g3YjxeQ4Yd6UQRKzocNOjYFWk9Ujc0xvCPLaxH5ChkDsyUEdHnRn2J W+6A== X-Gm-Message-State: AOJu0YzSf/3zQ/XiWzrpMMH9gjj9tLEjveDOf1viex/wgAVGvs3B2y0T xdOVretS474hvD3IeC9YYJlkSw== X-Received: by 2002:a1c:6a0d:0:b0:3fc:1a6:7764 with SMTP id f13-20020a1c6a0d000000b003fc01a67764mr4004459wmc.16.1696486934337; Wed, 04 Oct 2023 23:22:14 -0700 (PDT) Received: from blmsp ([2001:4091:a246:8222:dbda:9cd9:39cc:f174]) by smtp.gmail.com with ESMTPSA id k22-20020a7bc416000000b00404719b05b5sm744928wmi.27.2023.10.04.23.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 23:22:13 -0700 (PDT) Date: Thu, 5 Oct 2023 08:22:12 +0200 From: Markus Schneider-Pargmann To: Ulf Hansson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Alexandre Mergnat , Chun-Jie Chen , AngeloGioacchino Del Regno , Tinghan Shen , Fabien Parent , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v8 0/8] soc: mediatek: MT8365 power support Message-ID: <20231005062212.dpkscqq27exdnssm@blmsp> References: <20230918093751.1188668-1-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:19:07 -0700 (PDT) Hi, On Thu, Oct 05, 2023 at 12:09:06AM +0200, Ulf Hansson wrote: > On Mon, 18 Sept 2023 at 11:38, Markus Schneider-Pargmann > wrote: > > > > Hi, > > > > no real changes in this update. Rebase to v6.6-rc2 and according change > > of directory. > > > > Thanks for any feedback! > > > > Best, > > Markus > > > > Based on v6.6-rc2 > > > > Changes in v8: > > - Rebased to v6.6-rc2 > > - Moved changes from drivers/soc to drivers/pmdomain > > > > Changes in v7: > > - Rebased to v6.5-rc1 > > - Fixed a couple of small style issues pointed out by Angelo > > > > Changes in v6: > > - Change flags field to be u8 instead of u32 > > - Use macro concatenation to simplify BUS_PROT macros: > > BUS_PROT_WR(_hwip, ...) etc. > > - Use the final bit values for scpsys_bus_prot_flags from the beginning > > of the series. > > - Changed scpsys_domain_data->caps to be u16 to accommodate the new flag > > MTK_SCPD_STRICT_BUS_PROTECTION. > > > > Changes in v5: > > - Create defines for all registers and bits in mt8365 power domain patch > > - Redesign scpsys_bus_prot_data to use flags to store reg_update, > > clr_ack as well as the difference between SMI and INFRACFG. The code > > uses the appropriate regmap depending on the flags. > > - The WAY_EN patch now uses two flags, one for inverted operations > > 'BUS_PROT_INVERTED' and one to use infracfg-nao for the status flags > > 'BUS_PROT_STA_COMPONENT_INFRA_NAO'. > > > > Changes in v4: > > - Redesigned WAY_EN patch and split it up in smaller patches. > > - Added two documentation patches. > > - Added mediatek,infracfg-nao field to the binding. > > > > Changes in v3: > > - Mainly redesigned WAY_EN patch to be easier to understand > > - Rebased onto v6.0-rc1 > > - Several other stuff that is described in the individual patches > > > > Changes in v2: > > - Updated error handling path for scpsys_power_on() > > - Minor updates described in each patch > > > > Previous versions: > > v1 - https://lore.kernel.org/linux-mediatek/20220530204214.913251-1-fparent@baylibre.com/ > > v2 - https://lore.kernel.org/linux-mediatek/20220725081853.1636444-1-msp@baylibre.com/ > > v3 - https://lore.kernel.org/linux-mediatek/20220822144303.3438467-1-msp@baylibre.com/ > > v4 - https://lore.kernel.org/linux-arm-kernel/20230105170735.1637416-1-msp@baylibre.com/ > > v5 - https://lore.kernel.org/linux-arm-kernel/20230619085344.2885311-1-msp@baylibre.com/ > > v6 - https://lore.kernel.org/linux-arm-kernel/20230627131040.3418538-1-msp@baylibre.com/ > > v7 - https://lore.kernel.org/linux-arm-kernel/20230713150414.891893-1-msp@baylibre.com > > > > Alexandre Bailon (2): > > soc: mediatek: Add support for WAY_EN operations > > soc: mediatek: Add support for MTK_SCPD_STRICT_BUS_PROTECTION cap > > > > Fabien Parent (2): > > dt-bindings: power: Add MT8365 power domains > > soc: mediatek: pm-domains: Add support for MT8365 > > > > Markus Schneider-Pargmann (4): > > soc: mediatek: pm-domains: Move bools to a flags field > > soc: mediatek: pm-domains: Split bus_prot_mask > > soc: mediatek: pm-domains: Create bus protection operation functions > > soc: mediatek: pm-domains: Unify configuration for infracfg and smi > > > > .../power/mediatek,power-controller.yaml | 6 + > > drivers/pmdomain/mediatek/mt6795-pm-domains.h | 16 +- > > drivers/pmdomain/mediatek/mt8167-pm-domains.h | 20 +- > > drivers/pmdomain/mediatek/mt8173-pm-domains.h | 16 +- > > drivers/pmdomain/mediatek/mt8183-pm-domains.h | 125 ++++++---- > > drivers/pmdomain/mediatek/mt8186-pm-domains.h | 236 ++++++++++-------- > > drivers/pmdomain/mediatek/mt8188-pm-domains.h | 223 +++++++++++------ > > drivers/pmdomain/mediatek/mt8192-pm-domains.h | 112 ++++++--- > > drivers/pmdomain/mediatek/mt8195-pm-domains.h | 199 +++++++++------ > > drivers/pmdomain/mediatek/mt8365-pm-domains.h | 197 +++++++++++++++ > > drivers/pmdomain/mediatek/mtk-pm-domains.c | 157 ++++++++---- > > drivers/pmdomain/mediatek/mtk-pm-domains.h | 51 ++-- > > .../dt-bindings/power/mediatek,mt8365-power.h | 19 ++ > > include/linux/soc/mediatek/infracfg.h | 41 +++ > > 14 files changed, 972 insertions(+), 446 deletions(-) > > create mode 100644 drivers/pmdomain/mediatek/mt8365-pm-domains.h > > create mode 100644 include/dt-bindings/power/mediatek,mt8365-power.h > > > > Applied for next, thanks! > > Note that while applying I amended the patch-prefix for patch 2->8 to > "pmdomain: mediatek:", please try to conform to this when going > forward, as it help me to better filter emails. Thank you! Sorry, I will use that prefix in the future. Best, Markus > > Kind regards > Uffe