Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "edumazet@google.com" <edumazet@google.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular
 header dependencies and fix headers
Thread-Topic: [Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular
 header dependencies and fix headers
Thread-Index: AQHZ8R1TpSizpDLlFkeA5ZoIhKoZsrA65wkQ
Date:   Thu, 5 Oct 2023 08:22:06 +0000
Message-ID: <BL0PR11MB3122EA0512BBE5CCCF62C66BBDCAA@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20230927083135.3237206-1-ivecera@redhat.com>
 <20230927083135.3237206-9-ivecera@redhat.com>
In-Reply-To: <20230927083135.3237206-9-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?69c0rkGwD/mPd1cLCkKp+/ul6L4YBmy3Qxm/VxNQDLsC/2TVmmf+HtEYW3oZ?=
 =?us-ascii?Q?vNMbvoB3mVn+HLWN5voGoCwq7yIwwPW2HxCc1sKWKufNqWJxXXbVzWAmtUT4?=
 =?us-ascii?Q?GwUwwc9Cp479Z2Rhrc0+Z8/RHP2Qfx3B1dKplGmUtckkv0V5AMMfr6z+ZSjO?=
 =?us-ascii?Q?s6qBJ9pNgFwdw7mVF71/THQPEYvsdlMklVBK7JJPxBYrXuva/JZgYJoATefT?=
 =?us-ascii?Q?WyRJCPIo32VS4AnjMOkVZPY4J3R6U9NDHWI0jnJlm47ukcRClDWwlbQz2DJ1?=
 =?us-ascii?Q?SowqIOgm+pITkaRy6CtJ+O5hJc7+M9Sma9Dd2QwPOqrhuMPHHFpFDWsYkW0A?=
 =?us-ascii?Q?6eVBFCCjT/D1YB+QjnOw6fu7JPL9eoLViWQNNfXo18WLeu+A+5kWME1GIeA2?=
 =?us-ascii?Q?NjkD7faKab+j61dS9K5onbTqyKRG6LIuRvcGWIqF96A7pbrkokh8F7VRnBqO?=
 =?us-ascii?Q?vrR9ou6JwWo0A+GF5rtcn70Oiarb/fYdQhBEPJqhAm6PjCin3MclxMy4AA50?=
 =?us-ascii?Q?OzE4FW5jgrqrpOgyz4IFxGyFfXje6brcDFJXAtqwiDsQyA9leIVSeAbn7zuS?=
 =?us-ascii?Q?ngRNgbDvx/jPEICAabgfZoDwEdvYk+ghQ2HF5SqAdDBVQ96JOWc6wKIFOpUl?=
 =?us-ascii?Q?efr3OE7cLTvVH7u41KXJ/tSZ+Pbu4tokIii0xNQmE32EFm+ehoRINV0Wjw3A?=
 =?us-ascii?Q?aQk5tscL2ZC/3dp2eg/4vMDkUhPhVBsEYRtIxOGW3rOkcFHhUV2pN9wVTS0N?=
 =?us-ascii?Q?c1G7acXIPy79qDLhYOW2e7f2M/sHUm9f/h/ULW+DrTPcuj9gRFKxmX6jZKe6?=
 =?us-ascii?Q?YEbTqsyjSMODEmrd2qoNsA9Jazox/73/lpXLGNtYv/s7uLToaa/dSYwkGOrB?=
 =?us-ascii?Q?Qe4mtkgKRXxdLlJEk1ycPaxV+rRTtT3Fl9FfndWmr+tMjJX2AAMSMcHes35N?=
 =?us-ascii?Q?aV6nxRQT++isjEuDbenceqIwVdCcRaOJWuDQT1Yy3abs47MpnUOTH6vv8cFi?=
 =?us-ascii?Q?qUyb++uULagvnWRyOh3x+B65VfS0W/9dwABUBLfcXuk0GU8vCjNkl0gos9sq?=
 =?us-ascii?Q?ilfmx/JbpcNoMng2qJbd8h5NQ+4WbMrXryG1+Z9v08T1l4kcRwstRFEUReBS?=
 =?us-ascii?Q?hlKNXXEUHUv7WETRT/KUWTnIe+8OgLDrVRbr6lu5BhEsLCsTI7sOmaiM1O90?=
 =?us-ascii?Q?+PkGEl/A+BQpM5WOXvLkvt5IkpuxYRCVKGxzLD0Z8Qrf68XTg31UbOb1jD5R?=
 =?us-ascii?Q?u72lEk300XogQCA3VSDyr0zbfiboWsR0NAHA2oOD7oztq6lwMU20wL8uqHYS?=
 =?us-ascii?Q?HNs2Te7+ZsKalWBXtc/rbwAF9JuukaBxNz/xyNQJ200MZ0GPShJh8jt9oGvb?=
 =?us-ascii?Q?tqHSbjhE9m54qnFGUyR0kcLT4+MAjqnd6cWa+6kPiqVRaV53OMHxrikcTq1H?=
 =?us-ascii?Q?Mh1cHmrF+W6ZuP7+UC9mDLq7YIGhPamNA4smJ5TFtRFQ2jgQpbkFPH9KIKCE?=
 =?us-ascii?Q?FjlTHT4v0ZgOv5MJbl1bKRCmNA/5epTTgYMeOeolNPzSrz2TYQLanluB5k0k?=
 =?us-ascii?Q?nMFeEBMOsoaoCnwTeQqs9JKLaMqKnzYvbFYi4ktx53G1eFUqdn34bVOoxrAm?=
 =?us-ascii?Q?Zw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a1abbd9-87e6-4ba9-8510-08dbc57c295b
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2023 08:22:06.3290
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OuDmKgAnWt1fgFJWnKkgpsn2huQuRq9IUqjR/cBWThloNKFc/CmJqwnjl0+HH+WIp5tV7WwhIDukAkX2uKpurgChtWIPlQvyQZX5NiJEe2s1EjiY8an4JjghUFep42tQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8473
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:22:40 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of I=
van Vecera
> Sent: Wednesday, September 27, 2023 2:02 PM
> To: netdev@vger.kernel.org
> Cc: edumazet@google.com; intel-wired-lan@lists.osuosl.org; Brandeburg, Je=
sse <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.org; Nguyen, Ant=
hony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitsze=
l@intel.com>; kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular =
header dependencies and fix headers
>
> Similarly as for ice driver [1] there are also circular header
> dependencies in i40e driver:
> i40e.h -> i40e_virtchnl_pf.h -> i40e.h
>
> Another issue is that i40e header files does not contain their own
> depenencies on other header files (both private and standard) so their
> inclusion in .c file require to add these deps in certain order to
> that .c file to make it compilable.
>
> Fix both issues by removal the mentioned circular dependency, by filling
> i40e headers with their dependencies so they can be placed anywhere in
> a source code. Additionally remove bunch of includes from i40e.h super
> header file that are not necessary and include i40e.h only in .c files
> that really require it.
>
> [1] 649c87c6ff52 ("ice: remove circular header dependencies on ice.h")
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h        | 43 ++++---------------
>  drivers/net/ethernet/intel/i40e/i40e_adminq.c |  4 +-
>  .../net/ethernet/intel/i40e/i40e_adminq_cmd.h |  2 +
>  drivers/net/ethernet/intel/i40e/i40e_client.c |  1 -
>  drivers/net/ethernet/intel/i40e/i40e_common.c | 11 +++--
>  drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  4 +-
>  drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ddp.c    |  2 +-
>  .../net/ethernet/intel/i40e/i40e_debugfs.c    |  3 +-
>  drivers/net/ethernet/intel/i40e/i40e_diag.h   |  5 ++-
>  .../net/ethernet/intel/i40e/i40e_ethtool.c    |  3 +-
>  drivers/net/ethernet/intel/i40e/i40e_hmc.c    |  3 +-
>  drivers/net/ethernet/intel/i40e/i40e_hmc.h    |  4 ++
>  .../net/ethernet/intel/i40e/i40e_lan_hmc.c    |  8 ++--
>  .../net/ethernet/intel/i40e/i40e_lan_hmc.h    |  2 +
>  drivers/net/ethernet/intel/i40e/i40e_main.c   | 15 ++++---
>  drivers/net/ethernet/intel/i40e/i40e_nvm.c    |  2 +
>  .../net/ethernet/intel/i40e/i40e_prototype.h  |  5 +--
>  drivers/net/ethernet/intel/i40e/i40e_ptp.c    |  3 +-
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  7 ++-
>  drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  1 +
>  .../ethernet/intel/i40e/i40e_txrx_common.h    |  2 +
>  drivers/net/ethernet/intel/i40e/i40e_type.h   |  7 +--
>  .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  2 +
>  .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  4 +-
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  4 --
>  drivers/net/ethernet/intel/i40e/i40e_xsk.h    |  4 ++
>  27 files changed, 72 insertions(+), 81 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)