Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp419142rdb; Thu, 5 Oct 2023 09:32:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaDx28lo/sbOojVJhNmOBJYciXc3gE/QgsRSLjt1qDZ/H+VVyeU1qP4m0gvLRCBr/TvMzC X-Received: by 2002:a05:6358:788:b0:142:d097:3725 with SMTP id n8-20020a056358078800b00142d0973725mr6026299rwj.9.1696523559995; Thu, 05 Oct 2023 09:32:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696523559; cv=none; d=google.com; s=arc-20160816; b=rMejlCI8sIPHo6tQqUA9R/tJLdcFFTKUYOCt0QYNWqqOXBlw4DUNU8NGDFdgEI4DZI Ique5W2WpzjjgiACGdAMGrDOdYwdS3ipWU+eTJ6q+PL9vq78m9+g4RPvCuUbLYGAkPj2 9hioNvGgFuYIB6tlMOVY43PpviSxZEbmp93oaFK9JxFK1zCTTZB+3EQo/SMeisOG8373 3/XM57QpAAUUxcWILpIRRmkyFkmfZqR/rUrTDu9noWxFxdVg2usJfOhGi5jI6Y4zSoNF l2t6hldddkHaB7yoMNRM+XZvEV6CRp4ZwJOvQpjk2lHeXTRSR2GXv+LWVv+SW4Qfahxc Kjuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ZkLDcbTg2LZzpKlEpvN8cg7AvWBe9lH/u2T/STaUBQU=; fh=DFWTeH9eDS1H8rtgOEZFK6/ROmeDF4DT8371lwSZiSA=; b=qY+6w9SubWhZN28NPq5WUOV51Mv3f7zxL7n/9pr3rUkeDDARfZUslU3iDTEJPMjlcI vMBQvZ6xoFddyYcLtEpzR144mlcbRhYgyt5hF6w7/wsSm8PTZRtVGoQ/o1C0WzvKxQtH RSZGl63a5qEzOl22694fm+NrWRbpGVV6YZ62Wd9f7I7W2WguxNs5JV6ioxlttcF82CBm upqaLxjYN/1ab8daq3ZUspt7gb71ij/9v5N2Zr7AlwCxVI0v4vQs+CMm21kAH/bQM4CB YbhveNqrAAo+0ToM13rD8d3wgNqqsGr+gORKdfta8E5OualVqLTQI1/XG7FWwNERx3KT HJ2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2hqIjnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id b19-20020a637153000000b0056959099f46si1677983pgn.856.2023.10.05.09.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:32:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2hqIjnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6107C808BE7F; Thu, 5 Oct 2023 09:30:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236948AbjJEQ2B (ORCPT + 99 others); Thu, 5 Oct 2023 12:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244130AbjJEQ03 (ORCPT ); Thu, 5 Oct 2023 12:26:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1787F1709 for ; Thu, 5 Oct 2023 09:21:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C28B8C433C9; Thu, 5 Oct 2023 16:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696522907; bh=vVI8ELd2bANGUqh/pj5lOKnspn0ZKfxuLxlqRTq3km0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V2hqIjnc2FRu4Q4idwN+YjRvKFcC97MMcraMtaMDZf3lvHIRCJjYn0wnCQZ+bnVVz V4DMWSj18apzV2yEMRX+NVOAvtpIqohsBSNClYUJRYqSpxgb5QSiMT9xt+WxjGW4M1 8giFd9Gz5cuOxDBGHoNDidTSienNMLgoYDWiYuSmdzfFhc9JZPTJgV8pw2v8s3im1e h1EDzp9LOdXueKHmxo6I+gyGLHBUNLa/JJUhphxZPLmeP8lGDYHKXl0lP3efp4/aSS uceFuTUPqW944M/fj4E1sK9kdcmyTwI7C/6To2vK+zzBJ7Vujs6WKx9gklogyhSkmH TccYTOwWomhdg== Date: Thu, 5 Oct 2023 09:21:45 -0700 From: Jakub Kicinski To: Ratheesh Kannoth Cc: , , , , , , , , , , , , , Subject: Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation failure. Message-ID: <20231005092145.08cc84fb@kernel.org> In-Reply-To: <20231005021434.3427404-1-rkannoth@marvell.com> References: <20231005021434.3427404-1-rkannoth@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:30:27 -0700 (PDT) On Thu, 5 Oct 2023 07:44:34 +0530 Ratheesh Kannoth wrote: > + sz = PAGE_ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN)); > + pp_params.order = get_order(sz); Surely get_order() rounds up by itself otherwise all callers would have to do the PAGE_ALIGN()... -- pw-bot: cr