Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 5 Oct 2023 16:38:44 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     werneazc <werneazc@gmail.com>
Cc:     Rob Herring <robh@kernel.org>, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, lars@metafoo.de, devicetree@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti,ads7038: Add description
 for ADS7038
Message-ID: <20231005163844.3294e4e1@jic23-huawei>
In-Reply-To: <CAKDJRcf4ikKWvENrg=9JW1EneY8qehD8HTxahL8x+5KxoCSQ0g@mail.gmail.com>
References: <20231004102330.3713-1-andre.werner@systec-electronic.com>
        <20231004151150.GA3140591-robh@kernel.org>
        <CAKDJRcf4ikKWvENrg=9JW1EneY8qehD8HTxahL8x+5KxoCSQ0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 5 Oct 2023 05:51:40 +0200
werneazc <werneazc@gmail.com> wrote:

> Dear Mr. Herring,
>=20
> On Wed, Oct 4, 2023 at 5:11=E2=80=AFPM Rob Herring <robh@kernel.org> wrot=
e:
> >
> > On Wed, Oct 04, 2023 at 12:23:29PM +0200, werneazc@gmail.com wrote: =20
> > > From: Andre Werner <andre.werner@systec-electronic.com>
> > > =20
> >
> > Needs a commit message. =20
>=20
> Added in an upcoming commit.
>=20
> > =20
> > > Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> > > ---
> > >  .../bindings/iio/adc/ti,ads7038.yaml          | 51 +++++++++++++++++=
++
> > >  1 file changed, 51 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7=
038.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yam=
l b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> > > new file mode 100644
> > > index 000000000000..37fbae95c8e6
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> > > @@ -0,0 +1,51 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7038.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Texas Instruments ADS7038 and similar ADCs
> > > +
> > > +maintainers:
> > > +  - Andre Werner <andre.werner@systec-electronic.com>
> > > +
> > > +description: |
> > > +  Family of 7 channel, 12 bit ADCs with SPI/I2C interface.
> > > +
> > > +  Datasheet: https://www.ti.com/lit/gpn/ads7038
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - ti,ads7038
> > > +      - ti,ads7138
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  spi-max-frequency:
> > > +    maximum: 60000000
> > > +
> > > +  vref-supply:
> > > +    description: Supplies the 2.5V or 5V reference voltage =20
> >
> > I don't see that in the datasheet. It has AVDD and DVDD. =20
>=20
> Yes, that was a copy-and-paste error from another description used as
> a template.
>=20
> >
> > Also, looks like there are GPIOs. Those aren't ever exposed to the OS? =
=20
>=20
> Yes, you are right. This is a fundamental implementation of the driver
> to support the chip family. I want to add further functionalities in
> upcoming commits.
> I wanted to get some feedback when the first steps are done to not
> reinvent everything from the beginning if something is generally
> wrong in the driver structure and the way I had used the APIs.

Device tree binding should fully describe the hardware, not what
the driver currently implements.

So add the GPIOs for v3.
>=20
> > =20
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - vref-supply
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    spi {
> > > +        #address-cells =3D <1>;
> > > +        #size-cells =3D <0>;
> > > +
> > > +        adc@0 {
> > > +            compatible =3D "ti,ads7038";
> > > +            reg =3D <0>;
> > > +            vref-supply =3D <&refin_supply>;
> > > +            spi-max-frequency =3D <10000000>;
> > > +        };
> > > +    };
> > > --
> > > 2.42.0
> > > =20
>=20
> Regards,
>=20
> Andr=C3=A9