Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <008b8ad7-d6c0-e026-9e12-1a4d92848c4c@oracle.com>
Date:   Thu, 5 Oct 2023 16:05:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 21/21] nvme: Support atomic writes
To:     Pankaj Raghav <p.raghav@samsung.com>,
        Alan Adamson <alan.adamson@oracle.com>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org,
        chandan.babu@oracle.com, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-api@vger.kernel.org
References: <20230929102726.2985188-1-john.g.garry@oracle.com>
 <20230929102726.2985188-22-john.g.garry@oracle.com>
 <CGME20231004113943eucas1p23a51ce5ef06c36459f826101bb7b85fc@eucas1p2.samsung.com>
 <20231004113941.zx3jlgnt23vs453r@localhost>
 <b6ed0e26-e3d4-40c1-b95d-11c5b3b71077@oracle.com>
 <83f58662-d737-44b0-9899-c0519a75968a@samsung.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <83f58662-d737-44b0-9899-c0519a75968a@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzhDQjdqMmplSjNvdzV2OERsSm5NM0RUZEtWVUZmWmFndFdxbnJRckl1TUVj?=
 =?utf-8?B?NCtxYk1VbGVNSzVadkw3TVlaWW0xZjhCQkxXQ3V0eG04VFlVeVQxZG12Nmt0?=
 =?utf-8?B?bnNDVEdNSzVKNW4wU1REeHJPRzYzbHdqZnpkZFBsY1NVNEppMU1YdWVKZkJQ?=
 =?utf-8?B?blBKZkFWMXlCU0dPMFQybFcyTzE1TjBJelRUL2MwcXhnSkNPcDk2NG5MU25Z?=
 =?utf-8?B?akpTbTN1dUhYMi9RKzFQbkluUENMcjdFVHl3ZkkwMVdjS1VtRXZSWk82aEFS?=
 =?utf-8?B?aUFGWXpqT1d1YlBmT0Q2TDFpcW0yYlpkOGlQWkNkN0l4eU5GUENySVFZSFJ3?=
 =?utf-8?B?UllqU3BqSUFYekx0aWlQTmVNK3JLVWNLN09uMHRlWVYvMXFjT3Q4NlY4SG5l?=
 =?utf-8?B?VXBrM0Z1RWJXajlRM2s2UlJ2bmh3RDlTQXdCTjFsNStnOWRGYnZ6QW02ZlhV?=
 =?utf-8?B?azAySWYwTUszdXYrdHNDV0JhdmFTQlFmZzd2aDREV0FqWHRpMkpzM1lNODNQ?=
 =?utf-8?B?OUVUeXVxNFNTVExSR2QvaDRTRDQ4eEFINE9La0VySHdrUlVwMGhSWjYvQ20y?=
 =?utf-8?B?VVY0YllqQ3Q2Y2I0R1EwLzEyRnlzT242Q082UU5kcTBCRUVZdmdaZEJ5WEJo?=
 =?utf-8?B?aEJKWTZhK3hIWXQycCtSdlBQSXNwVXhxS0xsbytKTEV6RzZaYkVGU0NZejFN?=
 =?utf-8?B?WXR3YVI1ei9hL255QlhLZDdLQ0JGemhmS1FuTTgzcmZXK3Uwc1NESG9EZUxM?=
 =?utf-8?B?MnN3b2dQS2dLYk9vR1M4cTB6Q1ZwdXF3c0RReldpVkZuVjlwQnk3cXBEZjJK?=
 =?utf-8?B?elY2TFlMMG4rMFZjK2lVRFR5LzlYeW9OMmlpRGZTUHZ5eGpHcko4ZEdhdzRS?=
 =?utf-8?B?VXVvRWlkVWZMUzZEYWFaUXp5ejRsZklMNG1MT3NzT0JPU3Qybi9KNXIvYWE3?=
 =?utf-8?B?bGJtWFRMc0YzVStJZGxlOXVubWFnQ3NrVnNISlZWd2pWakZ1MWZBbXB6T2NU?=
 =?utf-8?B?SHZoZUhtYVhibnNBV1dsRGQ5aTArZUc5VGRhK1JYdWIwRnU2eTlvd3BlL2pV?=
 =?utf-8?B?VzhkbWNVRUZIOGQ4ZFQ0Z0plWGRpb1hTZmErOWEvUHY5R0IwS0luRmNVNlAr?=
 =?utf-8?B?VlNvOVBFYlJsbHoxV2E3UTNZUGNYb2x2RTk0Z1Q0SEdxbWt6ZERNaDdYbkw5?=
 =?utf-8?B?cFpMSFkwN3NxOEpRbXNWR1FYOWI3ZEhUOCthMHNONzF1aEhrOXF5blFQLzVq?=
 =?utf-8?B?NnZHenJ4NjdKUWpRNHl1L2pmUVBKVm9USjkvbk9nWTkwSmRDUDl4Y25XY3M5?=
 =?utf-8?B?TVc3Ty9QYVd5SXprYk9HVFQxTm1QYnpidklkZzRBL1c4TnpiR21ZRUw3ejls?=
 =?utf-8?B?MUtnZWhDTllkNW1telRsbVV3am9Ibk9CZ0tYazB6ZGU3NHVSTitRdlpJZHRZ?=
 =?utf-8?B?VkpCQTF0L1ZUNjAwV1FqSkthb2pSWGNGWTBjSUZwTWQ4M0toMkE3blhVSVR4?=
 =?utf-8?B?aU16K2ZPSHAvendXMDdTTXY1K2NTN28wUjRDYTNnNG5qa28vSFlxMkNsN2lx?=
 =?utf-8?B?dDlnSzlmSUhEOXljK09HTldUQ2hKT2xvMS9QcmFRbTNTUC9PRWpYdXRYdzM3?=
 =?utf-8?B?UEV2NnNXTGxaVE5BNkhIZFV3akxHN1V3eVU1ZFJkVzFNR0ZERFVFbUxScW05?=
 =?utf-8?B?Si9IT0RhWVgzSENFWHdLY0FKM1NsbXgxeWtCSW9TNmxUdWFyM3hvbWRDL2tL?=
 =?utf-8?B?YnlOUmtSS0ZNY0doa0p4MmptOWZuQitGeXozb2VtNzRhell2ZTNlcnVEMVd5?=
 =?utf-8?B?TWdTdm83Y2ZJdExGdGdsR2hpTk1pYm1sMDN2M2U4SUFSRG1NL1hBR2xueGZR?=
 =?utf-8?B?eCtEWVkxTG1tcTdVZUUyY2xyeVpreXZ5QmlLVUxNMzhPYXVlN00xaStaVXZT?=
 =?utf-8?B?WFBUdmRnRll1MUNDY3NQcFNUVUpZaDliVkVrcFhhZitGdkRUT1Zpa2QzRGdl?=
 =?utf-8?B?RjBmandLY1ZQNkJJVVN1WE12SElLSWxmTnBIRXZ4eDFDeWJGNEpzRjVjZnJX?=
 =?utf-8?B?MkNUekphenduVktST1NHZm1zbHdqUmtmaVIxUGxHYWRPeEh2ZDNBQ3VhcVhH?=
 =?utf-8?Q?Oq4/4VudK3u5gKdU6i8kLKaLk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QndkYkFYMFU5WlhtemJlTkdsMVJxOWZiZjhTM2hiYkZHUms2RU5ucjdsWHlO?=
 =?utf-8?B?Uko1Y0FVRGczSmNIWEJwbWpBV2sxRDhxWWN4Mm9DQ3JXbHlwVHBVM0R3OEZU?=
 =?utf-8?B?L2VyQXJwcnFUSGV6OEd2MmpZT2ExUGVSVEh3aTJGYTdMZXo1TzJTbElQMjAw?=
 =?utf-8?B?TSs0Z1owSk84OEZtVDdWbi9sUXlkcHQ4ckJFMjd0RStKR3B2Y1VMcTR6ekhx?=
 =?utf-8?B?ZTVpaVZrZjhBNXhaQUJoZSt2ZGE5MXF5emtSNG9nYkZhYkVIZ3ZlZ0tXd1oy?=
 =?utf-8?B?NlVTMC9wYVhhaWRrakEzejlrZnZ4aW9CNnBHQjllTjZncFJuN3hBd05hYWpH?=
 =?utf-8?B?dTh0WkhXNHRDSTFFWElJR1RvZjVIeU5WOVZyUDNVdld5K2hjbVA5cTBTcUxQ?=
 =?utf-8?B?THNldEJhN1Yxd0YyeVhNamlJUVJxbmR0K2VXUEI1NUxpeEFUR0pUTWV2M1hL?=
 =?utf-8?B?QzZaaFZBaVhLZ1NETk03eFlUMzV5VVNZb1lua2NEclUwdDVIMHdkSkwwbkkz?=
 =?utf-8?B?cnpGTEdhTzBvd3lnRDU5Q1BlOVNhK3lGRmN5SWF4cjNiZCsydGNJMjlJVXJ6?=
 =?utf-8?B?ejVPdEtZZW1WUG5FKzRKUk9OOUxzRkQ5a05MNFp4eWt0d0dmN1lQTHZBYWht?=
 =?utf-8?B?NGZ3c3dnOGpxQ04wTUhKQVY5MVM3RUdzVzl0NTk1bEovczc2ckE2aHFadk1i?=
 =?utf-8?B?RCtQSnhaeU9NWTVJbTdIeWoyY0ZwblFyWmc4eUdUUlVjdzg1d1V2ZENEM1BM?=
 =?utf-8?B?QkpvbXlxc3h1OVpCRDROSXNHVVpMa0pzUG9ReUtYemgyQTJZNW12TmcvSVF5?=
 =?utf-8?B?Ym1nTHJNbXZkOTFrQUJCQXo0cTJKTDd3dkw5VFJVNTJ1TjFJTlZXYU1LUU1Q?=
 =?utf-8?B?bnBwQkVhTkFGcTJiY0pTcE5lNFova1BxZ2ZTU0w1Zk9lNFEya0N4eUp1Ry9a?=
 =?utf-8?B?bjltc2JmZDRxcFZ6bGtmRVN4U3pFa0x6amZ3V2lHbzRWcWpYd3JxMXhpMWdD?=
 =?utf-8?B?bzN1U0hWODJKc0I3SU0yMCtvY2NHMWx3REx4YUZrNXl5VGxXdmU5by83dmJz?=
 =?utf-8?B?SHVhVHJIMURINUFZTlFLcUxnSnpiWW1SakJSVjZKeG9WQ1ZISjhZL1lMREc4?=
 =?utf-8?B?dUVtdDJab2poSCtlVmdIb0NEOUQyN2tBWnhEQWhJSHBLQXkxYk81MlhtOHc5?=
 =?utf-8?B?T1lqSnFIOHpsMlJYVG5hTFVOdUYyRVE4Zk82NForWkthUUxVV0FESUowa3Jz?=
 =?utf-8?B?T3FjR2xCQitXc0VzcEdZUHN2enRpUFFVdS9ZUVcwUlJ1d0tJaVMzcCtRMVZX?=
 =?utf-8?B?Mlg2NDVLcUQvUDB5bjEyNlhCWE13cWtJalY5blNuRTRaWHkxamViSHhBZzl0?=
 =?utf-8?B?ZDJiYkEwcEJ6ZkJVY0FZRzVKazlOd1o0UlhmcUZCQlNESVNvanpxdHdid0xq?=
 =?utf-8?B?Mk12UWd1WWRQdy84N2RBUjBBRVErWm5EdzNROXh5TXVFTXFZM0dVZVk5VXZh?=
 =?utf-8?Q?eGkS6SuPeEMG1Y0IbUWRZaBI9iF?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b44a0138-2bad-4d18-6bcb-08dbc5b49363
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 15:05:56.3345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zsdArVLPRt+EXcY9hU03niAKI2i/JBQClTP7J/hQ/Q7qGKBurRkPsstm27ZPEPUGzztu9ojql9TxB/suvwe9Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7515
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-05_10,2023-10-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310050116
X-Proofpoint-ORIG-GUID: CLDLPex2-uCGcL4rIriYkgMIABaOILfj
X-Proofpoint-GUID: CLDLPex2-uCGcL4rIriYkgMIABaOILfj
X-Spam-Status: No, score=-5.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:56:01 -0700 (PDT)

On 05/10/2023 14:32, Pankaj Raghav wrote:
>>> te_unit_[min| max]_sectors expects sectors (512 bytes unit)
>>> as input but no conversion is done here from device logical block size
>>> to SECTORs.
>> Yeah, you are right. I think that we can just use:
>>
>> blk_queue_atomic_write_unit_max_sectors(disk->queue,
>> atomic_bs >> SECTOR_SHIFT);
>>
> Makes sense.
> I still don't grok the difference between max_bytes and unit_max_sectors here.
> (Maybe NVMe spec does not differentiate it?)

I think that max_bytes does not need to be a power-of-2 and could be 
relaxed.

Having said that, max_bytes comes into play for merging of bios - so if 
we are in a scenario with no merging, then may a well leave 
atomic_write_max_bytes == atomic_write_unit_max.

But let us check this proposal to relax.

> 
> I assume min_sectors should be as follows instead of setting it to 1 (512 bytes)?
> 
> blk_queue_atomic_write_unit_min_sectors(disk->queue, bs >> SECTORS_SHIFT);

Yeah, right, we want unit_min to be the logical block size.

Thanks,
John