Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
MIME-Version: 1.0
References: <ZR6+MhXtLnv6ow6E@kernel.org>
In-Reply-To: <ZR6+MhXtLnv6ow6E@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 5 Oct 2023 08:45:09 -0700
Message-ID: <CAP-5=fWtX3_bmBHbeEskmM4rzX-r1LAhE8_kaYy8WueUpKCdUw@mail.gmail.com>
Subject: Re: [PATCH 1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 6:46=E2=80=AFAM Arnaldo Carvalho de Melo <acme@kerne=
l.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> By default perf will fail the build if the development files for
> libtraceevent are not available.
>
> To build perf without libtraceevent support, disabling several features
> such as 'perf trace', one needs to add NO_LIBTRACEVENT=3D1 to the make
> command line.
>
> Add the missing comments about that to the tools/perf/Makefile.perf
> file, just like all the other such command line toggles.
>
> Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/Makefile.perf | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 98604e396ac33643..456872ac410df4c0 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -69,6 +69,10 @@ include ../scripts/utilities.mak
>  # Define NO_LIBDW_DWARF_UNWIND if you do not want libdw support
>  # for dwarf backtrace post unwind.
>  #
> +# Define NO_LIBTRACEEVENT=3D1 if you don't want libtraceevent to be link=
ed,
> +# this will remove multiple features and tools, such as 'perf trace',
> +# that need it to read tracefs event format files, etc.
> +#
>  # Define NO_PERF_READ_VDSO32 if you do not want to build perf-read-vdso3=
2
>  # for reading the 32-bit compatibility VDSO in 64-bit mode
>  #
> --
> 2.41.0
>
> --