Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp432717rdb; Thu, 5 Oct 2023 09:58:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLoLQWmwcY/0hjfbQGo+T2FVV+BLhGA4voq+nMNG2L1x6q6yqlIlTgSa0IgAOhHDTr8lV0 X-Received: by 2002:a17:902:7084:b0:1b6:649b:92cc with SMTP id z4-20020a170902708400b001b6649b92ccmr4669045plk.69.1696525134693; Thu, 05 Oct 2023 09:58:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696525134; cv=none; d=google.com; s=arc-20160816; b=W6jSzf+SoyzlmHWGMomQ6zBOznOXriCue3mWboYbS0/iQQVQmxsvZ9PUqP9BIg8n4+ ZMXtSv7xaY+QYeHrWPiPvjFP3OUaEC8IRtp6fxYC9WPbzqBmB8W7gZuoHGqQmaWEFS40 wnlXJeBRqtjLwwBIozA3kELK3L5vOUvfg24Nh9MQ17I7RafocSclvoH92OTEXhCCN7d3 hPQTJojFqzc22ZRs9Ln7gJZaiWa8OAqgoKBAXjTi27/xvAnWaVHGLXhfUT/4lCAQhUza i/60zTWdUchwHj1KpaPvBLRFtCbLfFrkGDdpv6OS8R2At31q9F0goofL8pmoPyjGpbDo nEDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=bhehRkAcisDo+pGOQLMRxqAGq1y9OCFtpvbtY4rto2E=; fh=gjNNplgbwqDtfR0iiTtYiPk3G/ma4yYT3hwV7WaxUe0=; b=p/lyH/JiqV7hnvF1vxw92LOI8DmSsPWfdDKZGNCdd47sHstayhmILDeMkV8wM3L5fQ mEWsHeMz5SLb9GM1NSzkP/R/t9ezm87C7DsBQdfwljniD+fd3yRcqwIPnYcK1X6p7xnP Wsi3dWdL4IqiRD/MkJk0poyFpTCs+4X2wROC4i96S/yse1CvumYpjJIxa9+/T4WYGRhK xIKH9/oujnxPyBEL0pYeWXjahwzvmCsoJzYkw1XEvWYTfM/MMLaQ1Op8st4r3ZrQ63LN nf/nOBckOtg/MN4dNhvqpsWhPrFdVIwcr8P9xwM6fp4KD4d2zPPZFPjgqiImzO2b9zgB J+tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@daynix-com.20230601.gappssmtp.com header.s=20230601 header.b=J0JYLqSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w10-20020a170902e88a00b001c6223663b2si1948028plg.339.2023.10.05.09.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:58:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=fail header.i=@daynix-com.20230601.gappssmtp.com header.s=20230601 header.b=J0JYLqSp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5F439833E86D; Thu, 5 Oct 2023 09:58:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241169AbjJEQSA (ORCPT + 99 others); Thu, 5 Oct 2023 12:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241078AbjJEQOM (ORCPT ); Thu, 5 Oct 2023 12:14:12 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51ADF7AA2 for ; Thu, 5 Oct 2023 00:21:45 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-690bf8fdd1aso559863b3a.2 for ; Thu, 05 Oct 2023 00:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1696490505; x=1697095305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bhehRkAcisDo+pGOQLMRxqAGq1y9OCFtpvbtY4rto2E=; b=J0JYLqSpzkCZ6BdEnoa/liu+LPdyncdMwXtORUAHCTgtF9y1ukvFH2a/3hIsR5kk99 CulV63SjxX33xXR4k7f7jafPelz0m+6fgzaE689tUCBGn8LmH43LTyurDvZz9wD/zZwL e7BJeDBc9A7Kunv3JWnHKBDb9vzPrsqUkKp0yVCe3cv+z786ahRbxZFgw+bhcZMDK004 xxwMlNbkDENZtrNfadB3TS+i58CmHjGx3sXHPwC8X8CNGFY7E75LFf+0J26uampkCEDv l2g9YZ3e/uZPLHD6dx7IueyZPg+AlDy+sNbCqPmuVb3b3UoXU4Ex+FVK0SyDwvmVvycJ 7FXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696490505; x=1697095305; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bhehRkAcisDo+pGOQLMRxqAGq1y9OCFtpvbtY4rto2E=; b=tc4S2b1cqo2yuHO/dP9442xuZXWnVnBVZVcQzluD29IV1Qxsc8x1QItvIGkHTeuVsI +RSRnSxOFkCbRCqGXZZk4P1Ub7XTo6MVoyD9xY8iq58aLRullTemS/EtKZVSSBINf+7m lRY59N9rRe0ks+3bycC8esDQDRcKyQe9uxT0yNWJ4n+ysj0jLIyws6dw70l1WYydPR2U NmPfwt8IE2oKNHdUWvBeHHnX2VZuf3ueALGUChNLlXK/AcQ5vnFlIdJusSWfoaI60hPE yLZoBdVJ1k/QBd4rsgrFGJ2hUf5HF+RnrEZsvG5d66ZiHtzNFrt5QNMr01HbF5cQ1DhM HJog== X-Gm-Message-State: AOJu0YwZeIotaHQCGho0nHvcbr1e+BURcFHTIHVCjhVrWC644r7VEMng tKH8nIAo7mwxUCw9Xd8PCPHzVw== X-Received: by 2002:a05:6a00:1d8e:b0:690:41a1:9b64 with SMTP id z14-20020a056a001d8e00b0069041a19b64mr3737258pfw.1.1696490504720; Thu, 05 Oct 2023 00:21:44 -0700 (PDT) Received: from localhost ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with UTF8SMTPSA id j10-20020aa783ca000000b0068ff267f092sm663033pfn.216.2023.10.05.00.21.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 00:21:44 -0700 (PDT) From: Akihiko Odaki Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Akihiko Odaki Subject: [PATCH] bpf: Fix the comment for bpf_restore_data_end() Date: Thu, 5 Oct 2023 16:21:36 +0900 Message-ID: <20231005072137.29870-1-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:58:53 -0700 (PDT) The comment used to say: > Restore data saved by bpf_compute_data_pointers(). But bpf_compute_data_pointers() does not save the data; bpf_compute_and_save_data_end() does. Signed-off-by: Akihiko Odaki --- include/linux/filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/filter.h b/include/linux/filter.h index 761af6b3cf2b..bf7ad887943c 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -694,7 +694,7 @@ static inline void bpf_compute_and_save_data_end( cb->data_end = skb->data + skb_headlen(skb); } -/* Restore data saved by bpf_compute_data_pointers(). */ +/* Restore data saved by bpf_compute_and_save_data_end(). */ static inline void bpf_restore_data_end( struct sk_buff *skb, void *saved_data_end) { -- 2.42.0