Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp432854rdb; Thu, 5 Oct 2023 09:59:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpUzcsEbWcyg/7S1BbHj1iAqZyS7/F9ntBbm3lCCL9Nk0kFCTdCE4veolw9iF2ptcESyHR X-Received: by 2002:a05:6808:b3a:b0:3af:a107:cf68 with SMTP id t26-20020a0568080b3a00b003afa107cf68mr5775435oij.40.1696525150012; Thu, 05 Oct 2023 09:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696525149; cv=none; d=google.com; s=arc-20160816; b=QRTdOuXBvvE7RmfoXt6jNP77tCQqSR9KVypudilltvY6+SOwiHuUmt0cnYZVMoub/W LrA/XuN3lM7LoOT1T78KtQdff65RUA1kJ6J2YHcu/ILwc4f4HPdGEZ2NrGG/b04oNHmS 2a7OUonKActeqnHU8V8ui4foLrLm2Iiz5uJfMM+VsWT3TuQUNDw9zK9d07eQcW82ioeG UQsqkF+FvTIaJlewTjRPk0I/8YcdIJbfAJ0O5YmIBXedHJm9ht/pbQCeZ+LRupLg0skX OEZMrfXU6j7r4rdEo9yTarUQaoexk2E59WwVlF/qKIKugwc+0ZcuKn6lE+18a5EDDei9 Idig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=sR1ro6Btb9zVlOyJgiMOiITvptK+ipD63Gcc/SLyRos=; fh=ty4nLjAWZK18CLdAFIx4zdCn9JrvoLQtUBviUuX8aJo=; b=qYdWE2HeCALyRCiaVNpOHrLx9DukNSfFh+nko78ph9iJk02qSKjnGxBKQ/nqvzWP68 B7ymspfWXoP3CgTrSURwCJMaBHg+zAzIb3gfeTAUo5phiIiJIXC0n+aMfpPsfsbYF6SN Tuek4S6poPRW9ll0d5LzQ6D9fAUKfjQRrrKYl366ZPFkWm2NPvdqkgD4xYtXOnzS07Zj RjYbfWvTlVN46NF2paq+TWa0UuuiamPtWhnpZm8DIF+lJlj3J6C0XOFyszXBC3R9ci+O gxGiyswHGX68rdtwLeW+FqNgrZRbVeqil1FwFfQvS9OPlnTqepF1V+PqqV4Ou7mDQXjY bAgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x20-20020a631714000000b0057c9e0c7bb8si1804315pgl.312.2023.10.05.09.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:59:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DAC9783421B3; Thu, 5 Oct 2023 09:59:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235918AbjJEQC5 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 5 Oct 2023 12:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235789AbjJEQB5 (ORCPT ); Thu, 5 Oct 2023 12:01:57 -0400 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD06323D20; Thu, 5 Oct 2023 04:05:06 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-57de3096e25so174467eaf.1; Thu, 05 Oct 2023 04:05:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696503903; x=1697108703; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8A+Fvcyy0CxxYZT2asQGYv+IG3i4az/fLQnzcd8QYxU=; b=VYScoWd491SLfWxMN1VGvJ2u6TGMZdVswXfMsBYpqcH7KnP4fP19rQ6KG6ZiSdHQ/p Dq+pv2s+Jhmc10A3f9FwxB7jwO1fHriu9gYbKFaQRHt/PVhwax+azLTUFVfGfbGLp5V8 yBmWPiABQoZrDCmk2/V/r+T9MHAD0VpJHYpIK8+Q5ksEMJy5qWvU8Xdua/Efy0OEWn/M 0NiyjYIoAQ7P6yzPW/z52tdAyPIExh3sqsuohpIm/jtg9ru6q8g0pJDNlR9c56qpaDXA mMmSM3w5qAAo5akTOkddY0W9ZxZ9PJ9aFNyE5ZVqS1s8qyhTdZ0tcCP0FGkmosNdkdvi Qdxw== X-Gm-Message-State: AOJu0Yy9EThVfJWezSlXIFBmjcSKPyy/hdWg7b/uG+nnPkyq6alHtvjq oPIg9L1NKa4E+hMX2omjic8WCq5Qay5ol7mW0xs= X-Received: by 2002:a4a:c509:0:b0:57e:c9bf:696e with SMTP id i9-20020a4ac509000000b0057ec9bf696emr4741772ooq.1.1696503903280; Thu, 05 Oct 2023 04:05:03 -0700 (PDT) MIME-Version: 1.0 References: <4846448.GXAFRqVoOG@kreacher> <8288399.T7Z3S40VBb@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 5 Oct 2023 13:04:51 +0200 Message-ID: Subject: Re: [PATCH v2 3/6] ACPI: thermal: Combine passive and active trip update functions To: Daniel Lezcano Cc: "Rafael J. Wysocki" , Linux PM , LKML , Linux ACPI , Zhang Rui , Srinivas Pandruvada , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:59:09 -0700 (PDT) On Wed, Oct 4, 2023 at 6:30 PM Daniel Lezcano wrote: > > On 03/10/2023 15:21, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Combine acpi_thermal_update_passive_trip() and > > acpi_thermal_update_active_trip() into one common function called > > acpi_thermal_update_trip(), so as to reduce code duplication and > > prepare the code in question for subsequent changes. > > > > No intentional functional impact. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > Reviewed-by: Daniel Lezcano Thanks for all of the reviews, much appreciated! I'm going to apply the series now unless you have strong objections against any of the remaining patches [4,6/6]. Cheers!