Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp440612rdb; Thu, 5 Oct 2023 10:10:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPABav5ilcYwVHlOSGpXxVumPnej0TLzlOhhad+IdhZ/Cn9eIlBWWUBTsLalpv0kBE3Lbf X-Received: by 2002:a05:6a20:8f1f:b0:13d:5b8e:db83 with SMTP id b31-20020a056a208f1f00b0013d5b8edb83mr7293919pzk.9.1696525804095; Thu, 05 Oct 2023 10:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696525804; cv=none; d=google.com; s=arc-20160816; b=I+rTUVbrW8iR9+nSYXQfDSbQzJ+fq5bAAFlZWQNF56aOC+85QQ1jZ8WeQB3O0n9y75 MLwVkeM3Rm67K4cfyM8PBrzkkkXyOOTr7ovT7eWG1IlMKbbJ1rKdxBbYhtya3xneDpdQ 1b0nXmC4LZ5uLATo7D9iJ/Vp5Kmv3zXwqxNTagm/7ynSFuyRykLTnEX/HRN/eEeYazcS NCWthsQdBYRM5pw2+ojCBWuYcZx1kahGYmbDY2jdqdcfBRJjuHqoF7wVRq1w19JbBvE7 gz4NPHztTzSeaiiI0tPSfzZZRHtPUF3tO+iiM5VPr2u6bPIA/Mo9/SueOVyN/ctFgyth lTrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=WgW7kVDuz2dwRfbyuaJkQrKoMU08UEVmYCgpM2nqKLU=; fh=+R7r+PELPwiJH02iwdKKJlNvyZG6T1NX0zzSOFn8l60=; b=IwgLsUxEqlpACT8r/+vZFGeAGbLDg+6wH6XFUfCx80orY4EJc/iZn6YEPj7VQvqS2K NGOFrd3kw5NMnvlkjjxmT4ULN5CcXFfhIisC6B+XXOfsyYg+/atPDk/VVcWgFJN2UfDX 8U5xGwQeOQf9HU88R6FQDB//jKVYunrzSggCj8bNa5M1xFefRAGHzWw36rmrBvaBzcS5 L+bHPy1R/iy4Wkqc38j2vYGgI3Adb4axxlFC53OMtpaQZ4Hczihpu/FSbQsJlZG8fCkd LjZaDHXN0bneAG7TweRiOsizM4v0/ZbiI1HD9J+3fAKY9kFPD9p8hSCiFCSdxqAWmPp1 qwPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=2NLuRkaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id be25-20020a056a001f1900b0064f78c32b89si1714696pfb.95.2023.10.05.10.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 10:10:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=2NLuRkaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EE4BC80C7100; Thu, 5 Oct 2023 10:10:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjJERJb (ORCPT + 99 others); Thu, 5 Oct 2023 13:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231491AbjJERIL (ORCPT ); Thu, 5 Oct 2023 13:08:11 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21E6E47BA for ; Thu, 5 Oct 2023 09:53:37 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-59b59e1ac70so17631937b3.1 for ; Thu, 05 Oct 2023 09:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696524816; x=1697129616; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WgW7kVDuz2dwRfbyuaJkQrKoMU08UEVmYCgpM2nqKLU=; b=2NLuRkaNvG+LG3R0vE3dkIbJsBZZ0g2ahux+W5dhb9EVNAtJ6napyF+d9C4d7N3Fva PhEg4mLjxz65SJ+H5IK9JkNlMwVjyVZrrRu2Dj0LBcNQAL3Mv/AgnlIe0ir8eP6nXYW/ DPWfEscxTMLcYnFQW2+urjtm+PilbgdVkH48rjOev34DWXg1RZjd2owM2rzrjVKTjJI2 Ei3PMBQGW3HiR8cbAdTd3Q0VElWiB7iA3HJx9GoGVnxfeMx6bB21OWaW+4sip62qcvC9 i1+LV3KZ6pLjoVgmokUpaPj3g514vkSpaFJfGCI+gQWoB8Q8AH1QSS8G4LBOWCCqUpjX PdjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696524816; x=1697129616; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WgW7kVDuz2dwRfbyuaJkQrKoMU08UEVmYCgpM2nqKLU=; b=M7FTcULfpK8icgEKTOL7w/ndSDRQQ7tyRbhFNGSowYaptwwr63AB/iAYtPaFzIdk/E FVhcoCExGVPIDQnEIV8KkfWMCFHHNyD7wclw2BjLPGLsuDhQRfIaKXLYKSzJmxhUPFRB q1+JgN6mEsh5uB7+gT4cvs/wZ5m+ohp1d/yS8lL7uTkBLq1CO5GdMlbrFTGo57hBQNy2 UcPF4sfcZSSCmj6QfGW65MjNovcZa/uNm7gY8d8S8Mh6MzgT3faj0I1qgDemT9Ibg6Se wReHDs5w+f3Lb42bWZLifD+cHU5/vSmJedcKQ22JprlZ9DdJNB0K9U6EH6lzztMFGASq 41yg== X-Gm-Message-State: AOJu0Yw6nofw34gYBKeet/wlsKLb6veBWBSlNXPtB/oqaispaDbc7zFx IPaahaVsbevGUsKLXNOl6WWOLxE= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a81:bd4e:0:b0:576:af04:3495 with SMTP id n14-20020a81bd4e000000b00576af043495mr98619ywk.9.1696524816321; Thu, 05 Oct 2023 09:53:36 -0700 (PDT) Date: Thu, 5 Oct 2023 09:53:34 -0700 In-Reply-To: <20231005072137.29870-1-akihiko.odaki@daynix.com> Mime-Version: 1.0 References: <20231005072137.29870-1-akihiko.odaki@daynix.com> Message-ID: Subject: Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end() From: Stanislav Fomichev To: Akihiko Odaki Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 10:10:03 -0700 (PDT) On 10/05, Akihiko Odaki wrote: > The comment used to say: > > Restore data saved by bpf_compute_data_pointers(). > > But bpf_compute_data_pointers() does not save the data; > bpf_compute_and_save_data_end() does. > > Signed-off-by: Akihiko Odaki Please use [PATCH bpf-next] (or bpf, depending on the tree) for bpf patches in the future. Acked-by: Stanislav Fomichev