Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Michael Kelley <mikelley@microsoft.com>
To:     kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        luto@kernel.org, peterz@infradead.org, thomas.lendacky@amd.com,
        sathyanarayanan.kuppuswamy@linux.intel.com,
        kirill.shutemov@linux.intel.com, seanjc@google.com,
        rick.p.edgecombe@intel.com, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org, x86@kernel.org
Cc:     mikelley@microsoft.com
Subject: [PATCH 1/5] x86/coco: Use slow_virt_to_phys() in page transition hypervisor callbacks
Date:   Fri, 29 Sep 2023 11:19:05 -0700
Message-Id: <1696011549-28036-2-git-send-email-mikelley@microsoft.com>
In-Reply-To: <1696011549-28036-1-git-send-email-mikelley@microsoft.com>
References: <1696011549-28036-1-git-send-email-mikelley@microsoft.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6PR21MB1370:EE_|BL1PR21MB3377:EE_
X-MS-Office365-Filtering-Correlation-Id: fb218858-7da1-4d54-234e-08dbc118bf6e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mUPHgUoH83MYBMMK8yvbfGOxIuuTET1OnWf1aZ1Of89d1oiR4Cmn468l2LRh3ABqS2JIrvwvzeTz8pElA6pd+AJ27531aA/6wqO6/7AqeN+Amy9Ewig1YB6ZmR9XWmjftofSwwEirEkxFWfm6fWgmrJIdhKUzz6JzC7Yd6HBzebHEKSqi7LZVZ66CF7LkTXTbY9Ms+9UwNb69YC4zksq5AjHwn4YjhLEqDOMroHAMkIC8//Mq6HXYC7z7OYH5njwklkB/DRokbyFzLN2tgbuj9OLckpeRgo35RCH56ZCnYGjwdws2jJ07Lb68zxvRnyYZ8YtVDHGqJZHdHoIZXJ8OBg/49Dyxcgww5+G8lVh0WpFiW02E+HjiSSJYtYwKOfCFqy0jw8QVLCl84TMjKorc5zRGDtXyUL+vX2LlljuV6e5AMRYEUXMga6m5xiEPpBSFEQTvR0F7VNG82yr7TN914rGBfgQl4fxqjVQDQi1WJz68qmMAuS5Tq3duFt0UYk2/kPVwEkSk9xSYBsxHhKyFq3SKF9fLOP+r/vRXqp2OV4qWoej0CUiLFgpic1Ocmosq5sXKBurI6jF6hu1wvN93bN8P5g+d47pKEkJUWhCZmDsk10RX0OFxPppAPZMdCJOMCyd6/HXgYFVBYwxsYYlhVO7I0p9nL8a0ogaxK/dm+20BbW3QOpUZ8QN83ns5IBt
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR21MB1370.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(136003)(346002)(376002)(366004)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(41300700001)(6506007)(6512007)(6486002)(52116002)(478600001)(6666004)(2616005)(2906002)(316002)(66946007)(66556008)(66476007)(5660300002)(107886003)(10290500003)(8676002)(8936002)(4326008)(26005)(7416002)(921005)(82950400001)(82960400001)(36756003)(86362001)(83380400001)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JgbRmJ8EAInjrnLV8/uwCDX97hmH7czFClEH3Z0rvZ4siS3I7S24wn5HrRYB?=
 =?us-ascii?Q?9/hIUxFUoLE52RdvIOuIGsFWRR9HsFy31ks5zMBVbFHc5vtziH2WqCoBXVoB?=
 =?us-ascii?Q?zmviF5wz2clvVRfJHjPiVLcEKtPH21uci8wnvTy8eDSHljEHtNdfH87OUdWD?=
 =?us-ascii?Q?ApmtoCid6IJFa7jmbNCqjfWfpqRDn+5/xYebUxwr4Mdk1PiKR9UnsQDVErLe?=
 =?us-ascii?Q?6zg80V/jTn4A+CcvsE6bjor/hw4ZGgnlCYiaagAodzBFkNhoOqG7KfL7Fe6Z?=
 =?us-ascii?Q?b6xA9yzec5208Tc6eaeZ3g100F2l08I3k1OfYhkANQnt0DybMEETIajzw8U5?=
 =?us-ascii?Q?9CfE5l2K9J/6BtaeUYatHf8kNRSSRvV7/KX4uavMACdkZUF4Gm8kuLNtU/vG?=
 =?us-ascii?Q?v2WkUtCUQRLddEjl2ZIFNyAU/mpCx2fvAK0e+zJbJEUfAhmQZn5Cw+Vhp/Mi?=
 =?us-ascii?Q?MqMrlGTaJ+12OdaR3CQK9k2+A7BFxp4mgX/SAlgdifLTG8WwtwCNBCMoRuIO?=
 =?us-ascii?Q?KeD04bNYXWcLcp+9J76gCzlhp58EGfj/UvIl1V3wMJ6Afufly+lwT/WHSZpc?=
 =?us-ascii?Q?3jCyTNSMjX1Zx4aRKENzC+ckubJefSKj0IEYAW4QiLq64LzkPQ3my8rp1IRg?=
 =?us-ascii?Q?PQ5JpALGaqVDUqaz7hSlvk3UsnnhV/lLF6DU81Ir/8oAwt2enqNrdUfBsVEn?=
 =?us-ascii?Q?InnqIkj8T9Rqamhx37V8fZUdB6IqVlTxAqikuUheoys86Gfw4t1Y4CQEpJCt?=
 =?us-ascii?Q?9vtRNobxBwC2Le1wHIvG8XL4eWdpARhyzbn7QjKEFL00k8d4llNtke0NFqjc?=
 =?us-ascii?Q?TYIIr/lSJXccFO7ayKtch8GQ6TSWcKqZxFtOYLkyCODg1tUsqje6pGrFK7qZ?=
 =?us-ascii?Q?tnJ8FJuENUbo2FMQnNZX/qULDVrBTNxQAFx/it0bu94M5O3mU3Ws8DZWhMyN?=
 =?us-ascii?Q?9qy+IlVoayyjMFjYIKgHj3QRk/Wdd/AORvSRgn1QFFGOqRHIkNQh4JQ82unk?=
 =?us-ascii?Q?tRWH2+7V7jWbW0whVA7el36Fgtl8DYfiDr+KsgXWuJ4UwNoFawpFo6q7L337?=
 =?us-ascii?Q?Ebl0KjFQJMpfAzJzFiMuLqlYVcR5lhJMqYEpMQ2uxTCy4iozKFFOUv3cxFPL?=
 =?us-ascii?Q?uYYpCbq9OCKacaTFXMbtrXD4YA51bksNSytAYCHr/cBp1i7WqJdtxDbJMuA3?=
 =?us-ascii?Q?F/tg5f1xZNi+Y+hCVevw91HlVj0Y3H5b73AjYKBh8yKXj0JvkjXgWbhiZnkm?=
 =?us-ascii?Q?A7NgHRgll01cx2sbb5aZdVIDQBLTP4hBdE2WC3Ueot/Yl3E4DoD7jvoYk9x7?=
 =?us-ascii?Q?mUSe5JSepfX3UJgK58ZdKIdsFYYSyZQE4GS+bIBBnU923MT+2cj/TN87Agvb?=
 =?us-ascii?Q?QEp6rYfh2jwQMx89HZHvrZz8w6hcn+nvK3Si0jSEuTDn2Md0y9JPdb+bQt5Q?=
 =?us-ascii?Q?VWvjOCYM8G/S5o3mZsxIusluzPOXCY4kBQWnB1MqE/RPOm2mKkOtG2v+I+1n?=
 =?us-ascii?Q?l8VddH8r//ggUQ3kbsyzVuUCiIwmCVJvhCfm7UHg9dgcecYjszAJGLJYLTK7?=
 =?us-ascii?Q?lrsyi9eTjT/1IEativARqdwG99IOoZl2Wh3wSsB7qwdAY1xNLSrXnJqp3PO5?=
 =?us-ascii?Q?pw=3D=3D?=
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb218858-7da1-4d54-234e-08dbc118bf6e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1370.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 18:20:23.9537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9HkN7j8Cfuex2mmxod46j1H/sjSzSY7izgmBv4voykqZoAzRC5UwUGOIjdJf8PoilC4FcatAMAYDDcx3uHD7Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR21MB3377
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 29 Sep 2023 11:20:58 -0700 (PDT)

In preparation for temporarily marking pages not present during a
transition between encrypted and decrypted, use slow_virt_to_phys()
in the hypervisor callbacks. As long as the PFN is correct,
slow_virt_to_phys() works even if the leaf PTE is not present.
The existing functions that depends on vmalloc_to_page() all
require that the leaf PTE be marked present, so they don't work.

Update the comments for slow_virt_to_phys() to note this broader usage
and the requirement to work even if the PTE is not marked present.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 arch/x86/hyperv/ivm.c        |  9 ++++++++-
 arch/x86/kernel/sev.c        |  8 +++++++-
 arch/x86/mm/pat/set_memory.c | 13 +++++++++----
 3 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index c1088d3..084fab6 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -524,7 +524,14 @@ static bool hv_vtom_set_host_visibility(unsigned long kbuffer, int pagecount, bo
 		return false;
 
 	for (i = 0, pfn = 0; i < pagecount; i++) {
-		pfn_array[pfn] = virt_to_hvpfn((void *)kbuffer + i * HV_HYP_PAGE_SIZE);
+		/*
+		 * Use slow_virt_to_phys() because the PRESENT bit has been
+		 * temporarily cleared in the PTEs.  slow_virt_to_phys() works
+		 * without the PRESENT bit while virt_to_hvpfn() or similar
+		 * does not.
+		 */
+		pfn_array[pfn] = slow_virt_to_phys((void *)kbuffer +
+					i * HV_HYP_PAGE_SIZE) >> HV_HYP_PAGE_SHIFT;
 		pfn++;
 
 		if (pfn == HV_MAX_MODIFY_GPA_REP_COUNT || i == pagecount - 1) {
diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index 2787826..f5d6cec 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -784,7 +784,13 @@ static unsigned long __set_pages_state(struct snp_psc_desc *data, unsigned long
 		hdr->end_entry = i;
 
 		if (is_vmalloc_addr((void *)vaddr)) {
-			pfn = vmalloc_to_pfn((void *)vaddr);
+			/*
+			 * Use slow_virt_to_phys() because the PRESENT bit has been
+			 * temporarily cleared in the PTEs.  slow_virt_to_phys() works
+			 * without the PRESENT bit while vmalloc_to_pfn() or similar
+			 * does not.
+			 */
+			pfn = slow_virt_to_phys((void *)vaddr) >> PAGE_SHIFT;
 			use_large_entry = false;
 		} else {
 			pfn = __pa(vaddr) >> PAGE_SHIFT;
diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index bda9f12..8e19796 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -755,10 +755,15 @@ pmd_t *lookup_pmd_address(unsigned long address)
  * areas on 32-bit NUMA systems.  The percpu areas can
  * end up in this kind of memory, for instance.
  *
- * This could be optimized, but it is only intended to be
- * used at initialization time, and keeping it
- * unoptimized should increase the testing coverage for
- * the more obscure platforms.
+ * It is also used in callbacks for CoCo VM page transitions between private
+ * and shared because it works when the PRESENT bit is not set in the leaf
+ * PTE. In such cases, the state of the PTEs, including the PFN, is otherwise
+ * known to be valid, so the returned physical address is correct. The similar
+ * function vmalloc_to_pfn() can't be used because it requires the PRESENT bit.
+ *
+ * This could be optimized, but it is only used in paths that are not perf
+ * sensitive, and keeping it unoptimized should increase the testing coverage
+ * for the more obscure platforms.
  */
 phys_addr_t slow_virt_to_phys(void *__virt_addr)
 {
-- 
1.8.3.1