Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 5 Oct 2023 18:00:09 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     zev@bewilderbeest.net, Liam Girdwood <lgirdwood@gmail.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/regulator: Notify sysfs about status changes
Message-ID: <f8dd6d53-7c0b-4a89-9ec4-400aa242c020@sirena.org.uk>
References: <20231005133059.917577-1-naresh.solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="SLnAbS/VBTaPciER"
Content-Disposition: inline
In-Reply-To: <20231005133059.917577-1-naresh.solanki@9elements.com>
Precedence: bulk


--SLnAbS/VBTaPciER
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 05, 2023 at 03:30:58PM +0200, Naresh Solanki wrote:

>  static int _notifier_call_chain(struct regulator_dev *rdev,
>  				  unsigned long event, void *data)
>  {
> +	const char *name;
> +	int ret;
> +
>  	/* call rdev chain first */
> -	return blocking_notifier_call_chain(&rdev->notifier, event, data);
> +	ret =  blocking_notifier_call_chain(&rdev->notifier, event, data);
> +
> +	if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) {
> +		name = dev_attr_microvolts.attr.name;
> +		sysfs_notify(&rdev->dev.kobj, NULL, name);
> +	} else {
> +		name = dev_attr_status.attr.name;
> +		sysfs_notify(&rdev->dev.kobj, NULL, name);
> +	}

We probably should filter the events more, there's events for pre and
post voltage change for example which aren't status changes so would be
spurious.  It ought not to break anything but we should still avoid
unneeded work.

--SLnAbS/VBTaPciER
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUe65gACgkQJNaLcl1U
h9DCfwf+LUhbXlkKauGCY8NjdxnbdbEs6qPtGac8GoQu/08ZVd20WijGczYB6m3I
rDeSPqqkkzlC18VK2tWXRk7vjduLLYs8gTWDb1KC60000IKsDj6uI4SpzPq9d7UW
p8dj2XRTOfo+mgvQVD8N7JXDixYNDAafKZema+7Lj3oBdvOaIpiCca430OOUYakQ
WZwGIEcundZ9lietQKUVwXRNhS33htfUlGq9C+nVYi/hk0f8SlXaC0QubuHPiZME
2278Qlh56aIki9vMq7SLWWv1TBnHasAV3BVFINzCfYNaf2sDPFDEKSM4R9zxkv1U
mbWfL4ZlYnuh0ZqS9t3EU71YK87zjQ==
=az4C
-----END PGP SIGNATURE-----

--SLnAbS/VBTaPciER--