Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <0df7f82d-de3b-3e51-ffc1-5aa4e23db62a@intel.com>
Date:   Fri, 29 Sep 2023 09:55:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v3 1/7] selftests/resctrl: Fix uninitialized .sa_flags
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <20230929112039.7488-1-ilpo.jarvinen@linux.intel.com>
 <20230929112039.7488-2-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230929112039.7488-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjRDUElPZC9lVFNDc3JqR3ltMEpNLzFKZHF5VTVNc2hwRnVOcWFEeVpKbmMz?=
 =?utf-8?B?Nkk2S1VGVTkrQUxNNGhpOThuMWoxWDl2NWZ2NUxZREl0enhlY2M5QXozS3Zx?=
 =?utf-8?B?K2drTXRPbzBsd05GZDlHN0xleXMyREtPc3cvdTZLOWZPbmlDM1VOZVZUT2Vh?=
 =?utf-8?B?bjFLRlQxdzNndmM3R0N5T05HSzlSTHFxQUdwRFM5OVVDRDBFSnV2NkdMb0dv?=
 =?utf-8?B?c2gyTk14cDBFYk9FTjJoOU9TRDEyYTEwRWdUTk9WWmVKcE41QzNkZUE5b0k3?=
 =?utf-8?B?dlUrU01MRGxadG1TMkFRTkxBcG04c1dFOXhpbnFSS3BPZjRRMlVmSExIYTRC?=
 =?utf-8?B?UzhRbmswMFVhYjRPQVlQWGpmSDJWdTE4WHl6cUtoeUZBVTg3Z1h4UTFUN25O?=
 =?utf-8?B?aHQrSG1aRlkyWU5lMktYZFk4d2FhZ1YzYkd1SXRZbXdIYkFrNmg2b3o2MFRj?=
 =?utf-8?B?R2kxYiszd1JSa3l4MllJdlJ1dUlSM0ZFaG03NmhGMURlU3JWdXp4N243TEJm?=
 =?utf-8?B?NkdOMVFtdU5iNEYrREREaVQ4YVluK2hxdjNGQmhRYkEybTQ0azBLU292a3o3?=
 =?utf-8?B?Qmo1RnprNzQ2VHBjTUE2dlgxWGJhYjdkeG5zVG1HZ1JzZ2ZYaFMyNENhalRQ?=
 =?utf-8?B?enRoOTg5NzJ5S3phMzNrRWZpVHBMQ0hKQ1ZjSkc2OVRzYjFSc2tkN29YL2NN?=
 =?utf-8?B?T291c3g2dlRETHBNTk4vQnVpSThzVExDYSsyeDd0cHdRV2VnMWVUc256bita?=
 =?utf-8?B?SS8xaTRIVnBhTWljaVdHenhsb2FBSmk1VzBWNEFGVjZ0MEFmcVU1N1VMNnph?=
 =?utf-8?B?Y2NPTERyb1VrcnBnYmZ1QU03V1BNbUwyclp2ZElqbFFkS09oWHVQamYxUmtx?=
 =?utf-8?B?Q1F1OGZWSnJ3OFcxaTNRYzRrM1VXM3UvaHNlQVZPN2NJaTgvNXByQUdXWnpJ?=
 =?utf-8?B?SDBLdzh3QUljSEhJdmttU21hQ0NUeTIvQ2RWOEM0WkFKem1KRGZIQzRmL29w?=
 =?utf-8?B?bEFIY2ZHbWw2eEZwVWRnYkl5eWxDeHN1Z3RIR0N0d2tZVzM0cHF3K1g0YXdy?=
 =?utf-8?B?Rm5tdndIYy9KTVJhcXJGeGo5SkJ1Z1lsYTV2UDhBbCtVUWd0L242KzVHKzda?=
 =?utf-8?B?L2VudjQrSnB6eTJmcEFMUERkMVpPaFc3UGcvdmJ5T2FNaXdHbSsxVFJKaUp6?=
 =?utf-8?B?cFhxaGdRanl0V2hGemc3d3BXWERzdTJBKzJZbEVuRjVtUXBYcml0RUltZGVn?=
 =?utf-8?B?dkNHVWtHR0R2NlBQRlNBcmk5WjhUNWVTMUVlWFZPdG4wNlk1L09BR05UM1ZE?=
 =?utf-8?B?bzdzRXEvZVcvNExyd0hjVmhtNDlvb0tLenhlbUFyUkNjNk51eTBlZGlIQmZl?=
 =?utf-8?B?V1pqVTE0VThWMmo0QXlaTDhHU2xkM1FXOTlQV0h6c2FGbzRFVG00bk5VV0Vr?=
 =?utf-8?B?SEJ3ajduRFpQTlVaK3VzRVdoMzF1OWs1S0c4Wlhqbnc2bmcyTGUxSC8zOGpt?=
 =?utf-8?B?L2tDd3ZlaG0ycm5IWFErUEtMYjFHbU1XeXc0RmlWeVI4TVZ6NDNBb0VObjUw?=
 =?utf-8?B?NmZkOUhRWlRNeTVOMUhDd1FpOTlNNEx5KzdmSE1jeG9BZ1BUWlo4eW1JNFNL?=
 =?utf-8?B?eC8wK1NaMy9zMDVlVFdiL3FDTjZ3OEsvc2xKUXVYaEd6ektCRnY0QmZHM05n?=
 =?utf-8?B?bnVqVkdjT2pBOC9xdzZ2VmxrK0lBNWZDemo2c1JGdGFRUGxBbllIRkg3V0lz?=
 =?utf-8?B?enI5WE5CUEdpMGtlOFFxak8rWi9SOWpncnJqdjN5MDI2Rno5OTM5cmxNRmlo?=
 =?utf-8?B?Z29EKzhTTms4SmtKM0hDRTJMN0U3S0lWb2hFZ2MyZ2w3TUZYRGVxcmoyRjRw?=
 =?utf-8?B?UDJvclJ0R1ZyNld1T0xXVDd0VVF4UnM5aUhmZ3pmeFN6aUtVeS8yeHNTV1Rn?=
 =?utf-8?B?Z2hreXJmL05aaUFjem01QzNLOGxmTFJOaENMcWRTVTA0MFl1WWdPeDRLQ2l6?=
 =?utf-8?B?dUpGZVNTQlljbTZOSWV3VXNtdU5pcnpnNFJOVmhWa3g4Qm9SWGpFSjlpRG5w?=
 =?utf-8?B?MCtlRFAvanRPOFQxalZRWUJXSUFlK0lkdDBMZ1JwMXE1TklyajhxSGF0Uk56?=
 =?utf-8?B?NHZsdXJhMmZ3OWt1N29IcVhkbXY0M0l4MTVNd0JVMkZ6OVBrcnJtRXl4QTNo?=
 =?utf-8?B?dmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 636549fa-77cb-454c-c80f-08dbc10ce0ff
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 16:55:26.3035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6ULDixK3JkBqpNZi1QRK4rblfuM6sFuSc/l2g06RbxDL1u6dWzUVB9V/1mB+57vgM80X/Y8maW9B5g5DHe6UL9x0AabC3wvk9yrfmumWgaQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6269
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 29 Sep 2023 09:55:58 -0700 (PDT)

Hi Ilpo,

On 9/29/2023 4:20 AM, Ilpo Järvinen wrote:
> signal_handler_unregister() calls sigaction() with uninitializing
> sa_flags in the struct sigaction.
> 
> Make sure sa_flags is always initialized in signal_handler_unregister()
> by initializing the struct sigaction when declaring it.
> 
> Fixes: 73c55fa5ab55 (selftests/resctrl: Commonize the signal handler register/unregister for all tests)

Please place the title line in quotes (checkpatch warning).

> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>
> ---
>  tools/testing/selftests/resctrl/resctrl_val.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
> index 51963a6f2186..1e8b90077218 100644
> --- a/tools/testing/selftests/resctrl/resctrl_val.c
> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
> @@ -504,7 +504,7 @@ int signal_handler_register(void)
>   */
>  void signal_handler_unregister(void)
>  {
> -	struct sigaction sigact;
> +	struct sigaction sigact = {};
>  
>  	sigact.sa_handler = SIG_DFL;
>  	sigemptyset(&sigact.sa_mask);

Could you please add this initialization to signal_handler_register()
also? I understand that the particular issue of sa_flags is not 
relevant to that function but there are other uninitialized fields.
I think initializing the struct makes the code more robust without
needing to reason/understand glibc behavior.

Reinette