Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <7b793937-ab79-48be-8f82-4bfcfc464045@intel.com>
Date:   Thu, 5 Oct 2023 11:04:27 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 02/24] x86/resctrl: kfree() rmid_ptrs from
 rdtgroup_exit()
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-3-james.morse@arm.com>
 <9606020e-c322-fb6a-a6ca-96ade7aecf17@intel.com>
 <550fe399-8904-c515-f556-3536ebe2e9a3@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <550fe399-8904-c515-f556-3536ebe2e9a3@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnFpZmdVaTNCQVl6cStoSzgxWUorZW5ER2N4SklPYjFjOVFzeEtjTHdCTXVK?=
 =?utf-8?B?eFZWazVBTVZWU3lPVWJuQktnR2ZGMWw1dis0bHlqQjhId1RtMlgyUHE3SUtB?=
 =?utf-8?B?bHRFTnNFNDFKVi9nci9NQ0F1ZEVsODdUbzRLYXlYNHI3eVhXWnpyVHh0QUJW?=
 =?utf-8?B?NnAybFJOZVVWNWFXMElQcDR6TDZiUXpaTnVrSjh6cFNHUXFwZ2VDR2k3OW5I?=
 =?utf-8?B?UHdvdHNHbklTQ0szV3lxRmpsUmVVaDhhVk51QXVFQnFqM3lpMkJVZmk4dUFz?=
 =?utf-8?B?VGZFUXQwUWNPU3N4cTFhbnl3Z3RheDd4MGJwYUNhVmVMckpZWlVTTldWcDNx?=
 =?utf-8?B?ek1adGFnUGdNUk9VNzBaSExPWm5VYVRranJWSlVjN1VQaG1MZlRMempEN3E4?=
 =?utf-8?B?ZUlKaTRHeU93SUpDN2pxaUJWbmttUjEwWVhKdDJpRHJHMm1ZUFZZbkNRK2Nl?=
 =?utf-8?B?K0lsMk9ZYWNqOHl4YUxNeWR2TWo3R1JpLzRmNitWRFdIRlY5dGpHTTRpZE8x?=
 =?utf-8?B?cEtNVjZWTlp4MkxhcElMY0xUR0YxWDdPYytsNTRXUEppOU1JQ0hiUzB0RnhS?=
 =?utf-8?B?YkdpUnd4WVZHenYwTzNpUVBuNEF2b3orajgwZE9nUmsrMUZ5S2ZITkdQVmtr?=
 =?utf-8?B?ZXNDRHNUV0ZxaDIyS2NHOHh0QUQrQ3FLemlaZm1sbnFiOWlvalRMUzk3bHZr?=
 =?utf-8?B?MGlETXJWc0UwT0krNXlHV1N2d3dnWXVhNjNyNTV3aHVTbEdYWnhkcjhIdXl5?=
 =?utf-8?B?N0xpdGxNaEVvdDRqai9MVk5DNXFXMG1HazhRK0c3WFpNNDZyYUh2dEZGMGkx?=
 =?utf-8?B?RUZwemorZGR4bG1xcjJZY2dEM0tOU01MUHQ4empMUHVSOEQxbVZ3bmUybmoz?=
 =?utf-8?B?c3dkaU1TaFhYZURCVEdGWWNLNjZnNllXZi9LWkNVVWg1K2xLT0FQZjlLMndL?=
 =?utf-8?B?amlrL1gvNG8xQ1RYQkxXK0xKWVp4QW5tSWZyYmE1Qi9STVBGaGlRVC8xdUND?=
 =?utf-8?B?Q2tseTEvMzdBQmtNQlJWMjJSMHVqOGNzWFFzWkMvbEZCMm51emVmTHlFclZC?=
 =?utf-8?B?VkNseXUzRk8vbC90QzJBY09SdnZDMUcrajNCWE1jN1kxb2VDYTVOWCtUVjNJ?=
 =?utf-8?B?M1lVSWJ0elp5TDBhT0M0cklqcEFPYjBrcEk4dTFoY3pSSDAvWEx5bk8vMG5D?=
 =?utf-8?B?WTBWdjFZUEp4dmVpd3hPSm02aXV5a3hHYm56cWh5Y1dvbHZOdkZodHgvVGIr?=
 =?utf-8?B?ckRJcHZzYndOblZ2Mk9ySkRTeTFuZXNDT28xODVHR0twMXB3TitxeVdhenBY?=
 =?utf-8?B?aUJad3RCcXc3MVdmUUxwQ3RjaHJ1ZGVzbG9OcnlDV1lLdk94Y1FKQ3JRRkY2?=
 =?utf-8?B?V0J3Q1dRZ3Q3bElRUXBjNW1Yem4xVXQ3K0Fva3JXbVNFMEFpUnJpMzBrQWEr?=
 =?utf-8?B?THQ1czFMTGNXekpzMGhHdTdqTHRBbFArZmhBdlQ5NmljbW9jeGt3cGJCVW5P?=
 =?utf-8?B?RUd4L2hjc3lFSGw4RUt4aGswMVVnbXU4c3ByVmx3YXRtQ2Z3VjY5dTI3cGJ0?=
 =?utf-8?B?elFPS1B5U0FzSFRnOVZ6anM5YXNKcnhsRmw2bkJrejR3VDdLeGlsditLcnBI?=
 =?utf-8?B?WnNiWTRsZjQwSFJha1RsZTN0RGdhdjRnVUVVS1B5YWhZSStXbWFwSURvS1hp?=
 =?utf-8?B?V0t3a2NVRWJxUWNHZVhpNlp1VTVFS2hsTCt6MjJXWGVqSzRXem9IVGp2Z1Q4?=
 =?utf-8?B?cGdBaHZIUURWWWY5OWt6L1Buakc4V0ZrU3R4UFg5YlpBbW9JTEhzdDVPYnl3?=
 =?utf-8?B?bmxNNkUyODByZm95UiszbVhrVnBPVmdqODVoZXhHNStqQmtQZVp3N2g4cjJB?=
 =?utf-8?B?RmN5aWQ4T0lMWEl6Yms2NFV1OUJHajd2QkZwUE1ITWpEQnpDRDY4dCszTXJQ?=
 =?utf-8?B?QkIxWmE5T1ZlaithcXgvcUZ3akRGaXNVd2lnd1A0cXMyclJES2ZvdkVIaVFH?=
 =?utf-8?B?NjNyekNjZE1FOWFCSERYUVhLR3dicENVUHB3MFdHby9uazhJcGxhL2lrWlRK?=
 =?utf-8?B?WEQ5U2FDRkJKaDRvUTBjWWdZS3NOekVKRnAvbU15N1ZWSVJCcVNTSlBTVUV6?=
 =?utf-8?B?MzQ2eEpDbURqa1B6NisxSWRMdkhHSGtsc0lweGRYVkUyV1UzZWFLaDNDVDNs?=
 =?utf-8?B?bXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06f4a58c-6d83-40f5-3135-08dbc5cd85d3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 18:04:30.8996
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zXeQSQuN5yuyy+mTyrQAwaby+NpZIl2T6ailgIeBrfPFOhW6QWwxM5CnOT8Ii36rkKvfxNJ9nBXjiOwDU1ki6J01F2rNekGwGcfLi5yQhas=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7904
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 05 Oct 2023 11:04:55 -0700 (PDT)

Hi James,

On 10/5/2023 10:05 AM, James Morse wrote:
> On 02/10/2023 18:00, Reinette Chatre wrote:
>> On 9/14/2023 10:21 AM, James Morse wrote:
>>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> index 725344048f85..a2158c266e41 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> @@ -3867,6 +3867,11 @@ int __init rdtgroup_init(void)
>>>  
>>>  void __exit rdtgroup_exit(void)
>>>  {
>>> +	struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>>> +
>>> +	if (r->mon_capable)
>>> +		resctrl_exit_mon_l3_config(r);
>>> +
>>>  	debugfs_remove_recursive(debugfs_resctrl);
>>>  	unregister_filesystem(&rdt_fs_type);
>>>  	sysfs_remove_mount_point(fs_kobj, "resctrl");
>>
>> You did not respond to me when I requested that this be done differently [1].
>> Without a response letting me know the faults of my proposal or following the
>> recommendation I conclude that my feedback was ignored. 
> 
> Not so - I just trimmed the bits that didn't need a response. I can respond 'Yes' to each
> one if you prefer, but I find that adds more noise than signal.

I do not expect a response to every review feedback but no response
is assumed to mean that you agree with the feedback.

> 
> This is my attempt at 'doing the cleanup properly', which is what you said your preference
> was. (no machine on the planet can ever run this code, the __exit section is always
> discarded by the linker).
> 
> Reading through again, I missed that you wanted this called from resctrl_exit(). (The

Right. And not responding to that created expectation that you agreed with the
request.

> naming suggests I did this originally, but it didn't work out).
> I don't think this works as the code in resctrl_exit() remains part of the arch code after
> the move, but allocating rmid_ptrs[] stays part of the fs code.
> 
> resctrl_exit() in core.c gets renamed as resctrl_arch_exit(), and rdtgroup_exit() takes on
> the name resctrl_exit() as its part of the exposed interface.

I expect memory allocation/free to be symmetrical. Doing otherwise
complicates the code. Having this memory freed in rdtgroup_exit() only
seems appropriate if it is allocated from rdtgroup_init().
Neither rmid_ptrs[] nor closid_num_dirty_rmid are allocated in
rdtgroup_init() so freeing it in rdtgroup_exit() is not appropriate.

If you are planning to move resctrl_exit() to be arch code then I expect
resctrl_late_init() to be split with the rmid_ptrs[]/closid_num_dirty_rmid
allocation moving to fs code. Freeing that memory can follow at that time.

Reinette