Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp512110rdb; Thu, 5 Oct 2023 12:25:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0PV4WIRCxbm3T3cacMwyraHBQosFf5j6uZSPXF7EyayIQObXJAnf84JTUEiLO0aQyUT92 X-Received: by 2002:a05:6a21:33a6:b0:15d:1646:285a with SMTP id yy38-20020a056a2133a600b0015d1646285amr5194415pzb.21.1696533914598; Thu, 05 Oct 2023 12:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696533914; cv=none; d=google.com; s=arc-20160816; b=zwHdw+qw5IcNvgilwtJ7XTE5uwLkregYoV4HcF2T+mhqJVPVCbZNsCQcAiK/WTykJY uP6SpaeXWt5VbZNaJIHymTgkA488JfBg4FCilCE3bX9xBxwDrdRPzolm8GGhEa0JooyS KhYPCOmRyWAhEKcfiYks7puBDTvFBAiOjUS5Cke1GPwE28+kDvdB/6F9wNBqF/OVB7sH nJl1J/2lLqDdMi/fyIT7XoxwkR0hW+k+zhVRVfpvN8EP1LN9gxCMhWJk8rP6OL809pIx XPLoxjAjKlbbkVkHu84zgSEQhVYdacH3VfZxZ4kFgyWrCB07ISROrq7LEwgJlTB3bS0O RvAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Eh6I++W8dr2E/fFHjBPO19b3/O+RIh9dC9Qrk5i3ZhM=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=AH6sqjxlbPCWSo2b87jaq9YyAUTQtn7xoJ99Li35YTNqAuaeXnaAkwr9t2LMFgAFTf xx73ciOBKqxwmvFESDCEVIBxwg4v7MZH/OwUYiguaAvWRyFoCvtBqZl4u+77CpB/hUn6 VhRUjlI4AfJrJizDUlRRWhjyig2hl3/No17m+rRUhIUpOAwLASHRuxzgn48YXQxWd3NI 60yK/ofWXsCVkF8ZGh2Fh7n6bnjQHj/znGFzQLWameD3H45mUd30FzCZqv23LkhjdMS9 Iyg7xDQkRRBhVdwM485nCO4Rf4319RixPSTHdDa0COKD4VzMnDz9MQ/YbbjGUv2FusJn kDOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id cg14-20020a056a00290e00b0068a3c575900si1895947pfb.84.2023.10.05.12.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 12:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 737858032BAF; Thu, 5 Oct 2023 12:25:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbjJETY5 (ORCPT + 99 others); Thu, 5 Oct 2023 15:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbjJETY4 (ORCPT ); Thu, 5 Oct 2023 15:24:56 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D08AE5; Thu, 5 Oct 2023 12:24:50 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id BA0347A0319; Thu, 5 Oct 2023 21:24:47 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Date: Thu, 5 Oct 2023 21:24:37 +0200 Message-Id: <20231005192440.4047-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005192440.4047-1-linux@zary.sk> References: <20231005192440.4047-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 05 Oct 2023 12:25:09 -0700 (PDT) There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT); -- Ondrej Zary