Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp512699rdb; Thu, 5 Oct 2023 12:26:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcidSwOcSG923ymqAojHYvkVCemG+jsPM1YKYyv1fxKk6+LZkV6rD2kcYZ0ZG+etcxtNGb X-Received: by 2002:a17:902:d4c5:b0:1c5:6f4d:d6dd with SMTP id o5-20020a170902d4c500b001c56f4dd6ddmr3598097plg.24.1696533994900; Thu, 05 Oct 2023 12:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696533994; cv=none; d=google.com; s=arc-20160816; b=1Db3U3O3iom87K0CrDpG3kqpONnU1KADTww5vV9aspAqJXsPk49LOBZ7FDpn4RHBS5 /pES+eN0kFxnBjZcyatItXeVQW864OqDaWlqWvHHDbI8NcjksOiff7PUJw59d+2I2saG XUH684gJhypvgpXIqBKHG8qHM/pMIEjroNb67+7/XaGKfCvgXj4PwKmD6ceQ6JEOjxWh OsKuRcmia7BpHFWLe1CoKhFhG+XdnBFhvDiulgECCLvTIZ94sC+b/GlzaxlUYCZ1oTCS f1HQtKqw6m/JkqM3uz5Y0bbkyODGWDcriOcelq7oMicnixswLqK/TB7jVSbV/BiTSue2 6rMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=grUvpBwYDT8m4Aw6ftqD5vHCRUwZ5ebMRcgc8wGnAns=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=r7Nnk39PkRBiD1k7NrbU0I7svlzEUP9woxNU5wDMDANLQtH1anFXMV5PyiVAruHWsz aBQYjYuD9SKErXOnzcB7kj1FpLf6yJkJSAByVvqn624kuIqdVSw4S4PyrytZfgVMm/BP kLHlEYuFJ/weHiY+xk5RPZIVZ3/FNKfy6yx5Jdc8Ck5bXcJ/RbKZMTpuogmEv/owawWe 0pu1MbY/I9NyKbACO/N9PcKfjY6ozAMu9MNox2lonhnzzbHVDHPgoWrXz5v+qAPZ967x qPc0vuuK3foWi7c2Y4+usfp+t1fnArQgbqCALn/2QNdaRwXvWLmyubIUM5bwivJ2lOub hy0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id c2-20020a170902d48200b001c71eb782c0si2147499plg.464.2023.10.05.12.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 12:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 61BBA805904D; Thu, 5 Oct 2023 12:25:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbjJETZA (ORCPT + 99 others); Thu, 5 Oct 2023 15:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbjJETY4 (ORCPT ); Thu, 5 Oct 2023 15:24:56 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2BAFDDB; Thu, 5 Oct 2023 12:24:50 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id CE82C7A0430; Thu, 5 Oct 2023 21:24:47 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] ata: pata_parport: implement set_devctl Date: Thu, 5 Oct 2023 21:24:38 +0200 Message-Id: <20231005192440.4047-3-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005192440.4047-1-linux@zary.sk> References: <20231005192440.4047-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 05 Oct 2023 12:25:33 -0700 (PDT) Add missing ops->sff_set_devctl implementation. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Reviewed-by: Sergey Shtylyov Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/pata_parport.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 258d189f42e5..cf87bbb52f1f 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device) ata_sff_pause(ap); } +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl) +{ + struct pi_adapter *pi = ap->host->private_data; + + pi->proto->write_regr(pi, 1, 6, ctl); +} + static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) { struct pi_adapter *pi = ap->host->private_data; @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = { .hardreset = NULL, .sff_dev_select = pata_parport_dev_select, + .sff_set_devctl = pata_parport_set_devctl, .sff_check_status = pata_parport_check_status, .sff_check_altstatus = pata_parport_check_altstatus, .sff_tf_load = pata_parport_tf_load, -- Ondrej Zary