Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp551075rdb; Thu, 5 Oct 2023 13:56:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEM1QPT5ih8MkYkspLsBbvz969UtL1t9rAjhKQqq1bh1nV1VCKcbJgVjvYySq4mHO280M32 X-Received: by 2002:a17:902:cec6:b0:1c8:7d41:5b8c with SMTP id d6-20020a170902cec600b001c87d415b8cmr5387280plg.32.1696539386235; Thu, 05 Oct 2023 13:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696539386; cv=none; d=google.com; s=arc-20160816; b=PfeCeApo23eU4RwfaKz9Y8owsLHdLcP7ZdvYSzgPqk8YC0qgtEMBSwL4HsAZ9VwwOQ H20OLQNqRmjK8pxN/SczfZcMNJJK7HYLjIMeIy0NuQRnb21DGFFXM97HUtQXeDNqtCfY IKOUVSxw2ja4JTaEzZpoo+6vYroibmTTAAgQqUZntdVhjrHESboDXA3NhqJhu/NHtWkb UJAhk7kxipQX9KAC3j20cNydOXppA7NzB/p0d6mmJqLuMhiQct6YmoJt5e2Y5MCH8fas MV1AlOT5wYNyQ7zLjEkySTwhgAVwDTnsbbkqhVM0u5bHyNykP55zBOkzYFh5+eaS2sR/ /m5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7P2SxlyPBbfA+FeABtKIEP+MsuGzRfiOYNXgiytXVjU=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=Xs6d2JmBd0piTsPoUDXs2W1DonaMSDAuxivno9Eqi9vnmn5nnA0i+MTw6gyNdaJbh6 gqDbl3milGNV2OLM5rwHP37l9Xi3NuVH1no/it3OAZa8Ld2ftMx0wl3/gTPnmRD2RteF 02PmMX/abYVM8gJufh7Enw5Lkcylmu3FfHBZQTzwd72gRF6zaxvwojHQfadQg0Ja7tXC s23Dbon9ViEa7en2zp8S1/Mz6wrAjSpgBBlmAMVrhvsjMiASfpYZ5HgcZEuz/C8K7txk SU1H2U8ADmsNxTf0uu3QdyO9k2opAEAzCqjV3CdSqOqH9zlIHsV/fl3AuQK3F2/oMdhT X/BA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id kk12-20020a170903070c00b001c4621ac000si2131539plb.246.2023.10.05.13.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 13:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CBDA18080E2C; Thu, 5 Oct 2023 13:56:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbjJEU4K (ORCPT + 99 others); Thu, 5 Oct 2023 16:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjJEU4J (ORCPT ); Thu, 5 Oct 2023 16:56:09 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E18C9F; Thu, 5 Oct 2023 13:56:07 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 95EEE7A01D5; Thu, 5 Oct 2023 22:56:06 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ata: pata_parport: fix pata_parport_devchk Date: Thu, 5 Oct 2023 22:55:56 +0200 Message-Id: <20231005205559.6504-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005205559.6504-1-linux@zary.sk> References: <20231005205559.6504-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 05 Oct 2023 13:56:19 -0700 (PDT) There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT); -- Ondrej Zary