Received: by 2002:a05:7412:518d:b0:e2:908c:2ebd with SMTP id fn13csp551130rdb; Thu, 5 Oct 2023 13:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHueqp6+M9qvw32qUV+cD9CqTOT+tt2DnP5e9KIOvkBUC7Dn7WtDdt/tLpl/PLilGHK7s+0 X-Received: by 2002:a05:6808:18a4:b0:398:5d57:3d08 with SMTP id bi36-20020a05680818a400b003985d573d08mr7640646oib.37.1696539396455; Thu, 05 Oct 2023 13:56:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696539396; cv=none; d=google.com; s=arc-20160816; b=YQ+931pOo5zxk9EVfHGt5YTaebcyj3gnTkGSpTK/KbVi7i45JJHDPSpYWx3Utgqynp DDAO6HrQL3YVzv3uzRGAdAobynmEu0+v8igMZIrqc08BPfmPukwarxmD0bFK/6d6xhb4 0ld5o9gr2B4jtZvopBcKMnAsLDpGGJJIWP4bKDreNenzAaGon1G0kfGUq9qvFUTVO8OQ 76p3Fa9yeGAbLoeE9iglQ9ehwRN+vLDvci0ZEDVvHfGYT/TyFcOP9amM8ImRHEY4xmsU n+Z8D78b9R/xQjLPEELKoXHZau1E6gpykvZgd1S6LghAZdpcLwdp8YLxvKboVnGq1ej5 +UfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ojMs5e5+vivdenL0B4z8IB/laNKWeerQnh4larZP0Yc=; fh=0Kn3fvtcnx6vVXAlmep6T/Q5RzgM4nGjbgzeaq8HuW4=; b=MDSF2D/OMSlzUb+bAGv/9//wtmm9L6zsqWPJyBmDZdFMqB1g7Fsq2eWgpvTj1r5KTA oXOl2UK/DVigoTXHfvM84dTsUxVcGMcwDWxEpxcF2XOQntyIqv2b4cTfeAqAjDrxO5eB 9s2/tgv2kB5rQu1rLxpo0vEEpPwPSRTohZx9JDONWfvQgIxAa818qof1gA2bqofsQqFW lKZB86a9x+zMHNw8YJc5YfPqaoMOjf57bTturgxvehPAlV1QodUSJY/CqJpT6Lv2jy84 obDzX5ypPMkfVJ20u7EObe3HZB7f9lUkYqwJESsj3IzpZo4PzYCdBFdtL5kk+KB2630B e5DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id bx29-20020a056a02051d00b00588d84b1217si2594567pgb.415.2023.10.05.13.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 13:56:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 596FE8077914; Thu, 5 Oct 2023 13:56:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231712AbjJEU4N (ORCPT + 99 others); Thu, 5 Oct 2023 16:56:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbjJEU4J (ORCPT ); Thu, 5 Oct 2023 16:56:09 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCC06A6; Thu, 5 Oct 2023 13:56:07 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id B82437A0430; Thu, 5 Oct 2023 22:56:06 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Tim Waugh , linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] ata: pata_parport: implement set_devctl Date: Thu, 5 Oct 2023 22:55:57 +0200 Message-Id: <20231005205559.6504-3-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231005205559.6504-1-linux@zary.sk> References: <20231005205559.6504-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 05 Oct 2023 13:56:34 -0700 (PDT) Add missing ops->sff_set_devctl implementation. Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/pata_parport.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 258d189f42e5..cf87bbb52f1f 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -51,6 +51,13 @@ static void pata_parport_dev_select(struct ata_port *ap, unsigned int device) ata_sff_pause(ap); } +static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl) +{ + struct pi_adapter *pi = ap->host->private_data; + + pi->proto->write_regr(pi, 1, 6, ctl); +} + static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) { struct pi_adapter *pi = ap->host->private_data; @@ -252,6 +259,7 @@ static struct ata_port_operations pata_parport_port_ops = { .hardreset = NULL, .sff_dev_select = pata_parport_dev_select, + .sff_set_devctl = pata_parport_set_devctl, .sff_check_status = pata_parport_check_status, .sff_check_altstatus = pata_parport_check_altstatus, .sff_tf_load = pata_parport_tf_load, -- Ondrej Zary