Date: Wed, 14 Nov 2007 13:00:52 -0800
From: Randy Dunlap <rdunlap@xenotime.net>
To: Roland Dreier <rdreier@cisco.com>
Cc: Julia Lawall <julia@diku.dk>, rolandd@cisco.com, mshefty@ichips.intel.com,
       halr@voltaire.com, openib-general@openib.org,
       linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/infiniband: Drop redundant includes of
 moduleparam.h
Message-Id: <20071114130052.8118c397.rdunlap@xenotime.net>
In-Reply-To: <adalk90zgwz.fsf@cisco.com>
References: <Pine.LNX.4.64.0711132234110.18337@ask.diku.dk>
	<adalk90zgwz.fsf@cisco.com>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 20

On Wed, 14 Nov 2007 12:54:52 -0800 Roland Dreier wrote:

>  > Drop #include <linux/moduleparam.h> in files that also include #include
>  > <linux/module.h>.  module.h includes moduleparam.h already.
> 
> Do we want to make this sort of source code change?  I thought that
> the consensus about the kernel was that we wanted to avoid relying of
> implicit includes of <Y.h> by <X.h> -- in this case a better change
> would actually seem to be to explicitly include moduleparam.h in files
> using module parameters and then remove the include from module.h.

That's correct AFAIK (what Roland said).

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/