Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231004222323.3503030-1-irogers@google.com> <20231004222323.3503030-2-irogers@google.com>
 <173829f3-817e-4937-808f-7f9bfc22207f@isovalent.com>
In-Reply-To: <173829f3-817e-4937-808f-7f9bfc22207f@isovalent.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 5 Oct 2023 15:03:12 -0700
Message-ID: <CAP-5=fUyDUV_XzaTKF4V5h5yzkqtM27AfK2qRTncQiAryHHYcg@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] bpftool: Align bpf_load_and_run_opts insns and data
To:     Quentin Monnet <quentin@isovalent.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Yonghong Song <yonghong.song@linux.dev>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 8:54=E2=80=AFAM Quentin Monnet <quentin@isovalent.co=
m> wrote:
>
> On 04/10/2023 23:23, Ian Rogers wrote:
> > A C string lacks alignment so use aligned arrays to avoid potential
> > alignment problems. Switch to using sizeof (less 1 for the \0
> > terminator) rather than a hardcode size constant.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/bpf/bpftool/gen.c | 47 ++++++++++++++++++++++-------------------
> >  1 file changed, 25 insertions(+), 22 deletions(-)
> >
> > diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
> > index b8ebcee9bc56..7a545dcabe38 100644
> > --- a/tools/bpf/bpftool/gen.c
> > +++ b/tools/bpf/bpftool/gen.c
> > @@ -408,8 +408,8 @@ static void codegen(const char *template, ...)
> >               /* skip baseline indentation tabs */
> >               for (n =3D skip_tabs; n > 0; n--, src++) {
> >                       if (*src !=3D '\t') {
> > -                             p_err("not enough tabs at pos %td in temp=
late '%s'",
> > -                                   src - template - 1, template);
> > +                             p_err("not enough tabs at pos %td in temp=
late '%s'\n'%s'",
> > +                                     src - template - 1, template, src=
);
>
> Nit: This line is no longer aligned with the opening parenthesis.
>
> Other than that:
>
> Acked-by: Quentin Monnet <quenti@isovalent.com>

Thanks! Nit fixed in v5.

Ian