Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "hawk@kernel.org" <hawk@kernel.org>,
        "alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
        "ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
        "linyunsheng@huawei.com" <linyunsheng@huawei.com>,
        "bigeasy@linutronix.de" <bigeasy@linutronix.de>
Subject: RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag
 allocation failure.
Thread-Topic: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag
 allocation failure.
Thread-Index: AQHZ9zG5Q7UiKD4OcE22U5AhDIEc4rA7Ya2AgACw6UA=
Date:   Fri, 6 Oct 2023 02:55:38 +0000
Message-ID: <MWHPR1801MB1918374240CCD63E6F4B8DC4D3C9A@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20231005021434.3427404-1-rkannoth@marvell.com>
 <20231005092145.08cc84fb@kernel.org>
In-Reply-To: <20231005092145.08cc84fb@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m0mMpN1eu5KnikSsk7G3FyqZMtO8r97Eq2tTBCdG2ibj2y7w7T5LzEU4vtCS?=
 =?us-ascii?Q?t8VVdOTQ7orJ7bn+iD4tVyi4TDElh6CgsxpNl34XWfRWs58yYFqFA2h6o7zV?=
 =?us-ascii?Q?4z4/HaAU4uy5gFmcyfebmOXUnDZaSiL/Nho9CTiJ9k44CmrBcCGjyoIfE8ta?=
 =?us-ascii?Q?LiFsKvdqiHZF3og3GceF7FYYU22FUH4qkqFHtgZFguwnkYynM0jPL38izVM9?=
 =?us-ascii?Q?sobpXjBmmINGi6Zomt0VebmywkXO/AfnHemkHiPaoXRPkgiI+v1S8vD1nbPw?=
 =?us-ascii?Q?6qjub6vXrZLWcOUpJURkhJcTiOEUSipTvezkfxtXtLM0HNFvCraYIp2JekWp?=
 =?us-ascii?Q?hh1/vYCb1yxGLvdelR0iGwaoMgOtSHf7+QGINdElzI5lZWYl6ovxL8LAg8L0?=
 =?us-ascii?Q?IYp/2X1Ztz/YToSq7EnTOLWxb/aEGWIYxyBDrEDAMYjpjY4q+I6mQqmsE3C/?=
 =?us-ascii?Q?A6uD3QB/VuUJB1jxD0OlN78T8nTN1ZaVRl0KoeRwWQoypEs5TGNJ9BHwhwVo?=
 =?us-ascii?Q?0pWuy/9Dj81n0V4Z4GsX04eZa+pdqg4JnJ1pZRAcXCcpjZxtxvXCRESV6CW9?=
 =?us-ascii?Q?WiC8cdm+0iQR4ANTBBvw+LpLeRai1w+P/YqeJzv0YEV3/hapl21UJfMJpCqj?=
 =?us-ascii?Q?qD+9cCxsUlwkESt9BDwcZ2c/uIe8I2fa+X/Z3fwE+1XRv1sVfIbjhGKiVrVF?=
 =?us-ascii?Q?829vMUwUUN+JSgietiob9B+NPQI924vA14/Z4fR6WRTEuXUI4VcNmLprunhj?=
 =?us-ascii?Q?SYT6fXlyYKFPcCqCPiZhkRy4RoRtsvDm2lKj/IyiK6nvO3hO+X3K0n1qofFT?=
 =?us-ascii?Q?waCxzBJ0MHG8ZSGP6sqJqyBfxjSz8H1Iyjaevgut3GT8z+DkzWfPuEiL45tp?=
 =?us-ascii?Q?FAFiufVbejmCmXGR02BVM5qaWC3rDu/PRXQqvx/9Q30FLWDhJ8Czbw950pC6?=
 =?us-ascii?Q?/8LM05L2AJdc/G3zDQzGvEkNqzF0orTUQ+498dC37q0QE+KUdJB58dW+/buQ?=
 =?us-ascii?Q?bZSoxRYZmVE6mEmQ8A9VOHzLraLsdyNC/plsqI0zhAUPHxFkeO2YpdxHiK/Q?=
 =?us-ascii?Q?RFsrmB8t34Cn9W5aRf5EHxFy8fgpaf1sIuFTnStybmR96VYm3YajlmHdD0gf?=
 =?us-ascii?Q?pbkgi8tf/YLuFxu12Jt7hjk5frHnOXDHUn20G5HP4znRbf5DLOX50cZIgS1b?=
 =?us-ascii?Q?9BazJ0H4/TnWIOE2lrcUhyERZ1K5zh5z6tBvb6VqBj9UyBvfn/Uvgj99tGHY?=
 =?us-ascii?Q?SKI6C/C3KUc/w8lNL3Ku95Eh5ie1cW07G3t82tBiS9gvsxxM4ffWcM/Vvhyz?=
 =?us-ascii?Q?lxOfOclIN/qjiVq78eedIRciRXANT/sTOuKe0q4R5V2Luho312aLWfzOgawZ?=
 =?us-ascii?Q?QtqcyqOhK7SNybW3SIPgi1nREmoGAu+nqH2EYOIDelzk36/0ggP9w/dvtnI/?=
 =?us-ascii?Q?STYW/D5L7PSZRVodbqgYJydVZswmv13Sm8g+gGILfLd3jYHeY+adBAE0FKbB?=
 =?us-ascii?Q?/dWW7Qyx0EJFqlQ057iFK+/ftJxCx8irxu0uyJZpL0aQBRH3D4+s2l7P2DWi?=
 =?us-ascii?Q?LdiNztH9n3TmRIqltnDk4U9ETwhEwFrmh5C2I4K4?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d63fe99-0d9a-4c62-d549-08dbc617b85b
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 02:55:38.2100
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AWMLsUws8XuH5f5V9wV5cxS7MY5D5vRO4n+dhwnSmVjvd/N8QIu7dwR6gWudsWlOv+K4ZQMoqzRYcGXB0E64Cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR18MB4487
X-Proofpoint-GUID: QHWKMSzHQoGStqgQyP4JrfgkNdLCkuJq
X-Proofpoint-ORIG-GUID: QHWKMSzHQoGStqgQyP4JrfgkNdLCkuJq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-05_18,2023-10-05_01,2023-05-22_02
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 19:56:26 -0700 (PDT)

> From: Jakub Kicinski <kuba@kernel.org>
> Subject: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag alloca=
tion
> failure.
> > +	sz =3D PAGE_ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size),
> OTX2_ALIGN));
> > +	pp_params.order =3D get_order(sz);
>=20
> Surely get_order() rounds up by itself otherwise all callers would have t=
o do
> the PAGE_ALIGN()...
ACK.=20