Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 5 Oct 2023 20:08:36 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Anshuman Khandual <anshuman.khandual@arm.com>,
        Xiongchun Duan <duanxiongchun@bytedance.com>,
        Barry Song <21cnbao@gmail.com>,
        David Rientjes <rientjes@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Joao Martins <joao.m.martins@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations
Message-ID: <20231006030836.GC86415@monkey>
References: <20230925234837.86786-3-mike.kravetz@oracle.com>
 <ddc10c41-515f-48c9-966d-4ae7756d208c@kernel.org>
 <20230929205731.GA10357@monkey>
 <ba5a528d-7e85-77a2-5096-5a143a3b1606@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ba5a528d-7e85-77a2-5096-5a143a3b1606@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9otqYycCb9QQEDHviLeWwAMHJOzfBfnw1DszEidX4Vu1uirop4L5YdjwActc?=
 =?us-ascii?Q?twFpgRebLjMYbomZmcnCOvT8iqmg1l86Rq0HNg0GG5BLifhA9g3OptAX0o1E?=
 =?us-ascii?Q?/fVlgql/8q0u4ooWQHbK17Dg+bocz+tadcUyUMfIiE+Y4LA7wiRVNEv79NoI?=
 =?us-ascii?Q?wZDjl+ONZ7APpmiD7S0IiCAaXuWegaBUQSR17iqAmXKIWp4COElSkNT/WeCc?=
 =?us-ascii?Q?FdYJnJ6t50Dpjx08rEg/3ZYnx0G9VY+jktQSImEcCWZ0MWM1SBfypyLqi/eC?=
 =?us-ascii?Q?LyCAEfXrdscQ9zDKjPcFS2cpQqwq18PQu9p5nsxmfyTXQZ2mMfuyuYmrdTfl?=
 =?us-ascii?Q?QeCR74J9QJ92/4oYBncXXU0MICTJIyDfrGTvIX0c3OEiNqBFjYfTqDW5tRzh?=
 =?us-ascii?Q?uv0UKYTvGcaGdqNaEW+S32mhJkjMpYNFrwsQ5zL1i6VHUyHhSxDB/SyIo69E?=
 =?us-ascii?Q?eKHQ1usUuaDAUg70UCgO7Qw3pv6NKi/6JgHBEQwG0lg25GSctcb6su0/+CLN?=
 =?us-ascii?Q?Cu01e2x9isSS+s1tv55/Se/HKgC/brUY9+zXLefjPkFTLCP+ZNgysaw/73Eu?=
 =?us-ascii?Q?JkjDOLBCpLOqLdAS5TVt3xFMgERTDHUBh9CNIKvLBEg1+z7zMoW8bwQ3b53d?=
 =?us-ascii?Q?mmLwN3gWLtOvMTbOHPusqbbKngJpbqaOiE9u8hGJznLti38YsVYACXfZGaUe?=
 =?us-ascii?Q?f1KHxNhpeDcud1uZAjKrY0G8tp3j0JhVWwgGlVIa5WlbD+1DKY9zk5lRG9Ll?=
 =?us-ascii?Q?u60B2o0kn2NPIyjir1+UoTVCgMu1bFH7XbA0sybZL8OcyOEOXfimVuWJM/x7?=
 =?us-ascii?Q?s7DDhPaDeR4d+uWJKnnpJcpFrBamWH/acBD/LwdOdLGf1PO5HrHKL8j3buXu?=
 =?us-ascii?Q?D2mmP2dvdNPg8+TAy4+MLjKtHhJydUPEoPfNDP8F+gqpUXF7WyxJGmrAlUOZ?=
 =?us-ascii?Q?UEDJmrhSB945IW2DIQoUpUrhCWWn1YgwHH4L+7aa9+Zd313NWtbIzREpGaEF?=
 =?us-ascii?Q?2jEQFV7tzescf6t27vaggo6jo0rqPJhJF1lhpc9IwNNniVMJzPtSekXqMzCk?=
 =?us-ascii?Q?OQmuKLcA/v1YBuDJdputy6ZHlNw89nNlhr1oV54wFm4kUroz/LNKTu+4hS5G?=
 =?us-ascii?Q?1Z11kzqKSmTLootAlccbApPbd/HfF0qFY3C2nPv3Ilc7icriOOcbnqEVyCRW?=
 =?us-ascii?Q?NT7TyclcATZmyJ412PX8DUDhfPfYUaQh3g1DTcSGIM2oPCbsbp5lovS0/P0v?=
 =?us-ascii?Q?OBCtYPE5hTptPr/HJKJ2hDCYhJa9LqlRmXZB+cFSgpWjQQF9ZpI+fWfNW3bz?=
 =?us-ascii?Q?QQ3Cp4vdCIvSNA/N2cyq0J11Fq+smDtkek6E0oB1uS8UtxZtHbLkixWQrFqd?=
 =?us-ascii?Q?sn5E1BkKdJJdGbEgcvsHhV1Wq5cozF/9O6QR6GI0sCE3POJmAaYybAecP0xE?=
 =?us-ascii?Q?zJccwcRhs13nVl2F2KQnVvK6QJuKkzocH36MtknD5a5Y0wzk3Dlm+aPe7HyV?=
 =?us-ascii?Q?T8FWzNnPKLH8+PcNnY+8d4FQS/1blnMPziDTEu48X3BqsajeN+TJbcxXI0Ja?=
 =?us-ascii?Q?QQq1jhMCoyWdUD+X5jIvfiufpW1MtrH9Bs2RtMpr?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?J8y81FduIxxJsEb5m4BtDwNj86h133jAbvF8LBDUiH0sce4IkWtt2haExpfB?=
 =?us-ascii?Q?hsnFsGAyHpqOmRu+/qR3HgQ+vNsVVkh0VNEkDNhhcu48vRMBBdEfhGf3NuuZ?=
 =?us-ascii?Q?GGxeY77iJhY7m0ifVFrODdNcZ00i3HIKJ7m2saxz/X9GC6aqqC2PIrD11Ji4?=
 =?us-ascii?Q?SL5jHhePvHsDnqIbJ07NIXSiaypyOViuYE2w0AcH5CbIMk2TUry1YdRcr5Hq?=
 =?us-ascii?Q?luXppLKk+XIR8b1MjAEGic570N7uLM/UvJyy3HeLL5WqMR7kCN0I5ZqNsdR5?=
 =?us-ascii?Q?mEa6+xOOmq7h1ipAMzE4TKR30Gt0POLjHzK+56bXMjot1DTEcRjHNnKVbIsb?=
 =?us-ascii?Q?3tErCLH0mEvjP/cCml4hIlKcLGqm0SK7yOOBGd6vvdWkFTQ9H7pZgklyyfwE?=
 =?us-ascii?Q?x7nNAZXEgD3ONnZ7AO5pRbpwkBzAGSLiZST73/BFaVBCIkaTf+vLrrOlpdkU?=
 =?us-ascii?Q?5N9q7lhilKq6jNYMybB7NeoAta+wGlGyqDrdVjWKgzn8cE8B+UlRwjzhC7jy?=
 =?us-ascii?Q?UjcT+f5SYrkia16MKknFCjq57wrlUxQgmcHONUNSbya+77847IeZkJmkHF/t?=
 =?us-ascii?Q?aJtxTbYjj36XUMl1CpvQhP9YGv15AZsqVGIxhWunq06yCgFuDzsHLAvlrBOI?=
 =?us-ascii?Q?SaHQbzqxHbg8nKBfHXrrfTKDL27CqsPKQo9patiQzyXEA94D/LRahXYKPxBW?=
 =?us-ascii?Q?byGVQEco/nSMp+wMb1JDTXZc9G3A0nBcCj+DhH9gDUilGtjSPw1xyJF0szvB?=
 =?us-ascii?Q?EPzgjwTHXpojgaLgbFfRdLfq3zIKQEXJzXqegy/9/1Q/NpR+OCAb3s5O1HU+?=
 =?us-ascii?Q?TebclTyAwwXnCYlbLkag49+Y6FDn1MYuP4YDmoajHgvstohWTv6+xB5WgY4h?=
 =?us-ascii?Q?0D64pBiG6/NTo3fqjJJYb/Yg8o9Ck7AYVQJS+xy41/fX0Jo91bAl6sgm2jVX?=
 =?us-ascii?Q?Z7xEY307XpA2Yx7DG/PWy09heX7RPo8wBrHyUq94sVeT1q/CHHD7uCV/H8lf?=
 =?us-ascii?Q?mRt+jcx5EySlfou62WRFCb8naMWMUF7TmqFe0nq+PGwz+4sUgNg8//AkBr+Z?=
 =?us-ascii?Q?PqLLZFPNW6D87sM4A8x2I1qX/fM3nXWVb+8HArvyp+iGu2TMr8uv12nUP1iA?=
 =?us-ascii?Q?rvGuXKxDauwmNl+YLYIX0M1joUJYmHewcw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5d7dc2-4cdc-4afb-7e55-08dbc6198a5c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 03:08:40.3180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qIFw07hg1XuLZOey5yS2IbKtsYPbz2qEODKLWIbmhFejNqZS1nNdxIopDVesGlZQStA/N+/6GHe4GGK6fiIF9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4179
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-05_18,2023-10-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310060023
X-Proofpoint-ORIG-GUID: T4Y_jGDZ47U-xel1NDkSvHLuiVGC_HlF
X-Proofpoint-GUID: T4Y_jGDZ47U-xel1NDkSvHLuiVGC_HlF
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 05 Oct 2023 20:13:24 -0700 (PDT)

On 10/02/23 11:57, Konrad Dybcio wrote:
> 
> 
> On 9/29/23 22:57, Mike Kravetz wrote:
> > On 09/27/23 13:26, Konrad Dybcio wrote:
> > > 
> > > 
> > > On 26.09.2023 01:48, Mike Kravetz wrote:
> > > > Allocation of a hugetlb page for the hugetlb pool is done by the routine
> > > > alloc_pool_huge_page.  This routine will allocate contiguous pages from
> > > > a low level allocator, prep the pages for usage as a hugetlb page and
> > > > then add the resulting hugetlb page to the pool.
> > > > 
> > > > In the 'prep' stage, optional vmemmap optimization is done.  For
> > > > performance reasons we want to perform vmemmap optimization on multiple
> > > > hugetlb pages at once.  To do this, restructure the hugetlb pool
> > > > allocation code such that vmemmap optimization can be isolated and later
> > > > batched.
> > > > 
> > > > The code to allocate hugetlb pages from bootmem was also modified to
> > > > allow batching.
> > > > 
> > > > No functional changes, only code restructure.
> > > > 
> > > > Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> > > > Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> > > > ---
> > > Hi, looks like this patch prevents today's next from booting
> > > on at least one Qualcomm ARM64 platform. Reverting it makes
> > > the device boot again.
> > 
> > Can you share the config used and any other specific information such as
> > kernel command line.
> Later this week.

As mentioned, I have been unable to reproduce on arm64 platforms I can
access.  I have tried various config and boot options.  While doing so,
I came across one issue impacting kernels compiled without
CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP defined.  This is not something
that would prevent booting.

I will send out an updated version series in the hope that any other
issues may be discovered.
-- 
Mike Kravetz