Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <f7e9279b-a2dc-1980-4134-c6868b47b4ee@amd.com>
Date:   Fri, 6 Oct 2023 10:35:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v8 00/25] timer: Move from a push remote at enqueue to a
 pull at expiry model
Content-Language: en-US
To:     Anna-Maria Behnsen <anna-maria@linutronix.de>,
        linux-kernel@vger.kernel.org
Cc:     Peter Zijlstra <peterz@infradead.org>,
        John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Eric Dumazet <edumazet@google.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Arjan van de Ven <arjan@infradead.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sebastian Siewior <bigeasy@linutronix.de>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        Lukasz Luba <lukasz.luba@arm.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>
References: <20231004123454.15691-1-anna-maria@linutronix.de>
From:   K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <20231004123454.15691-1-anna-maria@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWdybmUzQWpTV21tWE5rKzkrU1U4MVp1VUlTS2NoaGIzU0F2Z2Zkb2VZVEp0?=
 =?utf-8?B?NE52ZWllQVpIdGlxV0RsdnhBVlpRTVBHeTZzdjc4K1RBRkJDc0NGaGRqUFN3?=
 =?utf-8?B?TFlwUDdqU0lYZDFtYWNkUzRuSlFlbGtpR2FRSnNBVUdpVlFnamxta2kxSHV2?=
 =?utf-8?B?Ui9ndVhoQjFnanFwbVloUkNsS1NyaWNBRkg1M0lPd3F1RE5jVUZxR1BHK0V5?=
 =?utf-8?B?NVgzb0dDeVhyTmZ1VXlFZm9FZGhVWjROTHhVNld3ZE5ld2hkUDZGbGJWV3ZN?=
 =?utf-8?B?bk0vSWxkQXlYVzVjZTdkSjZJUmQ0c1NQMUdXUTcxY1lWTis4dGRzU25xYUox?=
 =?utf-8?B?WWZpUXFReHgxem5BQlFQUCt6Z3hBUlNYOHI5bUxFbHFTT2xRbWtZS3NXOWVa?=
 =?utf-8?B?NThtcENYa2doaFZXYklDZUtySEFKRHNWQTFmS2ZISDB2VHBnbDZBQlFuZjAy?=
 =?utf-8?B?d2dwemJRLzFZM1lFbHl0azBPN2Z0VDVPQ0ZCYXlWZHJRanZKczhadlNkdFhp?=
 =?utf-8?B?Y1lGMkVNQkZ2NmdFZlcvTnhQNlhYeUpKbUdjWlNjQ2kwaUlQTzlQUmRFMDVa?=
 =?utf-8?B?K2s1Y1J5RGZraFRKVUZrT1M1TE0xblM3QzUxU3BVd3E0V3FidFVqdm5vbGRi?=
 =?utf-8?B?NW9iejQrdE0vRW9ydVhwSnVWcFYzVkhQTk1TeHoxbVRLVnFUL2tqNXExODJV?=
 =?utf-8?B?MmF5MktqWTZaaDlTZm95SHo3dFZMYmtxK2JxVkphRitEWWNaVnlwdnJvLzNW?=
 =?utf-8?B?dmZuZmdHR05ObE5iV3BFaDRNQXBOc3ZQQzFUMlJubkZWelpaSWlLNlBpM1dO?=
 =?utf-8?B?MzJzY3hqMEZBVVFNcGtPcTh4TXM5a21ESGJzV3RwVEZZdU4zaXMvNFBLTVZH?=
 =?utf-8?B?Ym94dXZGVTV6aEY5K1BMemNiMFFkaFBvRHd5dmJ6OEhreUFoeXZLcnFOOS95?=
 =?utf-8?B?Tzc0a1czdzBKclgxR3RuQ2dLVEd4dEkxUkQybGhTeFRWZ1lYbnVxMWlBT1BN?=
 =?utf-8?B?RFBEM3VTWVJjQlNjbTIwa3VPSFNkTEptTmR2SjFQREZlSTIvbmZuNzlSNkFB?=
 =?utf-8?B?SDNwSGNVdE00TDJsQmZiOWVRdTJZRW1SQ0JyMW0zeEswV2RITzBWamI5VmJi?=
 =?utf-8?B?MzA3TEtveXFhcEJvb05aMzF2QktYcXFMYVRQSFl1VnZOaTNwdTA2VWJHOGEr?=
 =?utf-8?B?ZmFKRUg0TGxWdkFXSHpMSHRFcTJrSUFWSEprWTQyVDdvWDFvRjVHTWJGNzl3?=
 =?utf-8?B?MVNnYXdzV2I1b2NoZmcyc3U1MDFnaDVTTFFBbTNKSnV6RnZCWmpndHNScmR0?=
 =?utf-8?B?bFFmWlIreDgxdWlWU0xtRUMyaTMvTkpNVHFGcVZrNGxSYTVtMWZFZ0lzZFV5?=
 =?utf-8?B?WWt2NEQrbzJmY0dGQ2thTjhWM1ZjNm0rcXpHaG9CSDdSWTNJbDMxZWplTFFV?=
 =?utf-8?B?QlJwT2dSQmdVLzZvTTk3NXdiQUl2L3o5dWdNeGFwc1hBZE1CY0V0VzRvSFRJ?=
 =?utf-8?B?SU1SOFh1QkQrdkZGMWtTRDB5aXdycnBlc1BMREwvOEtEK3pBTEFaUUFGSWJi?=
 =?utf-8?B?UU85ZVk0aTNTdEFjbk5EcWlmM1BCZEhpZmRuSWdjVzI4c3FoZjl3VWY1RDVB?=
 =?utf-8?B?RHdwdTFyWUtWUXBNVDYwT1JzSkJMYnB4M0VBMTVtZ1VIMzJSdlFhVTBwdHhY?=
 =?utf-8?B?K0tRa3ZBSFZkK0JKdW5qbkpwQW5ZdnhEUHpIOVZ1dkVYRGtJeXk2UzJrT2Ro?=
 =?utf-8?B?WUp1TUZyWExPUFAwVXhzZTZCT2RmTGJFQXJwSmxyK2QxbHA1Q0pLcTNRR29a?=
 =?utf-8?B?M2szdUh4ZFJlNXY2SEtyUHY1WXFQOG1hR2lNMXlvM3U4Z2FqckZlQW96SFpz?=
 =?utf-8?B?L28rbFRYSEZMWVFBQTE1YThnbUpjYWRwQnhoanFwR0pNWXhJY1hMMDZJWlls?=
 =?utf-8?B?ZTBmZlJaYkNHMGx4aWdiempIREpDaWNjM2JFTWhLU2FaWmZyaU1yTllUcGYv?=
 =?utf-8?B?N3d1YnE3TGdYaS9jSFBvc2NwdzdSei9MY3NweUprdUxLdjIzci9tTmF2VWZ3?=
 =?utf-8?B?ZGxiWVpkMVU0a1IwSTVZeHNTYnZ1akNFZEVBUSt4Skpva3A3OE1GaTNnTS9n?=
 =?utf-8?Q?CoL77/9JatDLcX1bn8+Jaq5X5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 842b25fc-17d4-4e54-1a7f-08dbc629ec79
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 05:05:57.0276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o1xrSvcazxqUQJVvITt1OWm0VcyQ3QOegifHlNTi5ZD3yom6cbVf1LAbJSYcQolIxhiycPH/7wqpMZCtDURLVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8019
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 05 Oct 2023 22:06:11 -0700 (PDT)

Hello Anna-Maria,

On 10/4/2023 6:04 PM, Anna-Maria Behnsen wrote:
> [..snip..]
> 
> Ping Pong Oberservation
> ^^^^^^^^^^^^^^^^^^^^^^^
> 
> During testing on a mostly idle machine a ping pong game could be observed:
> a process_timeout timer is expired remotely on a non idle CPU. Then the CPU
> where the schedule_timeout() was executed to enqueue the timer comes out of
> idle and restarts the timer using schedule_timeout() and goes back to idle
> again. This is due to the fair scheduler which tries to keep the task on
> the CPU which it previously executed on.

Regarding above, are you referring to "wake_up_process(timeout->task)" in
"process_timeout()" ends up waking the task on an idle CPU instead of the
CPU where process_timeout() ran?

In which case, have you tried using the "WF_CURRENT_CPU" flag for the
wakeup? (landed upstream in v6.6-rc1) It is only used by wait queues in
kernel/sched/wait.c currently but perhaps we can have a
"wake_up_process_on_current_cpu()" that process_timeout() can call.

Something along the lines of:

	int wake_up_process_on_current_cpu(struct task_struct *p)
	{
		return try_to_wake_up(p, TASK_NORMAL, WF_CURRENT_CPU);
	}
	EXPORT_SYMBOL(wake_up_process_on_current_cpu);

Thoughts?

> 
> [..snip..]
> 

--
Thanks and Regards,
Prateek