Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp212809rdb; Fri, 6 Oct 2023 00:42:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPYAFIBfPBbKDvQS+qPnOmuoohCvXO+ZS0QjHfwBeIK4i/gkEPXGMTR6I/Qp9QToC08Otm X-Received: by 2002:a05:6a20:565b:b0:14d:5796:bccd with SMTP id is27-20020a056a20565b00b0014d5796bccdmr7059248pzc.24.1696578145584; Fri, 06 Oct 2023 00:42:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696578145; cv=none; d=google.com; s=arc-20160816; b=mvC4NM8OQaM8DZcJIqkQ/bjjEkAoXf/Q95yEyImgmcCWg3s8rdUMNLuCq08bcrUdLI GW6YIXgsE7WhqYrE7B0f54vvwXGDvblCrxeqoS31Cwi9eGpCGzcgOGVqGkcQ/TdIcM+B O79Wi6dAw4QUm1KFLuz3E/CJ131TuXuHq8bAaYhHG12zN3Vg4imyaELFqWnqOQ900Dqa gS/dU52SpSQvvfm5qn/wdeQtd/4r+LXLwcTe8wvTieSiaUQkN8j+dI9vr0A4a2gmJdad gXDBE6/yUO5PlFDNSBTfdNX5oxzF4eJFYi3phC7IjYrkZvgeCtBvHpZuFLIYp7TmbsXZ M0Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=gIlRZMTlZ8FvDxEBaKzMig8ya2slnQBMy/v7Mc6iXpI=; fh=SdaOB8wyhjb8jZGt+kwBIYyXxl3p6ymFmN2Dlnz7JCc=; b=eJsYbD2cVvABTLCOdAO/siwHRo2C829tTIjcmwY2Kk4UvimB/NEuDgi2qniOU7vKt8 EanQsOern7HGVQiPmQt7w3d4iKTQ2eUyWLIzKtCPUtSj66JlySzfzgNbO+U47aYTOOJM jQ1IMasShed8cwn7agxC+ZOfaAt7VXZAzlNuD183Zh6Xnk2ECzFl4JaItwC3sXWrGdpi YCVi+tMPd1onlvCgo2I5mXbkbAurye+tBqjx/KMfenJAgHWa7xqGY1wvzKpAXE/j+TEX ojzBm/8aXiFNmm0jCsd/2IoivkuL5D9p0EF1JHgUiwaohK1zcOpKnZvRXwlcNXlEzhke 4hJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=jH38Vf5s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id cj27-20020a056a00299b00b00690cb77d5e5si924688pfb.394.2023.10.06.00.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 00:42:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=jH38Vf5s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id BDAF8808FA5D; Fri, 6 Oct 2023 00:40:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbjJFHjy (ORCPT + 99 others); Fri, 6 Oct 2023 03:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbjJFHi6 (ORCPT ); Fri, 6 Oct 2023 03:38:58 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34D4100; Fri, 6 Oct 2023 00:38:46 -0700 (PDT) X-UUID: 5ed0dda6641b11eea33bb35ae8d461a2-20231006 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=gIlRZMTlZ8FvDxEBaKzMig8ya2slnQBMy/v7Mc6iXpI=; b=jH38Vf5s5tmXwDXkD3uN3X9XX747LPM1fQT5QRKZPL1B/3SqD2VfWnAoXXygZo7UkJIqnp+B3byizFFJAuaYCRzcGo3yiYU4zW5tNmPOFi+fFRfkLTAzzgRGF2GXXJwi8inqzddBZIwFnM1QmqTcfv4pe96oFF+a0pmErS9pEi4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:69c986a6-8a5c-4feb-83d9-e96ee8d4d538,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:5f78ec9,CLOUDID:96db82f0-9a6e-4c39-b73e-f2bc08ca3dc5,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 5ed0dda6641b11eea33bb35ae8d461a2-20231006 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1750975016; Fri, 06 Oct 2023 15:38:41 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 6 Oct 2023 15:38:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 6 Oct 2023 15:38:40 +0800 From: Hsiao Chien Sung To: AngeloGioacchino Del Regno , CK Hu , Krzysztof Kozlowski , Matthias Brugger , Rob Herring CC: Conor Dooley , Philipp Zabel , David Airlie , Daniel Vetter , Chun-Kuang Hu , Mauro Carvalho Chehab , , , , , , Singo Chang , "Nancy . Lin" , "Jason-JH . Lin" , Hsiao Chien Sung Subject: [PATCH v7 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock Date: Fri, 6 Oct 2023 15:38:27 +0800 Message-ID: <20231006073831.10402-20-shawn.sung@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231006073831.10402-1-shawn.sung@mediatek.com> References: <20231006073831.10402-1-shawn.sung@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 06 Oct 2023 00:40:38 -0700 (PDT) Return the result of clk_prepare_enable() instead of always returns 0. Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for MT8195") Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c index c3adaeefd551..c7233d0ac210 100644 --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c @@ -246,8 +246,7 @@ int mtk_mdp_rdma_clk_enable(struct device *dev) { struct mtk_mdp_rdma *rdma = dev_get_drvdata(dev); - clk_prepare_enable(rdma->clk); - return 0; + return clk_prepare_enable(rdma->clk); } void mtk_mdp_rdma_clk_disable(struct device *dev) -- 2.18.0