Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <b9e51034-bc6c-81d8-39ef-9fc74fa09c62@gmx.de>
Date:   Fri, 6 Oct 2023 10:09:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak
To:     Zhang Shurong <zhang_shurong@foxmail.com>
Cc:     tzimmermann@suse.de, jiapeng.chong@linux.alibaba.com,
        javierm@redhat.com, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <tencent_55C1A344A101B55762ECA6A6366D0B0F8C05@qq.com>
Content-Language: en-US
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <tencent_55C1A344A101B55762ECA6A6366D0B0F8C05@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:PIxdzX21cmo=;/awmiudSoLpgbXtofgLVGPGRkqp
 hPWL6OueJ+V7Rqzz94gLtp6pJC7p0iqiJPgNCcI/rQGrNVP3iDfxrtGGuD4RYD8l5FB33IPax
 ZzYF5psxCJEYsNAxybcNYeU+LVP37FfLA1bRhdX0jHj5y8Q7JVA6NaKIA+COGPNWX0eJ9AG5K
 dGsXZ89bavsxPoacOw7QpNLuDxcCdfrAOzp/3zY2KFhvR2rajVuEjFgIPYEC0h4Uk11cI515j
 0o/ubT2LZp4hw6iTWK3pnt2zsI3hR0h5IJhSmm5e6gw3gERaHne2W9mZcCudMQfd0EtvHE/5V
 UFkuoY5oaTA60tZ0sK+wlkr8U7Vvs9uNrGDGZcomPF+dHKYBz/pPM/2lRUam6svtXoHQ4BwBs
 kZcgCmSeynOlpSCiXF57syZRcAgFisezEbT7RBoy/vKHFhfo/EJCMt24GAWtmLMCMrbkb1BB1
 mXTi2MmhiKjpiWDFTAXOsTKkIqE4kZ/tb5jGVcQuvhuQj8EXmbk+F/04rWHmCfrl5NTGVFqfE
 wbbE6AA1jVeKFocC0QJ2U/GJVasumMFJRRp0Dw8a96+qSlTQ2FZyh10WGrLAiNCqJ7FU6H/jg
 /aFb6QSi3TuFqJuI+WWc2CP0fTS0XSgr5p9BJRDB4S+9CXlYeB7+tYJlOMjSrxtXVKSGPcK3d
 zabtNJ2feeS1P1g6l4VGsGEP6L2SgWf2c/vOZkKeD2t12TznFmEcH9O+af2nrsSUO3D0s/+HJ
 cxfUTQ3bWLPm1FFfvnLiMhi1LJJK+O7Rofwtzwv+4YSDPsvFyrLJfygIhM9XEZp+rkTfSgSts
 REBEC+FGPZbiY7UuGf0dIq8OQu1rJsKqdJ3VwQKtrwrAdPeVP7AF5Dy5HDRR2jf/rY4QkBpXM
 7Cj1TkGKEo5xTaDaZH/FWhg5sK2sSiPW2rVgqAbvn4sJXXly7DsQTfxXyE6hy6F+byT2SjyXR
 +4AZPg==
Precedence: bulk

On 10/5/23 09:01, Zhang Shurong wrote:
> Add missing pci_disable_device() in error path in ark_pci_probe().

Do you have this hardware and tested your patch?
I'm sure there is a reason, why "pci_disable_device()" was commented
out in the original submission in commit 681e14730c73c...

Additionally I'm wondering why your patch doesn't show up in
the fbdev patchwork, although you added linux-fbdev mailing list.
Probably a vger issue.

Helge


> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
> ---
>   drivers/video/fbdev/arkfb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index 60a96fdb5dd8..6c4e5065646f 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -1064,7 +1064,7 @@ static int ark_pci_probe(struct pci_dev *dev, cons=
t struct pci_device_id *id)
>   err_dac:
>   	pci_release_regions(dev);
>   err_request_regions:
> -/*	pci_disable_device(dev); */
> +	pci_disable_device(dev);
>   err_enable_device:
>   	framebuffer_release(info);
>   	return rc;
> @@ -1085,7 +1085,7 @@ static void ark_pci_remove(struct pci_dev *dev)
>
>   		pci_iounmap(dev, info->screen_base);
>   		pci_release_regions(dev);
> -/*		pci_disable_device(dev); */
> +		pci_disable_device(dev);
>
>   		framebuffer_release(info);
>   	}