Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <2b222a2a-f749-46e8-8489-b590dc2061cb@suse.com>
Date:   Fri, 6 Oct 2023 11:11:34 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] x86/tdx: Dump TDX version During the TD Bootup
Content-Language: en-US
To:     Yi Sun <yi.sun@intel.com>, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, peterz@infradead.org,
        x86@kernel.org
Cc:     kirill.shutemov@linux.intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, kai.huang@intel.com,
        linux-kernel@vger.kernel.org, heng.su@intel.com,
        yi.sun@linux.intel.com, Dongcheng Yan <dongcheng.yan@intel.com>
References: <20231006062855.875631-1-yi.sun@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231006062855.875631-1-yi.sun@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzlaMGEvMGU5V0w2M2RwZmRmVTFmWnY0WS9yODFJQzVLNko4SmNkbG1kd3Qy?=
 =?utf-8?B?VnpScUhTQ0RqRld2OEp5UzQzNytlclFoNUpQZ1VOeWJHTWhxcjV6NkI1ZmVv?=
 =?utf-8?B?eVdhdmdRelZ0Vmc5RE9DQ2wzODVsZ3hraExEcEhsM2pFRmREM3lMSk1RTWQ5?=
 =?utf-8?B?dUJ1L0YwU1YxZVRyaHE2ZFl5K1RhOFVwVHNUT0NXUG5MZjJLOXlYRFFYcnZk?=
 =?utf-8?B?V1BUTlY0VUR1OERzaEtCWFN0RlMwdC9NeWtxV3ZhUlBBZ2NyZEVFRVJRR2cr?=
 =?utf-8?B?RVViSk9SL3dlRmxhS05tWUlxUzk0ZG1kNzJRRE5OR3AzRW5ZUm1lNzJLZVJ5?=
 =?utf-8?B?cGYzd2kyRitJL0pHMXNFY2d0ZkZTRXZ5QzNwbjVLZ1FydS9RTDVSQThGMDVz?=
 =?utf-8?B?M1kwSjRTUndSTFhNMGtxTXN3WGkreHhEVXV4eDkrK3lrZFQyTHhVVk9ETk1h?=
 =?utf-8?B?MGR5T1Z4VTJ1R0RtKytYdkxaSjBiRFlTVzhxWm4vWFJRVEE5VDFVRGU0amFP?=
 =?utf-8?B?MDFyZys1Yms5c1p2MnhCWDNoZFpqVU9ZRGdmRzZ6L0NsOUVyUGFSL1RSekQ2?=
 =?utf-8?B?Z2U4U0xXWXFrU05lV3J5MGFZMlZhZGovSTBuYWRlOXBwTmhGM21wNXFzNzhW?=
 =?utf-8?B?S3pqbjRZWFl6N2srZ1RRcCtiNURxeFRFTUxVSFlWTWU5MlRtWUR6WnlRMGdi?=
 =?utf-8?B?WHVhRi9NSTk4ajU2WDBmc1B3d1AwL0dTSm1aOEJWR1BPUWhMdDQwcmJ2UXhk?=
 =?utf-8?B?aGp0anpGQ1dsS1dENkRzTGErN1FWSGR4RXJ6Y3JqT0hWa3FRUUp2Ti82clJ2?=
 =?utf-8?B?V3ZIL05XaTlrYitRY0RXUlI5Um5EQWxLdTlZTDdTTmRjeEtXR3RyL0hYbXpl?=
 =?utf-8?B?N1pPQUJZWDhOY1UvQW5tUXhnU0NTak5NcDRlbUtzOFpWdi9Tc1luTlkzdlFl?=
 =?utf-8?B?UHZUL0NPaVJBOGlkK2ZHZGZWZ0l3d0FDMHJGeC9zdkZ2cGtocDJzZ2JzbUY5?=
 =?utf-8?B?b0txQUI3WFlyQzlZZW10dVBwRTJQNkh2ci9hWElkdHI5c1N1NWFFa2w2WjZF?=
 =?utf-8?B?YWN1Qi80eDhMdWZzTVlCdDFEQ3IwUVduZlVZRTIzMWtCTnFUUFIxSHkzdklM?=
 =?utf-8?B?TnJtYUJiNWxPdEF6ZTF3QXBCSVJHUHVDT090UG1WZkRManI5LzFnQm1qVDR1?=
 =?utf-8?B?RmQ5S3NLdVZRWlJUZ2ZYVmFBaUJXZmI5Q3FhYm9sS1ZDK0tzaFRzbEdwL1o0?=
 =?utf-8?B?K3pxOXR6UDc3RFZSbmxyUkpzM3pKUTJhQzRCTjN0Z0JUOXdseWRiTlBlV0pz?=
 =?utf-8?B?YkdEVTlVZE11ZG9SVGNObUpEV0F5U043dXB3SHhwb2ozMGg2WTh3WUQwY3pv?=
 =?utf-8?B?b2lPYnh6b08vS3krNklwbmZORkdLNWVvMjlTMFM5QlJ6V3hoMEdsaUZSMzUv?=
 =?utf-8?B?QnJSc2xENS9jZk9YRXdjWVVLTmx1c3BJTmJvSlJoWU1ZbjhKZ3hKQlBMcG8x?=
 =?utf-8?B?eXFsajRYaHpleEJGZkhZUjNNNGlObm1GYjlsQ0htVHNRZDhkWVBGWVUzbk5a?=
 =?utf-8?B?MU5SdXMzTjZMb3hYdFhNNXdUVkM2bDdaTDUvSEhMM0dERlpSNjVtaWxEZlRE?=
 =?utf-8?B?SDlPS2ViTVAzTW1JZ2ZqMVhBRlYzWjBGQ3l3UEkyS3lCVlBxVExkdDQ3cW9N?=
 =?utf-8?B?Vm1hZ2dnOWc1UFpMTTIrSmVkek1udTN4ODU2ZXc5OWZNcEFSSGlBUWJsMnc3?=
 =?utf-8?B?SlFjUnB0bmcwRTNBaUQweGIvWjNqdVh3RG1VM0Jua1JLVVRlSVk4Uk9KRE9q?=
 =?utf-8?B?SWg1dDF5YVg1citrd29xeTVQNW1ZRzVuZXFGR3dwQzE2TGFiZ2t1NGU2ZHRZ?=
 =?utf-8?B?UHlTSkp1c3pTdG5reTJpNVJvUitVK0dZelZranA4M0lmUXkzaHRXYkhWVk13?=
 =?utf-8?B?RjAzZkRvM043VmlwVmFSR2MxR2oxYlp0RXFsQ3NiUFY0V05wQTBUTWcyMjkw?=
 =?utf-8?B?Q0F3KzdYR3p2ZVUvQkNwdkZZbEhXZVQ2Tzl2Y3JOUE1GSlkvQ2NYb3RKOFpo?=
 =?utf-8?B?dTJsSmI5RHJIQzk4R0JYV1N2VzBIRjg3TXUwQXFGWkYwd0w1ZGI4WlF0RmlY?=
 =?utf-8?B?WnJSY0h6d2phNGIrM0lFRFJMY1VLSVQvWlpaZjRJTmRKa2NJbFN0MU41dmNV?=
 =?utf-8?Q?VuBLpqXhJbE/mg+BW4592dqWOPytUS53Hm8dSG3ETGN3?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f89b082-c102-425e-e6cb-08dbc643dcef
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 08:11:37.7368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NWiK/1WRSVQa9a9EAMMBsoZ0t43vX20sL4Db0twEuY8O1KbRm6skuzcENJ+kbwpQUhAR4pMATQCelXtvoOa6mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6847
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 01:11:53 -0700 (PDT)


On 6.10.23 г. 9:28 ч., Yi Sun wrote:
> It is essential for TD users to be aware of the vendor and version of
> the current TDX. Additionally, they can reference the TDX version when
> reporting bugs or issues.
> 
> Furthermore, the applications or device drivers running in TD can achieve
> enhanced reliability and flexibility by following the TDX Module ABI
> specification, because there are significant differences between different
> versions of TDX, as mentioned in the "Intel® TDX Module Incompatibilities
> between v1.0 and v1.5" reference. Here are a few examples:
> 
> MSR Name		Index		Reason
> ----------------------------------------------
> IA32_UARCH_MISC_CTL	0x1B01		From v1.5
> IA32_ARCH_CAPABILITIES	0x010A		Changed in v1.5
> IA32_TSX_CTRL		0x0122		Changed in v1.5
> 
> CPUID Leaf	Sub-leaf	Reason
> ---------------------------------------
> 0x7		2		From v1.5
> 0x22		0		From v1.5
> 0x23		0~3		From v1.5
> 0x80000007	0		From v1.5
> 
> During TD initialization, the TDX version info can be obtained by calling
> TDG.SYS.RD. This will fetch the current version of TDX, including the major
> and minor version numbers and vendor ID.
> 
> The TDCALL TDG.SYS.RD originates from TDX version 1.5. If the error
> TDCALL_INVALID_OPERAND occurs, it should be treated as TDX version 1.0.
> 
> If the __tdcall_ret fails, expect a zero value for all tdx sys info.
> No additional error code is necessary to avoid introducing noise during
> the bootup.
> 
> Co-developed-by: Dongcheng Yan <dongcheng.yan@intel.com>
> Signed-off-by: Dongcheng Yan <dongcheng.yan@intel.com>
> Signed-off-by: Yi Sun <yi.sun@intel.com>
> 
> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index 3e6dbd2199cf..991f7dc695bd 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -37,6 +37,24 @@
>   
>   #define TDREPORT_SUBTYPE_0	0
>   
> +/*
> + * TDX metadata base field id, used by TDCALL TDG.SYS.RD
> + * See TDX ABI Spec section 3.3.2.3 Global Metadata Fields
> + */
> +#define TDX_SYS_VENDOR_ID_FID		0x0800000200000000ULL
> +#define TDX_SYS_MINOR_FID		0x0800000100000003ULL
> +#define TDX_SYS_MAJOR_FID		0x0800000100000004ULL
> +#define TDX_VENDOR_INTEL		0x8086
> +
> +/*
> + * The global-scope metadata field via TDG.SYS.RD TDCALL
> + */
> +struct tdg_sys_info {
> +	u32 vendor_id;
> +	u16 major_version;
> +	u16 minor_version;
> +};
> +
>   /* Called from __tdx_hypercall() for unrecoverable failure */
>   noinstr void __noreturn __tdx_hypercall_failed(void)
>   {
> @@ -800,6 +818,60 @@ static bool tdx_enc_status_change_finish(unsigned long vaddr, int numpages,
>   	return true;
>   }
>   
> +/*
> + * Parse the tdx module version info from the global-scope metadata fields.
> + *
> + * Refer to Intel TDX Application Binary Interface (ABI) section
> + * "TDG.SYS.RD".
> + */
> +static void tdg_get_sysinfo(struct tdg_sys_info *td_sys)
> +{
> +	u64 ret;
> +	struct tdx_module_args args = {
> +		.rdx = TDX_SYS_VENDOR_ID_FID,
> +	};
> +
> +	if (!td_sys)
> +		return;
> +
> +	memset(td_sys, 0, sizeof(struct tdg_sys_info));

So in case of an error this function would effectively zero out 
tdg_sys_info and not explicitly mention that something went wrong. Dunno 
how sensible or likely it is to get an error while requesting the ID_FID 
? Also why don't you check for errors on subsequent calls to TDG.SYS.RD ?

> +
> +	/*
> +	 * TDCALL leaf TDX_SYS_RD
> +	 * Input Field Identifier via RDX and get the output via R8.
> +	 */
> +	ret = __tdcall_ret(TDX_SYS_RD, &args);
> +	/*
> +	 * The TDCALL TDG.SYS.RD originates from TDX version 1.5.
> +	 * Treat TDCALL_INVALID_OPERAND error as TDX version 1.0.
> +	 * If other errors occur, return with zero td_sys.
> +	 */
> +	if (TDCALL_RETURN_CODE(ret) == TDCALL_INVALID_OPERAND)
> +		goto version_1_0;
> +	else if (ret)
> +		return;
> +
> +	td_sys->vendor_id = (u32)args.r8;
> +
> +	args.rdx = TDX_SYS_MAJOR_FID;
> +	__tdcall_ret(TDX_SYS_RD, &args);
> +
> +	td_sys->major_version = (u16)args.r8;
> +
> +	args.rdx = TDX_SYS_MINOR_FID;
> +	__tdcall_ret(TDX_SYS_RD, &args);
> +
> +	td_sys->minor_version = (u16)args.r8;
> +
> +	return;
> +
> +	/* TDX 1.0 does not have the TDCALL TDG.SYS.RD */
> +version_1_0:
> +	td_sys->vendor_id = TDX_VENDOR_INTEL;
> +	td_sys->major_version = 1;
> +	td_sys->minor_version = 0;
> +}
> +
>   void __init tdx_early_init(void)
>   {
>   	struct tdx_module_args args = {
> @@ -808,6 +880,7 @@ void __init tdx_early_init(void)
>   	};
>   	u64 cc_mask;
>   	u32 eax, sig[3];
> +	struct tdg_sys_info td_sys_info;
>   
>   	cpuid_count(TDX_CPUID_LEAF_ID, 0, &eax, &sig[0], &sig[2],  &sig[1]);
>   
> @@ -867,5 +940,9 @@ void __init tdx_early_init(void)
>   	 */
>   	x86_cpuinit.parallel_bringup = false;
>   
> -	pr_info("Guest detected\n");
> +	tdg_get_sysinfo(&td_sys_info);
> +
> +	pr_info("Guest detected. TDX version:%u.%u VendorID: %x\n",
> +		td_sys_info.major_version, td_sys_info.minor_version,
> +		td_sys_info.vendor_id);
>   }
> diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
> index f74695dea217..d326509832e6 100644
> --- a/arch/x86/include/asm/shared/tdx.h
> +++ b/arch/x86/include/asm/shared/tdx.h
> @@ -17,6 +17,7 @@
>   #define TDG_MR_REPORT			4
>   #define TDG_MEM_PAGE_ACCEPT		6
>   #define TDG_VM_WR			8
> +#define TDX_SYS_RD			11
>   
>   /* TDCS fields. To be used by TDG.VM.WR and TDG.VM.RD module calls */
>   #define TDCS_NOTIFY_ENABLES		0x9100000000000010