Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Kees Cook' <keescook@chromium.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "'linux@rasmusvillemoes.dk'" <linux@rasmusvillemoes.dk>,
        'Steven Rostedt' <rostedt@goodmis.org>,
        "'bvanassche@acm.org'" <bvanassche@acm.org>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "Nathan Chancellor" <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: [PATCH v2 next] compiler.h: Move __is_constexpr() to compiler.h.
Thread-Topic: [PATCH v2 next] compiler.h: Move __is_constexpr() to compiler.h.
Thread-Index: AQHZ96gTRq31SBDNvUGrpdwig3TLHLA8axEg
Date:   Fri, 6 Oct 2023 08:28:04 +0000
Message-ID: <a52781cd79104c978289d3d5e98b0cd4@AcuMS.aculab.com>
References: <2a6680bbe2e84459816a113730426782@AcuMS.aculab.com>
 <202310050921.F0B15702D4@keescook>
In-Reply-To: <202310050921.F0B15702D4@keescook>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Kees Cook
> Sent: 05 October 2023 17:22
> 
> On Thu, Oct 05, 2023 at 11:39:54AM +0000, David Laight wrote:
> > Prior to f747e6667ebb2 __is_constexpr() was in its only user minmax.h.
> > That commit moved it to const.h - but that file just defines ULL(x) and
> >   UL(x) so that constants can be defined for .S and .c files.
> > So apart from the word 'const' it wasn't really a good location.
> > Instead move the definition to compiler.h just before the similar
> >   is_signed_type() and is_unsigned_type().
> > This may not be a good long-term home, but the three definitions
> >   belong together.
> >
> > Signed-off-by: David Laight <david.laight@aculab.com>
> 
> Yeah, this is what I'd expect (a duplicate move in tools/). Thanks!

I did try to run something that might have built 'perf'.
But it complained about a lot of stuff not being installed.

I do wonder if a better home for all these is_xxx() and __is_xxx()
would be at the top of build_bug.h.

While they can be used on their own (eg with __builtin_choose_expr())
they are typically used with the compile-time asserts
(or at least with code that is also doing asserts.)
So there might only be a few places that need the extra #include.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)